From: Andreas Claesson <andreas@aclaesson.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <bentiss@kernel.org>,
Chen Changcheng <chenchangcheng@kylinos.cn>,
Danish Khateeb <danishkhateeb03@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: corsair: cancel LED work again after unregistering the LED
Date: Fri, 20 Nov 2026 12:32:24 +0000 [thread overview]
Message-ID: <179517794443.913379.16756320627305412346@aclaesson.com> (raw)
In-Reply-To: <30po4s0s-7n8n-1q84-40r3-623n6n45p005@xreary.bet>
On Thu, 19 Nov 2026, Jiri Kosina wrote:
> Applied to hid.git#for-7.4/upstream-fixes, thanks.
Thanks, but I think this one should be dropped again, sorry for the
noise.
for-7.4/upstream-fixes also has cc8d022e8679 ("HID: corsair: use
disable_work_sync() to tear down the LED workers") from Danish, which
fixes the same bug and which I had missed when I sent mine. With the
work disabled before led_classdev_unregister(), the LED-off request can
no longer queue it, so the cancel_work_sync() calls my patch adds on
top (e624a56578e5) do nothing, and the comment it adds is no longer
true.
It is harmless, so if dropping it is inconvenient I can send a revert
instead, whichever you prefer.
Thanks,
Andreas
prev parent reply other threads:[~2026-11-20 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 19:55 Andreas Claesson via B4 Relay
2026-11-19 20:30 ` Jiri Kosina
2026-11-20 12:32 ` Andreas Claesson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179517794443.913379.16756320627305412346@aclaesson.com \
--to=andreas@aclaesson.com \
--cc=bentiss@kernel.org \
--cc=chenchangcheng@kylinos.cn \
--cc=danishkhateeb03@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®