From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.52 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795191723; b=Je4pM4aOJFGJKXnf5kR4GOvW76bHftQMwmG4U4bi/KZkcmLUbDpghlp++BmBccSJ6PD8 23SiW6Ln3mHcV3bXCLy0Wg14qPeBGx/oNxey5HOHIcmt/pH2M/8PBvSSWIMt6GIU6tH7O CWiYEucs5ox8265K8sN/lkepcS6Bgjs2s66BWWyrO6z8qy96HLQ41uaQWITPd66t7fAvA prFW/art2uNj3JqPdRcSBtWLukVgfQ1FbrbZm5wVj9o11KvVOP9zp1J0it2FiuZXEVBmS SViqziQxujTebnGTqGQ0GEToIIbK++/m+tJo2mWXda2Xl+81FrlZWmWr2qxn/1A+qIw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795191723; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: MIME-Version:Content-Type:Content-Transfer-Encoding:Subject:From:To: Cc:In-Reply-To:References:Date:Message-Id:X-Mailer: X-Developer-Signature:X-Developer-Key; bh=McN17chfwr/LQozF6dFVi78SiwnCLQfwPyBkDcQsbSc=; b=dhWnFTEGiehfttw/T8X9MhXd4kBzBv5hZWl5IXfoGPWmuKPA9Fhfc4gL+95fZOWIWb// 8arxI5AHH6xd+fk5WYtAu1ksVP43TnL7evq7nAiHt36CSLNWsz+VWoaex/wESZYcT1AxT GASAVCUGKtX8nNTVXEjK5xjd5zx38+usYsvA8rwkAxrewERNEkCph9WWGQwYibohWK7wU Xiht6xUdse37ngxYMksgUxsbG1j8vp+Z73D+5rFXZkwna13alzYdvBE2cmS3brFnRid4C jIZ94roDSpTFyV829l98WTRsoD+1/nx+fRTVpvI6ctwua9mZFrRWemJ9DWAwNX9PJmQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=GSMVwhZH; arc=none smtp.remote-ip=209.85.221.52 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABCCF606A32C for ; Fri, 20 Nov 2026 16:22:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org ABCCF606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=GSMVwhZH Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-490c3ae81d3so665375f8f.2 for ; Fri, 20 Nov 2026 08:22:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1795191721; x=1795796521; darn=vger.kernel.org; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:content-type:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=McN17chfwr/LQozF6dFVi78SiwnCLQfwPyBkDcQsbSc=; b=GSMVwhZH/ueBlJaQiJ5tBFKzOag7BCR5BhXV1vjJ6yXySEI0mT2VMeFtR8YLI3QObp l+9xoHrKeIBmt2kbouQcLmWeYtsw1SAQsvk19IVm1GoRn/dd5U/zC3gpB7SsC82DLkMC 1PxNoFLz19cCa9xeO6jQ1x7QwuiDjsSlO2ve/tZs/untp7QF97TlsVV0fEDCtGEfppcN kyTRRyJYJMxJzqyhtxryQTDEnVcltPPWcx/qW5dbw8GLPGUI+zwUL6SyrZNl/H/CXbIh DN4P0fC06cQ3rv1oqcphHJY9Or07QdoJ0BJ3bnq6/b+HufHJMelC+YFHl3KH9tbwoTMF pdTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795191721; x=1795796521; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:content-type:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=McN17chfwr/LQozF6dFVi78SiwnCLQfwPyBkDcQsbSc=; b=uHjgw/syVxmfCtu/a9CdoFnM3UyWn+q5b881bhqCtENTQjZlINM2Zg1MyrcGlMAbRE Iz97mhhbc0721LamBIHep/k/VQJVLpQ0NE+ZUMGQbtE87HrOyvo2218luxn1Nz8dJLQB +kwqP3pEEpXPnCpoBjgp6G2XruUzUx+4yeyyXr4JarKVyBfQBccZnPo5iGyKpRfJST8Z k4UyfZPC4rX8Wd8ZxNFsyDDrb0na8gNMQCQzzIM2wWSVfFrSt9r+bV3JITFvrKMYdjm9 9TdNhlpGJrpRDlcPyWg8j+qk2MCj022b9lrh/vGOyab4i3U0LdGKAfaJmdbf/5TO3rkF 31gg== X-Forwarded-Encrypted: i=1; AL+hErERgfZYn3L1Jj54NLMAzy3aFmGLmqv7Cy/2yxa+6b/ZmA6e/7zpvLj02TIjSQ79pluBOW2RAMRr9kteyJM=@vger.kernel.org X-Gm-Message-State: APuU4Z9l1F9H0KZqr1739EJc0ArC4nYFVrIEFXJHtKtNnEpk0VjdlKV+ txlgcuqNwfdH+x5dFBO1p+lH63jrvGSnX5XoXDHINx8nw2SPBoyKV/KwWc+OB8N6RaA= X-Gm-Gg: AYBFou0RnC88PVGw/ba+0kaT2oTDUgem9+4scjnu9kD9p0LRp8feYS5fb+CB86mEtln mWVj9NoCt7q/Iji/GpXum3UBGE7MRsM3yk4Bjw5RX5kR7YZZeozIF72Byq9kj4vt3bjs1zAnDFE HngS1CoXyJ78VZFjdeSYN5FoLXD0dfiPAAkrO/lT2/ggzIOETnvfa2kfNh+Y0FLNG4v5nvKBJgy Fl+W1CjGtnFkZQ2nbAho4di7lTK5fLHmogxi+zqS4FvwvbzitFQ5roAXHgNc3zCJ7FVz7LotPz2 B2UfkWbsHcvv+D/MJaAZOA2ekYk7uqJOOd9ZlPwz0hL8s0c/LjgGUKbcfp/tbI/OH0KwJmGp5q7 IqBsMWlZ7l8xDoa+dN8E9mzhyH7OwJZgDTfv1syAFIuY+GZxlyKFPEbbdWxQzMnayrsFSMqn0eM IDjAUfebY4LCrnB+lTk4o8m0g6YAVAIjl8O50fjcX8/IaVWb4pLC91nesqPIQPNxvzwmzW8LhPK DlkcIc17KnGQP/NDk/wMXaAysrINFGpKa26OfaoOg4vSVPlKOw5VPcPlI5KCbsgqv0J0gU1PCNI tz2hfypflEckwDIuorwuZNDQ6y2hwitXSGXnJJ0Aw69CVSMF X-Received: by 2002:a05:600c:3e1a:b0:4bb:6814:7391 with SMTP id 5b1f17b1804b1-4bb8881921cmr77585875e9.25.1795191721065; Fri, 20 Nov 2026 08:22:01 -0800 (PST) Received: from localhost (82-67-6-57.subs.proxad.net. [82.67.6.57]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb853ca452sm129338075e9.15.2026.11.20.08.22.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2026 08:22:00 -0800 (PST) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v12 00/10] clk: nuvoton: ma35d1: Fix mux parenting and peripheral clock rates From: Jerome Brunet To: Miquel Raynal Cc: Jacky Huang , Shan-Chun Hung , Michael Turquette , Stephen Boyd , Richard Cochran , Arnd Bergmann , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Jeffery , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Thomas Petazzoni , Steam Lin , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, stable@vger.kernel.org, Jerome Brunet In-Reply-To: <20261118-perso-ma35d1-upstream-clk-v12-0-bee2c8dad4e1@bootlin.com> References: <20261118-perso-ma35d1-upstream-clk-v12-0-bee2c8dad4e1@bootlin.com> Date: Fri, 20 Nov 2026 17:21:57 +0100 Message-Id: <179519171774.3795820.6006858658982158181.b4-review@b4> X-Mailer: b4 0.17-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=1505; i=jbrunet@baylibre.com; h=from:subject:message-id; bh=da1CAgmUNSJ5Vw/XW6Lz4OSgqJ+yn+Z+QoMk5bui0gM=; b=owGbwMvMwCW2VtK+WnvWU3HG02pJDNkMxctdWw95f775+kf6Kd3uhXaOSe5//1wwaWVeY9QYX yM9mbu/o5SFQYyLQVZMkaWGu1r8naTWl1nTdW7DzGFlAhnCwMUpABOxMGf4nyRy6+VEnRlFq7fI GagKJv1//7Hkw7/YmsPPe/Y99eOVz2NkuJ8445EhV1vDy2cFLl7ntuvVZT55xxi3U6SLM/uNTEA fBwA= X-Developer-Key: i=jbrunet@baylibre.com; a=openpgp; fpr=F29F26CF27BAE1A9719AE6BDC3C92AAF3E60AED9 > I am in possession of an MA35D1 NuMaker board. The SPI controller has > been contributed, but at this stage it does not work with the current > clock driver. > > The clock controller registers its muxes with .fw_name parent data, > which requires every internal clock name to be declared in the DT. As > the DT does not declare them, all parent lookups fail: muxes end up > registered as root clocks and most peripherals read a zero rate. > > This conversion exposed a first issue with the WDT/WWDT parents which > were actually missing in the clock driver. I am not using these clocks > myself but it is worth fixing. > > The second round of reviews raised another problem with the > crystals. HXT and LXT are external crystal oscillators wired on the > board, while HIRC and LIRC are on-chip RC oscillators. HXT was described > whereas LXT was not. The series now also takes the two crystal inputs > from the DT: they get documented in the bindings, described in the > boards and looked up by the driver (with a fallback for backward > compatibility). > > Finally, I was still unsatisfied by the clock tree because there were > too many root clocks. Many "gates" were wrongly set aside from the > downstream clocks they would gate, and SYSPLL was simply not parented at > all (?). > > The clock tree now looks much more accurate. > > Signed-off-by: Miquel Raynal Looks good overall. just 2 tiny nitpick and we are good. -- Jerome