From: Jerome Brunet <jbrunet@baylibre.com>
To: Daniel Almeida <daniel.almeida@collabora.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Michal Wilczynski" <m.wilczynski@samsung.com>,
"Drew Fustini" <fustini@kernel.org>,
"Guo Ren" <guoren@kernel.org>, "Fu Wei" <wefu@redhat.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Brian Masney" <bmasney+clk@redhat.com>,
"Jerome Brunet" <jbrunet+clk@baylibre.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
linux-pm <linux-pm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-pwm <linux-pwm@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
rust-for-linux <rust-for-linux@vger.kernel.org>,
"Boris Brezillon" <boris.brezillon@collabora.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Maurice Hieronymus" <mhi@mailbox.org>,
"Jerome Brunet" <jbrunet@baylibre.com>
Subject: Re: [PATCH v6 0/7] Clk improvements
Date: Fri, 20 Nov 2026 17:48:38 +0100 [thread overview]
Message-ID: <179519331840.3795820.8047048832159165355.b4-reply@b4> (raw)
In-Reply-To: <1a1cb87df11.2c57f9fa237371.844135553238709982@collabora.com>
On 2026-11-11 13:54:01-03:00, Daniel Almeida wrote:
> Hi all,
>
> > This series contains a few improvements that simplify clock handling for
> > drivers.
> >
> > Patch 1 converts clk.rs to the kernel-vertical style for imports.
> >
> > Patch 2 replaces OptionalClk with Clk::get_optional(). There is no struct
> > optional_clk in C, and Clk already allows a NULL pointer.
> >
> > Patch 3 implements the same typestate pattern that has been used
> > successfully for Regulators. This is needed because otherwise drivers
> > will be responsible for unpreparing and disabling clocks themselves and
> > ultimately handling the reference counts on their own. This is
> > undesirable. The patch automatically encodes this information using the
> > type system so that no misuse can occur.
> >
> > Patch 4 adds guards that prepare and/or enable a clock for the lifetime
> > of the guard without consuming the Clk, so that a driver can keep a
> > long-lived Clk<Prepared> and enable it for scoped sections.
> >
> > Patch 5 makes things more convenient by offering devres-managed APIs. This
> > lets drivers set clock parameters once and forget about lifetime
> > management.
> >
> > Patch 6 adds ExclusiveClk<T>, which holds rate exclusivity over a Clk<T>
> > in any state until it is dropped.
> >
> > Patch 7 uses it in pwm-th1520 to lock the clock rate for the lifetime of
> > the driver data.
Hi there,
I was wondering how the rust folks expect these changes to be handled since they
touch the rust/ dir. Should the clock changes go through the clock tree or the
rust one ? it is fine with me either way.
I've added small comments on patch 3, with my understanding of what of what you
are trying to do. Please take them with a grain of salt. While I'm eager to help
rust grow in the kernel, I'm definetely very new to it. It is very likely I got
things wrong.
If there are pain points regarding clocks with Rust, please feel free to
reach me or Brian. We are happy to help if we can.
Cheers
--
Jerome
next prev parent reply other threads:[~2026-11-20 16:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 17:07 Daniel Almeida
2026-10-13 17:07 ` [PATCH v6 1/7] rust: clk: use 'kernel vertical style' for imports Daniel Almeida
2026-11-18 13:47 ` Alice Ryhl
2026-10-13 17:07 ` [PATCH v6 2/7] rust: clk: replace `OptionalClk` with `Clk::get_optional()` Daniel Almeida
2026-11-18 13:47 ` Alice Ryhl
2026-10-13 17:07 ` [PATCH v6 3/7] rust: clk: use the type-state pattern Daniel Almeida
2026-11-18 13:47 ` Alice Ryhl
2026-11-20 16:48 ` Jerome Brunet
2026-10-13 17:07 ` [PATCH v6 4/7] rust: clk: add guards for scoped prepare and enable Daniel Almeida
2026-11-18 13:47 ` Alice Ryhl
2026-10-13 17:07 ` [PATCH v6 5/7] rust: clk: add devres-managed clks Daniel Almeida
2026-11-18 13:47 ` Alice Ryhl
2026-11-18 14:24 ` Gary Guo
2026-11-18 14:47 ` Daniel Almeida
2026-10-13 17:07 ` [PATCH v6 6/7] rust: clk: add `ExclusiveClk` Daniel Almeida
2026-10-13 17:14 ` Daniel Almeida
2026-11-18 13:47 ` Alice Ryhl
2026-10-13 17:07 ` [PATCH v6 7/7] pwm: th1520: Lock clock rate with clk_rate_exclusive_get Daniel Almeida
2026-11-11 16:54 ` [PATCH v6 0/7] Clk improvements Daniel Almeida
2026-11-20 16:48 ` Jerome Brunet [this message]
2026-11-20 21:31 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179519331840.3795820.8047048832159165355.b4-reply@b4 \
--to=jbrunet@baylibre.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=bmasney+clk@redhat.com \
--cc=boqun@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fustini@kernel.org \
--cc=gary@garyguo.net \
--cc=guoren@kernel.org \
--cc=jbrunet+clk@baylibre.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lossin@kernel.org \
--cc=m.wilczynski@samsung.com \
--cc=mhi@mailbox.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=simona@ffwll.ch \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=ukleinek@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=wefu@redhat.com \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®