From: Kyuwon Cho <kyuwoncho18@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Carlos Maiolino <cem@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Aldo Ariel Panzardo <qwe.aldo@gmail.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] xfs: reject a hole in a remote xattr value
Date: Sat, 21 Nov 2026 14:05:10 +0900 [thread overview]
Message-ID: <179523678723.1642977.7101755246592074809@gmail.com> (raw)
In-Reply-To: <awB1mmg22PhD_efC@infradead.org>
xfs_attr_rmtval_get() maps the blocks of a remote xattr value from the
on-disk value length and only asserts that a mapping is not a hole. The
leaf verifier caps the length at XFS_XATTR_SIZE_MAX but does not check
it against the blocks the value owns, so a larger length makes the read
reach a hole. Without CONFIG_XFS_DEBUG the hole becomes a disk address
past the end of the device:
xfs_buf_map_verify: daddr 0x258000001a7f0 out of range, EOFS 0x96000
WARNING: fs/xfs/xfs_buf.c:423 at xfs_find_get_buf+0x160f/0x2350
Call Trace:
xfs_buf_read_map (fs/xfs/xfs_buf.c:648)
xfs_attr_rmtval_get (fs/xfs/libxfs/xfs_attr_remote.c:434)
xfs_attr3_leaf_getvalue (fs/xfs/libxfs/xfs_attr_leaf.c:2718)
Check for a hole or a delalloc extent at run time and return
-EFSCORRUPTED, as xfs_attr_rmtval_stale() does.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kyuwon Cho <kyuwoncho18@gmail.com>
---
Christoph, understood: an image with crafted metadata and recomputed
CRCs is outside the XFS threat model, so this is a hardening fix for
such an image, not a security fix. It does the same run-time check as
xfs_attr_rmtval_stale().
The patch was written with LLM assistance; we reviewed and tested it.
It applies to the xfs for-next branch. With it, the reproducer from the
report no longer triggers the warning, and XFS reports the corruption
instead.
fs/xfs/libxfs/xfs_attr_remote.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_attr_remote.c b/fs/xfs/libxfs/xfs_attr_remote.c
index e6c8dd1a997a..722440f005ca 100644
--- a/fs/xfs/libxfs/xfs_attr_remote.c
+++ b/fs/xfs/libxfs/xfs_attr_remote.c
@@ -427,8 +427,11 @@ xfs_attr_rmtval_get(
xfs_daddr_t dblkno;
int dblkcnt;
- ASSERT((map[i].br_startblock != DELAYSTARTBLOCK) &&
- (map[i].br_startblock != HOLESTARTBLOCK));
+ if (XFS_IS_CORRUPT(mp, map[i].br_startblock == DELAYSTARTBLOCK) ||
+ XFS_IS_CORRUPT(mp, map[i].br_startblock == HOLESTARTBLOCK)) {
+ xfs_bmap_mark_sick(args->dp, XFS_ATTR_FORK);
+ return -EFSCORRUPTED;
+ }
dblkno = XFS_FSB_TO_DADDR(mp, map[i].br_startblock);
dblkcnt = XFS_FSB_TO_BB(mp, map[i].br_blockcount);
error = xfs_buf_read(mp->m_ddev_targp, dblkno, dblkcnt,
--
2.43.0
prev parent reply other threads:[~2026-11-21 5:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 3:04 [BUG] xfs: a remote xattr valuelen larger than its blocks makes getxattr() read a hole and warn Kyuwon Cho
2026-11-20 16:30 ` Christoph Hellwig
2026-11-21 5:05 ` Kyuwon Cho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179523678723.1642977.7101755246592074809@gmail.com \
--to=kyuwoncho18@gmail.com \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=qwe.aldo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®