From: Konstantin Nikiforov <helllamer@gmail.com>
To: linux-raid@vger.kernel.org
Cc: linux-bcache@vger.kernel.org, regressions@lists.linux.dev,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Yu Kuai <yukuai@fygo.io>, Song Liu <song@kernel.org>,
Coly Li <colyli@fygo.io>,
Kent Overstreet <kent.overstreet@linux.dev>,
magiclinan@didiglobal.com, xiao@kernel.org
Subject: Re: [PATCH] md/raid5: complete unsupported discards successfully
Date: Sun, 22 Nov 2026 00:21:15 +0300 [thread overview]
Message-ID: <179529607529.5.3302391929789139470@gmail.com> (raw)
In-Reply-To: <179299857972.12222.2729359466842183358@gmail.com>
Hi Kuai,
I built and tested md-7.5 with b964c9240a37 on the machine from the
regression report. The reproducer passes and the machine runs without
backing-device errors.
Tested tree
-----------
md-7.5 tip c526b7cd32f7, based on v7.4-rc2, with b964c9240a37 applied.
Built as 7.4.0-rc2-md75+ (x86_64, Arch config, gcc 16.2.1) and booted
on the affected machine.
Reproducer
----------
Three 256M loop files -> raid5 (64K chunk, metadata 1.2) -> bcache
backing device. devices_handle_discard_safely is left at its default
(N), so the array takes the raid5_discard_limits() path changed by the
patch.
md125: discard_max_bytes=2199023255040, discard_granularity=131072
blkdiscard 8M on md125: exit 0
bcache1 over md125: discard_max_bytes=2199023255040
4x blkdiscard 8M on bcache1: io_errors=0, no
bch_count_backing_io_errors lines in dmesg
The same reproducer gave io_errors=4 with the unpatched 7.2.11 module.
With the patched 7.2.11 module, and now with this kernel, it stays 0.
Affected machine
----------------
3x ST1000DM010 (no TRIM) -> md126 raid5 -> bcache0 (NVMe cache
attached, writethrough) -> LVM -> ext4/btrfs root.
Since booting 7.4.0-rc2-md75+, md126 and md127 are [UUU],
/sys/block/bcache0/bcache/io_errors is 0, and dmesg has no
bch_count_backing_io_errors or md/bcache I/O errors.
Caveat: the local workaround (udev rule zeroing discard_max_bytes on
md*/bcache*, plus nodiscard mounts) is still in the initramfs, so the
HDD-backed array has not received discards on this boot. The loop
reproducer is what exercises the changed code path. I can do a
no-workaround boot and a scratch-LV discard test if you want that
before this goes to stable.
Note: 7.2.y is EOL (7.2.15, 2026-11-01), so the "Cc: stable # 7.2" is
stale; v7.3.5 still has the old code, so the fix is needed in 7.3.y
once this reaches mainline.
Tested-by: Konstantin Nikiforov <helllamer@gmail.com>
#regzbot fix: md/raid5: complete unsupported discards successfully
Thanks,
Konstantin
DeepSeek Harness 0.2.2-rc.5; model: deepseek-flash
next prev parent reply other threads:[~2026-11-21 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAO96y0V6oncv54ihXnHfJMYiG_QAQ-NM8BOdqPDXKL8r8-kR9Q@mail.gmail.com>
2026-10-26 6:21 ` Konstantin Nikiforov
2026-11-06 3:26 ` yu kuai
2026-11-21 21:21 ` Konstantin Nikiforov [this message]
2026-11-21 21:55 ` Konstantin Nikiforov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179529607529.5.3302391929789139470@gmail.com \
--to=helllamer@gmail.com \
--cc=colyli@fygo.io \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=magiclinan@didiglobal.com \
--cc=regressions@lists.linux.dev \
--cc=song@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xiao@kernel.org \
--cc=yukuai@fygo.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®