mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: David Miller <davem@davemloft.net>
Cc: kaber@trash.net, poemann@gmail.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: kernel BUG at net/core/skbuff.c in linux-2.6.21-rc6
Date: Sun, 15 Apr 2007 02:49:28 +1000	[thread overview]
Message-ID: <17953.1560.855914.274514@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20070413.161635.26523891.davem@davemloft.net>

David Miller writes:

> > It seems we fail to reserve enough headroom for the case
> > buf[0] == PPP_ALLSTATIONS and buf[1] != PPP_UI.
> > 
> > Can you try this patch please?
> 
> Any confirmation of this fix yet?

Indeed, ppp_async doesn't handle that case correctly.

RFC 1662 says:

      The Control field is a single octet, which contains the binary
      sequence 00000011 (hexadecimal 0x03), the Unnumbered Information
      (UI) command with the Poll/Final (P/F) bit set to zero.

      The use of other Control field values may be defined at a later
      time, or by prior agreement.  Frames with unrecognized Control
      field values SHOULD be silently discarded.

In what situation were we getting the frames that cause the problem?

I didn't see the patch (the message that this is a reply to is the
first one that I have seen in this thread), so I can't comment on it.

Paul.

  parent reply	other threads:[~2007-04-14 16:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-07 18:11 Bartek
2007-04-08  6:47 ` David Miller
2007-04-08 20:15   ` Bartek
2007-04-10  9:19     ` Bartek
2007-04-10 11:25       ` Jesper Juhl
2007-04-12  5:18         ` Bartek
2007-04-12  5:43           ` Patrick McHardy
2007-04-13 23:16             ` David Miller
2007-04-14  6:00               ` Herbert Xu
2007-04-14 16:49               ` Paul Mackerras [this message]
2007-04-14 17:04                 ` David Miller
2007-04-14 17:10                   ` Patrick McHardy
2007-04-15  0:50                   ` Paul Mackerras
2007-04-15  1:05                     ` Paul Mackerras
2007-04-19 20:07                       ` David Miller
2007-04-18 12:42                     ` Jarek Poplawski
2007-04-18 21:35                     ` Herbert Xu
2007-04-19  8:49                       ` Bartek
2007-04-19 11:41                       ` Herbert Xu
2007-04-15 10:45               ` Bartek
2007-04-16  4:06                 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17953.1560.855914.274514@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=poemann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®