From: netdev-bot+sashiko@kernel.org
To: david@kernel.org
Cc: davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, akpm@linux-foundation.org,
kas@kernel.org, songliubraving@fb.com, hannes@cmpxchg.org,
riel@surriel.com, willy@infradead.org, ncardwell@google.com,
kuniyu@google.com, pfalcato@suse.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
stable@vger.kernel.org
Subject: Re: [PATCH net 3/4] net: skbuff: limit folio refcount when splicing pages into skbs
Date: Sun, 22 Nov 2026 09:19:38 +0000 [thread overview]
Message-ID: <179533917877.3135.7884614269284288545@kernel.org> (raw)
In-Reply-To: <20261118-skb_refcount_overflow-v1-3-5551b4954c3f@kernel.org>
Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.
Critical: 0 · High: 1 · Medium: 1 · Low: 0
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [High] The fix leaves the kTLS MSG_SPLICE_PAGES paths unchecked.
- [Medium] The new -EFAULT from skb_append_pagefrags() can turn a
refcount near the limit into a persistent loop of NFS connection…
--
net: skbuff: limit folio refcount when splicing pages into skbs
The patch changes skb_append_pagefrags() to take its page reference with
try_get_page() instead of get_page(). If the folio refcount limit has been
reached it returns -EFAULT, so in-kernel MSG_SPLICE_PAGES users such as
sunrpc can no longer push pagecache folios past the limit.
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index bed1c8c4c6b99..c937d74eed6ac 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -4714,8 +4714,13 @@ int skb_append_pagefrags(struct sk_buff *skb, struct page *page,
> if (skb_can_coalesce(skb, i, page, offset)) {
> skb_frag_size_add(&skb_shinfo(skb)->frags[i - 1], size);
> } else if (i < max_frags) {
> + /*
> + * Don't use -EMSGSIZE, as callers would just retry with a new
> + * skb.
> + */
> + if (!try_get_page(page))
> + return -EFAULT;
[Severity: High]
Does this cover all of the in-kernel MSG_SPLICE_PAGES users that the commit
message is aimed at? Both kTLS sendmsg paths handle MSG_SPLICE_PAGES without
ever calling skb_append_pagefrags(). They still take an unchecked reference
on every spliced page.
For software kTLS the path is
tls_sw_sendmsg_locked()->tls_sw_sendmsg_splice()->sk_msg_page_add():
include/linux/skmsg.h:sk_msg_page_add() {
...
get_page(page);
sge = sk_msg_elem(msg, msg->sg.end);
sg_set_page(sge, page, len, offset);
...
}
The only check in tls_sw_sendmsg_splice() is this one, and it does not look
at the refcount limit:
if (WARN_ON_ONCE(!sendpage_ok(page))) {
For device offload kTLS the path is tls_push_data()->tls_append_frag():
net/tls/tls_device.c:tls_append_frag() {
...
++record->num_frags;
get_page(pfrag->page);
...
}
These references stay in offload_ctx->records_list until
tls_tcp_clean_acked() runs, so they last until the peer ACKs.
The sunrpc example from the commit message appears to take this route.
svc_tcp_sendmsg() sets MSG_SPLICE_PAGES and calls sock_sendmsg(). On
XPT_TLS_SESSION transports, set up by
svc_tcp_handshake()->tls_server_hello_x509(), that socket is a kTLS socket.
So nfsd pagecache pages would reach sk_msg_page_add() or tls_append_frag()
and never skb_append_pagefrags().
No later patch in the series touches net/tls/ or include/linux/skmsg.h,
including "net: skbuff: limit folio refcount when splicing from sockets".
Should the spliced-page references in sk_msg_page_add() and
tls_append_frag() also go through try_get_page()?
[Severity: Medium]
Can this new -EFAULT cause nfsd connections to be torn down over and over?
nfsd threads are kthreads, and folio_ref_count_over_limit_slowpath()
refuses them at FOLIO_REF_COUNT_LIMIT, with no admin headroom:
/* Background threads must not consume admin reserves. */
if (current->flags & PF_KTHREAD)
goto over_limit;
On the read side the limit is checked only once, when
filemap_splice_read()->splice_folio_into_pipe() calls folio_get_checked().
After that, nfsd_splice_actor()->svc_rqst_replace_page() takes an unchecked
get_page() for rq_respages, and the pipe reference is dropped. With this
patch, sending the reply needs a second, checked reference per page here.
Let k be roughly the number of pages from the folio in the reply. Suppose a
local user holds the folio refcount between FOLIO_REF_COUNT_LIMIT - k and
FOLIO_REF_COUNT_LIMIT. The read stage succeeds and fills the refcount up to
the limit. The send then fails:
skb_append_pagefrags()
try_get_page() fails, returns -EFAULT
skb_splice_from_iter()
iov_iter_revert(), returns -EFAULT or a short count
tcp_sendmsg_locked()
returns a short count
svc_tcp_sendto()
if (sent < 0 || sent != (xdr->len + sizeof(marker)))
goto out_close;
...
svc_xprt_deferred_close(xprt);
This closes the connection together with every other RPC in flight on it.
The client reconnects and retransmits the same READ. Nothing clears the
condition, so the cycle repeats for as long as the refcount stays in that
window.
Mappings are checked against the same limit. An unprivileged user can
therefore put the count in that window by mapping until refused and then
unmapping a few pages.
Before this patch the send succeeded. At or above FOLIO_REF_COUNT_LIMIT, the
pipe-stage check makes nfsd return an NFS read error rather than close the
connection.
The commit message says:
The only caller, skb_splice_from_iter(), handles that.
For sunrpc, though, the error ends in connection teardown, and nothing falls
back to copying the data into frags. Would a copy fallback be better here,
or is the teardown intended?
> skb_zcopy_downgrade_managed(skb);
> - get_page(page);
> skb_fill_page_desc_noacc(skb, i, page, offset, size);
> } else {
> return -EMSGSIZE;
[ ... ]
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261118-skb_refcount_overflow-v1-0-5551b4954c3f%40kernel.org
next prev parent reply other threads:[~2026-11-22 9:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 8:32 [PATCH net 0/4] net: skbuff: limit pagecache folio refcount David Hildenbrand (Arm)
2026-11-18 8:32 ` [PATCH net 1/4] net: skbuff: limit folio refcount when copying skb frag references David Hildenbrand (Arm)
2026-11-19 13:53 ` David Hildenbrand (Arm)
2026-11-20 16:21 ` Stanislav Fomichev
2026-11-20 21:01 ` David Hildenbrand (Arm)
2026-11-22 9:19 ` netdev-bot+sashiko
2026-11-18 8:32 ` [PATCH net 2/4] net: skbuff: limit folio refcount when rearranging skb frags David Hildenbrand (Arm)
2026-11-22 9:19 ` netdev-bot+sashiko
2026-11-18 8:32 ` [PATCH net 3/4] net: skbuff: limit folio refcount when splicing pages into skbs David Hildenbrand (Arm)
2026-11-22 9:19 ` netdev-bot+sashiko [this message]
2026-11-18 8:32 ` [PATCH net 4/4] net: skbuff: limit folio refcount when splicing from sockets David Hildenbrand (Arm)
2026-11-22 9:19 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179533917877.3135.7884614269284288545@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=david@kernel.org \
--cc=edumazet@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=horms@kernel.org \
--cc=kas@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pfalcato@suse.de \
--cc=riel@surriel.com \
--cc=songliubraving@fb.com \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®