mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: netdev-bot+sashiko@kernel.org
To: kyuwoncho18@gmail.com
Cc: netdev@vger.kernel.org, jv@jvosburgh.net, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
	pabeni@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] bonding: reject a non-Ethernet 802.3ad slave even when the type matches
Date: Sun, 22 Nov 2026 13:02:33 +0000	[thread overview]
Message-ID: <179535255333.3135.10581087211469618015@kernel.org> (raw)
In-Reply-To: <179500849159.1877154.14715369660816392826@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider.

Critical: 0 · High: 1 · Medium: 0 · Low: 0

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [High] The fix is incomplete.

--

bonding: reject a non-Ethernet 802.3ad slave even when the type matches

This moves the 802.3ad Ethernet-only check in bond_enslave() so that it
runs for every first slave, not only when enslaving changes the bond's
type. The goal is to stop the global out-of-bounds read of
lacpdu_mcast_addr in bond_open() when a slave with a 16-byte addr_len ends
up in an 802.3ad bond.

> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 042d7c75548fa..f2e645f869b13 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -1959,13 +1959,13 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
>  	 * ether type (eg ARPHRD_ETHER and ARPHRD_INFINIBAND) share the same bond
>  	 */
>  	if (!bond_has_slaves(bond)) {
> +		if (slave_dev->type != ARPHRD_ETHER &&
> +		    BOND_MODE(bond) == BOND_MODE_8023AD) {
> +			SLAVE_NL_ERR(bond_dev, slave_dev, extack,
> +				     "8023AD mode requires Ethernet devices");
> +			return -EINVAL;
> +		}

[Severity: High]
Is this check enough to keep a non-Ethernet slave out of an 802.3ad bond?
It only looks at the slave's type when the slave is enslaved. A slave that
is itself a bond can still change type after that.

Consider this sequence:

  ip link add bondA type bond mode 802.3ad
  ip link add bondB type bond mode active-backup
  ip link set bondB master bondA     <- bondB is ARPHRD_ETHER, passes
  ip link set ip6tnl0 master bondB   <- bondB has no slaves yet

The second enslave goes through bond_enslave(bondB), which sends
NETDEV_PRE_TYPE_CHANGE for bondB:

	res = call_netdevice_notifiers(NETDEV_PRE_TYPE_CHANGE,
				       bond_dev);

bond_netdev_event() passes the event to bond_master_netdev_event() and
bond_slave_netdev_event(). Neither one has a NETDEV_PRE_TYPE_CHANGE case,
so both reach:

	default:
		break;
	}

	return NOTIFY_DONE;

vlan_device_event() only refuses this when VLAN upper devices exist. So
bond_setup_by_slave() goes ahead and sets bondB->type to ARPHRD_TUNNEL6
and bondB->addr_len to 16, while bondB is still a slave of bondA.

When bondA is brought up, bond_open() does:

	bond_for_each_slave(bond, slave, iter)
		dev_mc_add(slave->dev, lacpdu_mcast_addr);

but lacpdu_mcast_addr in bond_3ad.c is only 8 bytes:

	const u8 lacpdu_mcast_addr[ETH_ALEN + 2] __long_aligned = {

Does this lead to the same global out-of-bounds read as the KASAN report
in the commit message?

If bondA is already up, a later release of bondB has the same problem.
bond_hw_addr_flush() calls dev_mc_del(slave_dev, lacpdu_mcast_addr),
which compares 16 bytes against the same 8-byte array.

Changing the type of an enslaved bond seems to be supported behaviour.
bond_test_enslave_type_change() in
tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
enslaves one bond to another, then enslaves a non-Ethernet device to the
inner bond. In its successful variant, the test expects the type change
to stick.

For comparison, team_device_event() in drivers/net/team/team_core.c
refuses this event for its ports:

	case NETDEV_PRE_TYPE_CHANGE:
		/* Forbid to change type of underlaying device */
		return NOTIFY_BAD;

Should bond_slave_netdev_event() also veto NETDEV_PRE_TYPE_CHANGE? That
could apply only when the bond is in 802.3ad mode and the new type is not
Ethernet, or, as team does, whenever the slave's type would no longer
match bond_dev->type.

[ ... ]

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/179500849159.1877154.14715369660816392826%40gmail.com

      parent reply	other threads:[~2026-11-22 13:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 13:38 Kyuwon Cho
2026-11-18 19:37 ` Jay Vosburgh
2026-11-22 13:02 ` netdev-bot+sashiko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179535255333.3135.10581087211469618015@kernel.org \
    --to=netdev-bot+sashiko@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=jv@jvosburgh.net \
    --cc=kuba@kernel.org \
    --cc=kyuwoncho18@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®