From: Paul Mackerras <paulus@samba.org>
To: Anton Blanchard <anton@samba.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: Incorrect order of last two arguments of ptrace for requests PPC_PTRACE_GETREGS, SETREGS, GETFPREGS, SETFPREGS
Date: Mon, 30 Apr 2007 15:42:57 +1000 [thread overview]
Message-ID: <17973.33249.852991.342860@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20061204215825.GB22514@krispykreme>
Anton Blanchard writes:
> I looked at this a while ago and my decision at the time was to keep the
> old implementation around for a while and create two new ones that match
> the x86 numbering:
>
> #define PTRACE_GETREGS 12
> #define PTRACE_SETREGS 13
> #define PTRACE_GETFPREGS 14
> #define PTRACE_SETFPREGS 15
>
> I hate gratuitous differences, each ptrace app ends up with a sea of
> ifdefs.
>
> Also I think it would be worth changing getregs/setregs to grab the
> entire pt_regs structure. Otherwise most ops (gdb, strace etc) will just
> have to make multiple ptrace calls to get the nia etc.
Did you do a patch to do that?
Paul.
prev parent reply other threads:[~2007-04-30 5:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-25 10:53 supriya kannery
2006-10-25 20:43 ` David Miller
2006-10-27 7:20 ` supriya kannery
2006-10-27 7:10 ` David Miller
2006-10-31 12:18 ` supriya kannery
2006-11-22 18:36 ` David Woodhouse
2006-11-22 21:35 ` Benjamin Herrenschmidt
2006-12-04 21:58 ` Anton Blanchard
2007-04-30 5:42 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17973.33249.852991.342860@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=anton@samba.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®