From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA7E215B543 for ; Fri, 7 Jun 2024 09:05:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717751161; cv=none; b=qDbPtEStKppXyDvxXOwEYvZcjJTllzoC8/+zLR00PkYHRy868XjdYFSVP+zDZcvemM3raYDIfPOXPDgzSKle63tqxarhttwm39w6XnUzTClq1iIDom3i2CMjZgkgU7Ttwjk9c3htwzddPozI4sFThC+6dhsjurj69cN905CSrBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717751161; c=relaxed/simple; bh=TTK1GYtFtsVo48+qOHmmrbUdupYD8dUd916fpZW2CU8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YyTuy7qRVLqnVqaXyoU5031/ME9JYnUSiw9U/qfqfzS+Naq8F75SoFQlMP9XsjcggU+FTEqp86sAzx5FxqhE5NJr4k+Br56veFnZcgELXyDKxVwhAwtiXxUG0dib5gL76OGGiOzEXnY3ZKUsIYESHTWOpAsL7WHi3IS4gv8gzao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Icz7oD97; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Icz7oD97" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717751158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dGYDizRf/2C0sa0+xp/HL0cUgtFnHVaSqzQ3tVH7lxg=; b=Icz7oD97R0bNENKMbn/YzpvNUeyn+0vuBmEoXZrJmRXRlw/MrTUh8xGblMcPQDvLKR/fUM uv5F4zbq6122VYa/TCsGLFFHMK/vKsRjKnDhfa+QqrvyAquoMTwZOPzoF2Xl2BOp1KUdxU 6DnotyZCASqQslIbcJJJmlxglWBzU1c= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-150-nifmnnaxNcujG65iewTmMg-1; Fri, 07 Jun 2024 05:05:56 -0400 X-MC-Unique: nifmnnaxNcujG65iewTmMg-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a6e37310ebaso11787466b.1 for ; Fri, 07 Jun 2024 02:05:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717751153; x=1718355953; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dGYDizRf/2C0sa0+xp/HL0cUgtFnHVaSqzQ3tVH7lxg=; b=r9NuF9lmBMlQkQirAfyfJUydZuzLBF19HvOvTZZEDcdorMfjG+22nWu7dwZ3pWt0LO VYsNlRIt58te3E/F0p/2bFFgnZ/GN3WTVYH4fOsB4XcjzAXAa+v5sIupLd814DtU6Oha VXTWUzqcvHjjLargPooX5O4IXbezYxHWIOejNNitZefzkYB2NuBEXLu/L0kmHIUjKIao Y+Z/QSLSHFnC/D6iXRqCJ21E6mt0gU+uddRvp1oHl41WF8tJT/TaPXUTPYkSRrMHW0AI gSr85zzluKaMT/5i8EfEYJPcKMll+mFEvgfxBN+GOyt7f2tZAxodyo98f7uelwJH9+1q /k6Q== X-Forwarded-Encrypted: i=1; AJvYcCVw1qKdK3/qJ+pGJWAFdAuU4IoIuurOEG1WdcAttwaGfvMRk8M/Qii6bh808zja8iQowKF55YsZy6N8LgWBXKt8yGblutkq+TCWA8tA X-Gm-Message-State: AOJu0YxgFZNKSAnttSih3qnGIecDFAz6u8yZn8moCYwt0z9WbJRdGYJw 4tweeKeuomKD07dOmQy9KX779kCjKNfkvTq2XL2UKH8wrBHjCgBEWymHZ84iRLT8JcXVyNC3qTB RM4jBmFRWEUUo4LbVMC4v2HGzNlJjO0qerwnZ9uLF6Mfo6N86mXH2j1osjXybyIhHvCWQYA== X-Received: by 2002:a17:906:e1b:b0:a6d:e0dd:f7 with SMTP id a640c23a62f3a-a6de0dd0399mr70566866b.52.1717751153242; Fri, 07 Jun 2024 02:05:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDIn9rSgHARHfYV/cxRs9YgwJvZSg1qSEkxYVv4VWP1Sp5NzmUd4BO6G+TOihp5MZeIbXWww== X-Received: by 2002:a17:906:e1b:b0:a6d:e0dd:f7 with SMTP id a640c23a62f3a-a6de0dd0399mr70564966b.52.1717751152868; Fri, 07 Jun 2024 02:05:52 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6c80581746sm217030166b.21.2024.06.07.02.05.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jun 2024 02:05:52 -0700 (PDT) Message-ID: <179d5111-5cc8-4a17-b735-84f02e0144f5@redhat.com> Date: Fri, 7 Jun 2024 11:05:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/3] ACPI: PMIC: a small refactoring To: Andy Shevchenko , Mika Westerberg , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" , Len Brown , Andy Shevchenko References: <20240606205712.3187675-1-andriy.shevchenko@linux.intel.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20240606205712.3187675-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 6/6/24 10:54 PM, Andy Shevchenko wrote: > Use sizeof(), dev_err()/dev_warn(), and regmap bulk read > where it makes sense. > > In v4: > - dropped controversial changes (Hans) Thanks, the whole series looks good to me: Reviewed-by: Hans de Goede for the series. Regards, Hans > > Andy Shevchenko (3): > ACPI: PMIC: Use sizeof() instead of hard coded value > ACPI: PMIC: Convert pr_*() to dev_*() printing macros > ACPI: PMIC: Replace open coded be16_to_cpu() > > drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 13 ++++++++----- > drivers/acpi/pmic/intel_pmic_chtwc.c | 5 +++-- > drivers/acpi/pmic/intel_pmic_xpower.c | 7 ++++--- > 3 files changed, 15 insertions(+), 10 deletions(-) >