From: David Ahern <dsahern@gmail.com>
To: Leon Romanovsky <leon@kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: Chengchang Tang <tangchengchang@huawei.com>,
Junxian Huang <huangjunxian6@hisilicon.com>,
jgg@ziepe.ca, netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linuxarm@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH iproute2-rc 1/2] rdma: Fix core dump when pretty is used
Date: Tue, 2 Jan 2024 12:29:58 -0700 [thread overview]
Message-ID: <17a2c694-2c48-46dc-b028-68793a31a984@gmail.com> (raw)
In-Reply-To: <20240102191701.GC5160@unreal>
On 1/2/24 12:17 PM, Leon Romanovsky wrote:
>>
>> Part of the problem is the meaning of pretty mode is different in rdma
>> than all of the other commands. The meaning of the flags should be the
>> same across ip, devlink, tc, and rdma; therefore pretty should mean
>> nothing unless json is enabled.
>
> I was very inspired by devlink when wrote rdmatool. It is supposed to
> behave the same. :)
You need better inspirations :-)
It was a mistake to merge devlink source code into iproute2 without a
commitment to bring it inline with other iproute2 commands.
next prev parent reply other threads:[~2024-01-02 19:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 6:52 [PATCH iproute2-rc 0/2] Bugfixes for rdmatool Junxian Huang
2023-12-29 6:52 ` [PATCH iproute2-rc 1/2] rdma: Fix core dump when pretty is used Junxian Huang
2023-12-29 17:21 ` Stephen Hemminger
2024-01-02 7:44 ` Chengchang Tang
2024-01-02 8:32 ` Leon Romanovsky
2024-01-02 12:06 ` Chengchang Tang
2024-01-02 12:21 ` Leon Romanovsky
2024-01-02 16:27 ` Stephen Hemminger
2024-01-02 19:17 ` Leon Romanovsky
2024-01-02 19:29 ` David Ahern [this message]
2023-12-29 6:52 ` [PATCH iproute2-rc 2/2] rdma: Fix the error of accessing string variable outside the lifecycle Junxian Huang
2024-01-08 1:28 ` Junxian Huang
2024-01-08 11:09 ` Petr Machata
2024-01-08 16:10 ` Andrea Claudi
2024-01-08 17:25 ` Stephen Hemminger
2024-01-09 1:36 ` Junxian Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17a2c694-2c48-46dc-b028-68793a31a984@gmail.com \
--to=dsahern@gmail.com \
--cc=huangjunxian6@hisilicon.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=tangchengchang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®