From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Hans de Goede" <hdegoede@redhat.com>,
"Gergo Koteles" <soyer@irl.hu>,
"Ike Panhc" <ike.pan@canonical.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: leds: add LED_FUNCTION_FNLOCK
Date: Wed, 3 Apr 2024 10:46:04 +0200 [thread overview]
Message-ID: <17a700a7-44f0-4e46-9a0c-4c2da44c9e27@linaro.org> (raw)
In-Reply-To: <4956933c-49c4-49ab-a91a-7e0efcc211d5@redhat.com>
On 03/04/2024 10:39, Hans de Goede wrote:
>>>
>>> must have a dts user before being approved too ? Since
>>> that file is included from include/dt-bindings/input/input.h ?
>>
>> Wait, that's UAPI :) and we just share the constants. That's kind of
>> special case, but I get what you mean.
>>
>>>
>>> TL;DR: not only is this patch fine, this is actually
>>> the correct place to add such a define according to
>>> the docs in Documentation/leds/leds-class.rst :
>>>
>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Thanks. Is it ok for me to merge this through the pdx86
> tree (once I've reviewed the other 2 patches) ?
You need to sync (ack) with LED folks, because by default this should go
via LED subsystem.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-03 8:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 13:20 [PATCH 0/3] add FnLock LED class device to ideapad laptops Gergo Koteles
2024-04-02 13:21 ` [PATCH 1/3] dt-bindings: leds: add LED_FUNCTION_FNLOCK Gergo Koteles
2024-04-02 13:55 ` Krzysztof Kozlowski
2024-04-02 14:36 ` Gergo Koteles
2024-04-02 18:08 ` Krzysztof Kozlowski
2024-04-02 18:50 ` Gergo Koteles
2024-04-03 8:33 ` Hans de Goede
2024-04-03 8:31 ` Hans de Goede
2024-04-03 8:36 ` Krzysztof Kozlowski
2024-04-03 8:39 ` Hans de Goede
2024-04-03 8:46 ` Krzysztof Kozlowski [this message]
2024-04-03 8:51 ` Hans de Goede
2024-04-11 7:13 ` Lee Jones
2024-04-02 13:21 ` [PATCH 2/3] platform/x86: ideapad-laptop: add fn_lock_get/set functions Gergo Koteles
2024-04-08 15:49 ` Hans de Goede
2024-04-08 15:49 ` Hans de Goede
2024-04-02 13:21 ` [PATCH 3/3] platform/x86: ideapad-laptop: add FnLock LED class device Gergo Koteles
2024-04-08 15:50 ` Hans de Goede
2024-04-15 13:35 ` [PATCH 0/3] add FnLock LED class device to ideapad laptops Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17a700a7-44f0-4e46-9a0c-4c2da44c9e27@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=ike.pan@canonical.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
--cc=soyer@irl.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®