From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A58DFC47083 for ; Wed, 2 Jun 2021 09:53:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 933F4611CC for ; Wed, 2 Jun 2021 09:53:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232448AbhFBJzB (ORCPT ); Wed, 2 Jun 2021 05:55:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229904AbhFBJy7 (ORCPT ); Wed, 2 Jun 2021 05:54:59 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 869B9C061574 for ; Wed, 2 Jun 2021 02:53:15 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id dg27so2135554edb.12 for ; Wed, 02 Jun 2021 02:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=R+UA/QItNObeMQQscZ4ivUcRFeqMf57DAC45WgOVgmY=; b=b0rR34OP4uOaXepns0xG74caSrzPD9qMYG1pa3l8duCvyQLD3BLgAOFJ1sqAQCNdja 2+CIRHJzfULinBmSF+djnPdbv11fJK5nSTnFYSe/N4o9xal5rbRnNFqUbpi0p+jxoWs4 ZXzFL2ndKx/uLucPEjaue4bPpGhuugMG6TyrOXyPCxtJYX6vhDPq/3MPYbCSPQyRwsSl 7HCBsFWbkg88xUJ5ns0Tf0RWDUYOgMAkaLMsRew4e9/2+/NvP4v/IasGKo5dQRvlmI8w vXWp+erbEry7ULfFkfhCg8/igaOcKxsqLQ27u8Y7FD9szVtpdaj1hQ09nHIWc57ToeXs 1j5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=R+UA/QItNObeMQQscZ4ivUcRFeqMf57DAC45WgOVgmY=; b=A6EETG15D6bc0n/mQBC5QMsAHP04hPNtd6WFGnT6ZWLRYc3hTXWcFvCsLjYug21/QL /amZMuBhW6NKZsgfvl77ZbifxR61xjYUX0p60+0Lv5WSiTltj3z/AJvWtFz70UOHkkXD VRBFYMXej3AU22vI3paj1L1GUkv0vfhtCdFgJ++xYcKY1pIhjqszYAeIUvO9OIvR8p1I gtj1vwQgjsupNaDS2pke9U+PFarfglTSqmrUpVYtjnDfeVNAXec21Nml1w+1E+h8CM0X K2x8Z4H/txjzNnBmXa8O4CoUzTqmu4q+n7csQ8TA0goVKyGibQa2kk2TXhHvX6rEvJZQ kuBA== X-Gm-Message-State: AOAM531nj4mgwT4/oP6ZuGuiWvkZ+CFjGs5RdPbLGfL0SxSIsyFdG2Wl uzluv6eNvugNvHAfGv1KX8Xl17sgSXhQDB9V X-Google-Smtp-Source: ABdhPJzjmZwyiiQ+KS0RDNdqHKOItIOjEgtddjOKgTLB4VV8zjvl9jry6WRY4MJ8NH7jnQJCjNHb9Q== X-Received: by 2002:aa7:d755:: with SMTP id a21mr18386424eds.146.1622627594218; Wed, 02 Jun 2021 02:53:14 -0700 (PDT) Received: from [192.168.1.28] (hst-221-100.medicom.bg. [84.238.221.100]) by smtp.googlemail.com with ESMTPSA id d11sm935808ede.74.2021.06.02.02.53.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 02:53:13 -0700 (PDT) Subject: Re: [PATCH] venus: helper: do not set constrained format for UBWC To: Bryan O'Donoghue , Mansur Alisha Shaik , linux-media@vger.kernel.org, stanimir.varbanov@linaro.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org, dikshita@codeaurora.org References: <1622195288-18541-1-git-send-email-mansur@codeaurora.org> From: Stanimir Varbanov Message-ID: <17aaec56-bfad-63a6-b1c4-7562dedb3137@linaro.org> Date: Wed, 2 Jun 2021 12:53:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mansur, could you answer to Bryan's comments? On 5/28/21 8:23 PM, Bryan O'Donoghue wrote: > On 28/05/2021 10:48, Mansur Alisha Shaik wrote: >> Do not set constrained format explicitly for UBWC >> >> Signed-off-by: Mansur Alisha Shaik > > Could you give a little bit more detail on why, what the side effects are ? > > Should this be a Fixes: ? > >> --- >>   drivers/media/platform/qcom/venus/helpers.c | 4 ++++ >>   1 file changed, 4 insertions(+) >> >> diff --git a/drivers/media/platform/qcom/venus/helpers.c >> b/drivers/media/platform/qcom/venus/helpers.c >> index b813d6dba..e4b8a2a 100644 >> --- a/drivers/media/platform/qcom/venus/helpers.c >> +++ b/drivers/media/platform/qcom/venus/helpers.c >> @@ -1138,8 +1138,12 @@ int venus_helper_set_format_constraints(struct >> venus_inst *inst) >>       if (!IS_V6(inst->core)) >>           return 0; >>   +    if (inst->opb_fmt == HFI_COLOR_FORMAT_NV12_UBWC) >> +        return 0; >> + >>       pconstraint.buffer_type = HFI_BUFFER_OUTPUT2; >>       pconstraint.num_planes = 2; >> + > > Additional newline should be removed. > >>       pconstraint.plane_format[0].stride_multiples = 128; >>       pconstraint.plane_format[0].max_stride = 8192; >>       pconstraint.plane_format[0].min_plane_buffer_height_multiple = 32; >> > > --- > bod -- regards, Stan