From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754515AbeALJh0 (ORCPT + 1 other); Fri, 12 Jan 2018 04:37:26 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3780 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754403AbeALJhY (ORCPT ); Fri, 12 Jan 2018 04:37:24 -0500 Subject: Re: [PATCH v3 19/27] drm: replace devm_ioremap_nocache with devm_ioremap To: Benjamin Gaignard References: <1514026866-33463-1-git-send-email-xieyisheng1@huawei.com> CC: Linux Kernel Mailing List , "Greg Kroah-Hartman" , David Airlie , , , Daniel Vetter From: Yisheng Xie Message-ID: <17b117da-ef14-b531-2a8f-192a86ed6cd7@huawei.com> Date: Fri, 12 Jan 2018 17:37:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.29.40] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Benjamin , On 2018/1/9 17:21, Benjamin Gaignard wrote: > 2017-12-23 12:01 GMT+01:00 Yisheng Xie : >> > Default ioremap is ioremap_nocache, so devm_ioremap has the same >> > function with devm_ioremap_nocache, which can just be killed to >> > save the size of devres.o > That looks true for arm and arm64 architectures but not, for exemple, for ia64: > https://elixir.free-electrons.com/linux/v4.15-rc7/source/arch/ia64/mm/ioremap.c > > If there is still one architecture doing a difference between cached > and uncached > ioremap we can't remove devm_ioremap_nocache... Right. > > This patch only concern arm chipsets so we can apply it but that will > not help you to > reduce devres size. Yes, And sorry for disturb. Please ignore about this patch. Thanks Yisheng >