From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D79C32FA3F for ; Thu, 22 Jan 2026 14:21:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769091721; cv=none; b=uoyB6iCCxkPumxSRexolWANDAdF1TBFRIfjiZUM3eZ6F++GvYJ2C3skdhj3HcHsXE/4FerSJ/E1EEDb1RK7gzvvnC0p3a2cGlK2XE72WCSkQTikMgTH3Jf1xVyh4beO62JDHrtk4rv/9xpJz/I1HBnQzPuQNXpRqXg6zRerHLbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769091721; c=relaxed/simple; bh=13gArPXwcIJnMths0YUE080ILGg8ycECuWhBe9JykhM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cg9oTgXVjmCpiidFcPd+c63EGBTjIEhR2xn0RZM5UxOkv/dB8AWF8sR0QKT6U5XA1abrVIO2YMAVZSTj7kkYolMBizM5KyCOLNibRjad0uobcJ3kRexL12npbGwPWriTEhw1FiSF2klbamzWdxwVGxev7rvh9nCihYBaZa/xfGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Xp0wdsbs; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Xp0wdsbs" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-47edffe5540so11498145e9.0 for ; Thu, 22 Jan 2026 06:21:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769091718; x=1769696518; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=KWBtxKj07s4HLwGJTh9AK3keI4THEAKode/ZcAbQeyE=; b=Xp0wdsbsj8iL9wRGQSsm1XGmYPofV3eBD+3RtK15fxoc9c1F/2QX+FJObAUgKpbCQ8 J55h5vJCr+nd8To1xWDPIJxtvonbNc5DsN61bmvq6DlYmqgaw/m7pBb4GTSQwKw7Colo s8UhOlFxIX7aC/g/K4pD3oCyKAkd1kjHfQRQiTjjZzRLC5H6GTc70ttzk+pwgsh7rmns onM84QOmwN4I4j9i57sxuH4bCsV+HDYVfufE/msEQBiau0dN3vW1EmV/unfSE8x8aOYi 4BfEA65vy3AlL1RtRlwXe8Cc+E7ZIDjt3LPtFeQLsV/WLYMOQ+M+j7VaB6HiV+lfFUV9 0T4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769091718; x=1769696518; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KWBtxKj07s4HLwGJTh9AK3keI4THEAKode/ZcAbQeyE=; b=GhhzRKxSKEXNldCPSvVDywhvRSDOTTb3cwvVUvhHQBpjyrB3SxGX1MbUJI0IW6vEAA wkijTTNg1ctnISytwNLy32yvhe5cg8An25pzXYUstb02tPUFIPfumebZqmziNfCDNCVg W8Gy2iywPqDXBilQPeKFM42ZLV0BP8qxrzio39MHFTrvDy+ZxfmiPVIrnZLBpI4caqw1 T+B4+bJzggKNzuEQu6cYmSkJF3FTuh0gtmr4AhvmOQsTARJNxEVBREBytElmEeMgODxm Yvu2CBpfecknNWm3bcTRpJ8yG5TKJFWqnMuM49ejhBfHhV22zoGj+j+w3Gw4iKILXM7L kaAg== X-Forwarded-Encrypted: i=1; AJvYcCVwHDOOAyUBKyrWuu0ClUXmLgQwg+3onwnrt76RkVGMntQNSetaJqA4o+CHDe6GcgL5/u2HHPOJSrE5H6w=@vger.kernel.org X-Gm-Message-State: AOJu0YxUXL5rwUCsvtgTc7p3uHZ5dWUsJGlBGfkwSs7qjcOYxOB/N6I6 kBUPaGNpb5o5Es/i3OAZJhGYvsctSHlKXlPNR0uipQgVRR6rSiX0pPS/ftO4pyNPZA== X-Gm-Gg: AZuq6aJOfgN3CLTp3am8sdR/6znW0tTqkzc61UEQB8q46okY0TjlWNo7wJ7WOKeXqM6 XBRbSMmglP2KAHU5R8880fjEuJIjfVPFFHKLw8lghCTSTkjJatPYmW39FmmHyFGKSp55VF62fYE Rh+MHCsPEjJOaD3NkDK8+2+AqDoyC4ilM0f5g89aKJJVISKleJMviSJdFLPBaG65kalJHz36A5x WK6tC+dxEAk0xCGYqr+ZsL5YsK58n/xxQaJQ5OC/mN012u0AyYTjoR8IW4Gk7B/5q+/H4vwSZAc wDd7JMRxpVQ9xaxBpyC8t768dLqIWQqnUJY1G4m2rYw97W7XewKu0iDu8JgHgiTr35v/+/aCyLG CUohbxYxNpsrEwempbTzNPA35/5kQQt03EPepi05pbWYrBOPJtUFh9soKIBMBR1mvPfZEa0Qy8P kmYYd8reQDAgtLKR6i3Yj3BPTPsWnEYzlYgiMXzmJTIVb3QyoWxLSNeUoj7QmtY9qrnruqId1nU KU= X-Received: by 2002:a05:600c:1990:b0:480:3b26:82c3 with SMTP id 5b1f17b1804b1-4803e7e819dmr135375095e9.20.1769091717597; Thu, 22 Jan 2026 06:21:57 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4804704b712sm68649175e9.8.2026.01.22.06.21.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 06:21:56 -0800 (PST) Message-ID: <17b237ae-d3c8-4491-8eb5-6ebb4a25a8fc@suse.com> Date: Thu, 22 Jan 2026 15:21:53 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen/mcelog: simplify MCE_GETCLEAR_FLAGS using xchg() To: Uros Bizjak Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20260122141754.116129-1-ubizjak@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260122141754.116129-1-ubizjak@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22.01.2026 15:17, Uros Bizjak wrote: > The MCE_GETCLEAR_FLAGS ioctl retrieves xen_mcelog.flags while > atomically clearing it. This was previously implemented using a > cmpxchg() loop. > > Replace the cmpxchg() loop with a single xchg(), which provides the > same atomic get-and-clear semantics, avoids retry spinning under > contention, and simplifies the code. > > The code on x86_64 improves from: > > 186: 8b 15 00 00 00 00 mov 0x0(%rip),%edx > 18c: 89 d0 mov %edx,%eax > 18e: f0 0f b1 0d 00 00 00 lock cmpxchg %ecx,0x0(%rip) > 195: 00 > 196: 39 c2 cmp %eax,%edx > 198: 75 ec jne 186 <...> > > to just: > > 186: 87 05 00 00 00 00 xchg %eax,0x0(%rip) > > No functional change intended. > > Signed-off-by: Uros Bizjak Reviewed-by: Jan Beulich