From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 355DF18FDDC for ; Mon, 23 Dec 2024 12:34:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734957276; cv=none; b=ri5O3cltgheDIRV4bLDUZSNoz651Y0fGibZ9Ziyu/kKL32KaoYYe89PUMotIGuT3DwAIFkSc7UMs2R8Dtez4AB0CckI9x+GDy44HS874JnUlVm1l9SCG8/XYV+JM6Nr0cdXItAtvLDAaDdgKRlCoyV8mVpP9/9w3K0t0OnyxpGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734957276; c=relaxed/simple; bh=OYcn5rDBrlqjXiQ6TdxxBzy2cwHXUaQEnLO4x8NEBIc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W6ohAGSEBVnkhS8rQQro485erxjiEoaPhyMF6KcGAoPZCY2nNoDXhJ6xFYiy8PHL3FA6XyutJY7+SUzDHb9DkM7K8LjbnC192wzoYdMxlQ17JYBNCKVnRjVlfNbroqFfjQYS3z+mJaKcDF7EDncRt0oABuUxvdBepHTxPhqi2Fk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=PvLde1Ku; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="PvLde1Ku" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-725dbdf380aso3248828b3a.3 for ; Mon, 23 Dec 2024 04:34:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1734957274; x=1735562074; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=ViyECepWDFW08MegZ0LzLOQSuVexB5jbqH+QsU3+7t8=; b=PvLde1Kud6z5LBop2KO6huee5KIQcd0ANsFiHrZ2gacwFGT0fRNALo9/meSR3AQ0xL awr8WvhMjFAVJiNq89ZKvtM2OcpV9DV4fk362YzKRXh7fZmNGTA8ojAVOAGGR8Iswshu l2Tw2RGyhi1yQK4c1Txbvg9Cgmye5jXJsnoC6blfYDpk6DW9tiiCj9FRjv8dXaPEK6fk e0DkybFadaZ7pcE7sANs34uiGjZc5Tu7b33Qd8Oeie3XwVIWj+70xRYi4zflcmdI7/eN fuTs8DikJDzMhXng7300rqJ7L9L9XCg03GCdPW3BUT+XTDY7xWYBGX601pVnmBhUnXoX lCtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734957274; x=1735562074; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ViyECepWDFW08MegZ0LzLOQSuVexB5jbqH+QsU3+7t8=; b=T6Mm+LnLGIx0+Gt068RKARIwXeqDuNTuLgfeHnliNOeD5BnZ4n6wfMuK7JADFx5vfb ua5QvxtmTvLz7cpKdOtWOTI1JkFeZHiOBL0ln2gV1s3z1ltNDS+8iKGyTiVL2Zr0T7pG QZ3ddxH2KSWdlVCyyFr0NTJKYyrSyAcDOZteUcR9B4JWH2J8cbdamyuIs7j5QS2z8j47 rR5L3LAdP2fPjuwEgJQvUAKLCKCU2i/g4ihFM59injUNcs9U/qSkM9vHdbUuTohVU5QM ILZy587XiiLPUvgyj085tDvief7SE70SEkt3vmES9YKUaPZ4w0ihreB9a2Ssd8YKyVe1 ge1w== X-Forwarded-Encrypted: i=1; AJvYcCWIwijPCrv+uGv4zqio1Pezo2wyAPZYlaj3SaNMWEGO/VYkgvtIC8H8+Ci6/qfc4gUMdia0OwIWOkUJDlQ=@vger.kernel.org X-Gm-Message-State: AOJu0YydR1bsd9BdsIfgxJ9nNyDWyBEUXIZRqET4XgxoxvK48rI7idAE OY7WYARsqsWUyGOynQ80+UPHbtlk0nGTIIMHDRnE/t+q/ZBYfB2iUdh3zzt/Ihc= X-Gm-Gg: ASbGncuwT360DbQky7xpwvZ0I3QhYuzsogsU7kmdbRZ6wmrKdo/JOjgX11Ow66ZFwaX eds6RIcDYJ6oZcFzGuCAZLgUClw8Z+bh7qL2dIZKSRTo3qAgHIRB4POmcdJ49NzBYIDSB5kj05o VqyAL2sv2pUpVl2QeI6JwX0GxvK1uNVeujhggN3MyiTLyTA3nuuY17wAnHwEMmqROM0PEL+UVhZ qHhbPU4+TaG9UscSTqMDZ7aKFBiRzPd+qIB/761Y3WAUrlPOHCSS7vMow29Y3uD8hJ3v3JR7PYJ qxM= X-Google-Smtp-Source: AGHT+IEULLJlacksvgAowQHx5Bxx0eTxBjj1tYwk8fYm1bBzxoDizhV89fXEky3YXCkfBVRi6Gg6Dg== X-Received: by 2002:a05:6a00:428e:b0:727:3ccc:25b0 with SMTP id d2e1a72fcca58-72abde8479bmr16630653b3a.16.1734957274348; Mon, 23 Dec 2024 04:34:34 -0800 (PST) Received: from [10.5.84.6] ([139.177.225.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad830adasm7732983b3a.44.2024.12.23.04.34.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Dec 2024 04:34:34 -0800 (PST) Message-ID: <17b60889-8d1a-4c90-854c-104f1604c5bc@bytedance.com> Date: Mon, 23 Dec 2024 20:34:27 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] sched/fair: Remove unused task_numa_migrate return value To: K Prateek Nayak , mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com Cc: chengming.zhou@linux.dev, linux-kernel@vger.kernel.org References: <20241216122357.1276382-1-zhouchuyi@bytedance.com> <20241216122357.1276382-2-zhouchuyi@bytedance.com> <2bda56c3-727f-4899-8d88-fd83f11b3e76@amd.com> From: Chuyi Zhou In-Reply-To: <2bda56c3-727f-4899-8d88-fd83f11b3e76@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello Prateek, 在 2024/12/18 14:29, K Prateek Nayak 写道: > Hello Chuyi, > > On 12/16/2024 5:53 PM, Chuyi Zhou wrote: >> The return value of task_numa_migrate is unused, remove it. >> >> Signed-off-by: Chuyi Zhou > > Feel free to include: > > Reviewed-by: K Prateek Nayak > > If anyone cares for the history, initial NUMA Balancing implementation > used the return value of task_numa_migrate() to retry NUMA Balancing in > commit 6b9a7460b6ba ("sched/numa: Retry migration of tasks to CPU on a > preferred node") however in the same series[1], Mel also included an > optimization from Rik which retried NUMA Balancing periodically > irrespective the return value from task_numa_migrate() in commit > 2739d3eef3a9 ("sched/numa: Retry task_numa_migrate() periodically") > > [1] https://lore.kernel.org/all/1381141781-10992-34-git-send-email- > mgorman@suse.de/ > Thank you for providing the historical information! I will incorporate it into the next version.