From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E48FC4361B for ; Sun, 13 Dec 2020 01:22:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 191E021E92 for ; Sun, 13 Dec 2020 01:22:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2501966AbgLMBWY (ORCPT ); Sat, 12 Dec 2020 20:22:24 -0500 Received: from linux.microsoft.com ([13.77.154.182]:48242 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439971AbgLMBWB (ORCPT ); Sat, 12 Dec 2020 20:22:01 -0500 Received: from [192.168.86.31] (c-71-197-163-6.hsd1.wa.comcast.net [71.197.163.6]) by linux.microsoft.com (Postfix) with ESMTPSA id 5733E20B717A; Sat, 12 Dec 2020 17:21:20 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5733E20B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1607822480; bh=kz3wKCtkMGRbBL7DgaNsjN9rDf1wDVaCx3hZCXAf0YA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=C3reOcaSGuJ4JUEGIZgSbUmivzlOLZUuB2+Ima2rwXFTJrhrg5VUAcKJI0+vDnG8f FnRquP3CNqVci8aPC6uhcL1RPnyZEY3I7PalY+esT6oqTFD1jN7QaVfLXvLNRcISt4 tRj+/NHvT22VeobtseQUinjEouE6QnolpX5c5VDE= Subject: Re: [PATCH v9 4/8] IMA: add policy rule to measure critical data To: Tyler Hicks Cc: zohar@linux.ibm.com, stephen.smalley.work@gmail.com, casey@schaufler-ca.com, agk@redhat.com, snitzer@redhat.com, gmazyland@gmail.com, paul@paul-moore.com, sashal@kernel.org, jmorris@namei.org, nramas@linux.microsoft.com, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com References: <20201212180251.9943-1-tusharsu@linux.microsoft.com> <20201212180251.9943-5-tusharsu@linux.microsoft.com> <20201212192022.GI4951@sequoia> From: Tushar Sugandhi Message-ID: <17b756ea-5097-215e-fcad-c2d06f46ec23@linux.microsoft.com> Date: Sat, 12 Dec 2020 17:21:19 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201212192022.GI4951@sequoia> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-12-12 11:20 a.m., Tyler Hicks wrote: > On 2020-12-12 10:02:47, Tushar Sugandhi wrote: >> A new IMA policy rule is needed for the IMA hook >> ima_measure_critical_data() and the corresponding func CRITICAL_DATA for >> measuring the input buffer. The policy rule should ensure the buffer >> would get measured only when the policy rule allows the action. The >> policy rule should also support the necessary constraints (flags etc.) >> for integrity critical buffer data measurements. >> >> Add a policy rule to define the constraints for restricting integrity >> critical data measurements. >> >> Signed-off-by: Tushar Sugandhi > > This looks nice. Thanks for the changes! > > Reviewed-by: Tyler Hicks > > Tyler > Thanks for the detailed review on this series Tyler. We really appreciate it. ~Tushar