From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E670C77B7C for ; Mon, 17 Apr 2023 19:02:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230283AbjDQTC2 (ORCPT ); Mon, 17 Apr 2023 15:02:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230003AbjDQTC0 (ORCPT ); Mon, 17 Apr 2023 15:02:26 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72E01E62 for ; Mon, 17 Apr 2023 12:02:24 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 08A5B1F85D; Mon, 17 Apr 2023 19:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1681758143; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Bm/TkpcMy6cuYGFixPMtHN6GQvyYrnWfVkOFEnqjaw=; b=VMALOtZopBgD/6l2GDTO7VzUHOBAFNMokUNAQT3o2i/7q+iRcJvNU1/wGkUHrBSH+vsG1c g3oX0FMqF8FQ4nmXN/26AQcAN/vKgHXLL9w9T/gYyXpnk/LSOKOqJld+dq7Yv8s10l01DZ S0utMIsut+u6oc9PfaTU9jQ3jswZ1F4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1681758143; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Bm/TkpcMy6cuYGFixPMtHN6GQvyYrnWfVkOFEnqjaw=; b=GMsCwVu6HWh2dPz+S/L4pxzYt++4V7dmJTdQEF2RC7ffeASZHg5UUFOap5IwuJOyI7XJTU WfNRFCPcGSp4TfCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E012013319; Mon, 17 Apr 2023 19:02:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rB4YNr6XPWQxIwAAMHmgww (envelope-from ); Mon, 17 Apr 2023 19:02:22 +0000 Message-ID: <17bbab58-3cde-e980-bdeb-b9de65848b2e@suse.cz> Date: Mon, 17 Apr 2023 21:02:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 2/2] mm/slab: break up RCU readers on SLAB_TYPESAFE_BY_RCU example code Content-Language: en-US To: SeongJae Park , Matthew Wilcox Cc: akpm@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230417190129.1454-1-sj@kernel.org> From: Vlastimil Babka In-Reply-To: <20230417190129.1454-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/17/23 21:01, SeongJae Park wrote: > On Mon, 17 Apr 2023 18:53:24 +0100 Matthew Wilcox wrote: > >> On Mon, Apr 17, 2023 at 05:26:57PM +0000, SeongJae Park wrote: >> > Hi Vlastimil, >> > >> > On Mon, 17 Apr 2023 13:05:40 +0200 Vlastimil Babka wrote: >> > >> > > On 4/15/23 05:31, SeongJae Park wrote: >> > > > The SLAB_TYPESAFE_BY_RCU example code snippet is having not tiny RCU >> > > >> > > Since "tiny RCU" means something quite specific in the RCU world, it can be >> > > confusing to read it in this sense. We could say e.g. "... snippet uses a >> > > single RCU read-side critical section for retries"? >> > >> > Looks much better, thank you for this suggestion! >> > >> > > >> > > > read-side critical section. 'Documentation/RCU/rculist_nulls.rst' has >> > > > similar example code snippet, and commit da82af04352b ("doc: Update and >> > > > wordsmith rculist_nulls.rst") has broken it. >> > > >> > > "has broken it" has quite different meaning than "has broken it up" :) I >> > > guess we could just add the "up", unless someone has an even better wording. >> > >> > Good point, thank you for your suggestion! >> > >> > I will apply above suggestion on the next spin. >> >> For the last one, perhaps changing the tense would have more clarity: >> >> similar example code snippet, and commit da82af04352b ("doc: Update and >> wordsmith rculist_nulls.rst") broke it up. > > Thank you for this suggestion, Matthew! Will send a new version. It's ok, I can just use that when picking the patches up without a new resend. > Thanks, > SJ