From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48623C433FE for ; Tue, 8 Mar 2022 18:18:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349484AbiCHSTm (ORCPT ); Tue, 8 Mar 2022 13:19:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349464AbiCHSTj (ORCPT ); Tue, 8 Mar 2022 13:19:39 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1D4FA3D48B for ; Tue, 8 Mar 2022 10:18:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646763522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SS6f7dRwxzKIXX1gLdfWCfBLoUQykjMr5LR57Ii/WgE=; b=hGcOw1cfvZ3AHtfUmxyiuCJSMi2V4/7vMt0Ev/2lFK8zrwneOhaV6uiolF2iLJuns7+EuX Lzpz3OIZtmB51gi6Mxz1Shqxp7TcUVIBWDeOtQX/wBHUJ+24LSZj7r3kxVMKF0UOqvNRrk wbMcQ5iIR3LlhgEMBwjwcp/rLILbe6U= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-349-Gsix1dlLN4eP0kpdVZ_2aw-1; Tue, 08 Mar 2022 13:18:41 -0500 X-MC-Unique: Gsix1dlLN4eP0kpdVZ_2aw-1 Received: by mail-ej1-f69.google.com with SMTP id d7-20020a1709061f4700b006bbf73a7becso9102527ejk.17 for ; Tue, 08 Mar 2022 10:18:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=SS6f7dRwxzKIXX1gLdfWCfBLoUQykjMr5LR57Ii/WgE=; b=u0u+MUP8x2sMUEq5DYQbPkOv/ZlBUceT+ee2p0EBMUn7AQmep+n8R3unP9uh1/zGJu aeOvzKH/TknwlMCFiQBMo/oSaFfFrlDO3XBYFbxHJBcrMegZdopbk2VKBcLhE92xoUN2 0+BZgpE43UdQ8MXm66Txo+BJEhxIlRKnMV861C/ZkCPLVa7tnChhpFAlhr9uaG3DU38m pUXpzrNCAftOfTocsyJ5my1MJpEcJ/oPJ7OCvOyR62yfw7du1XLNpG/xEMM7OpynUuym chJT19v0Ppr7eTo9bg9SeKa9LWJYLGCTvnHqo5rTo092J/Zq4dkQmUhhj+3+RTC7IG8G 9FyQ== X-Gm-Message-State: AOAM5336FpgatPtXtUpRHeQjvWo5DqziQRHjko1l8zLNXhAnxqJ2cpD3 BGXbJQcbHdy9ylW+iFqTtCNAvowSMqhrR3wAluM3ttS7yL0CQdK1sJSz0EhH8wxJn39Ssz9e39Q 2bd6paRX/s7fYX6AiAcTaMOQS X-Received: by 2002:a17:907:1c0a:b0:6da:7ac4:5349 with SMTP id nc10-20020a1709071c0a00b006da7ac45349mr14620588ejc.596.1646763519559; Tue, 08 Mar 2022 10:18:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJy9UKSdlIjJiXmn1spywhUg4vxQcqmWsv7ZWbx3Y7a36yveI+/CikgqEVMnFw0WXKZw0Rc7ZQ== X-Received: by 2002:a17:907:1c0a:b0:6da:7ac4:5349 with SMTP id nc10-20020a1709071c0a00b006da7ac45349mr14620563ejc.596.1646763519291; Tue, 08 Mar 2022 10:18:39 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id hb19-20020a170906b89300b006daa95d178esm5501118ejb.60.2022.03.08.10.18.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 10:18:38 -0800 (PST) Message-ID: <17bc86ec-b470-e6ce-d467-fdc3b11c9c16@redhat.com> Date: Tue, 8 Mar 2022 19:18:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 11/25] KVM: x86/mmu: remove kvm_calc_shadow_root_page_role_common Content-Language: en-US To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, dmatlack@google.com References: <20220221162243.683208-1-pbonzini@redhat.com> <20220221162243.683208-12-pbonzini@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/8/22 19:17, Sean Christopherson wrote: >>> + role.base.direct = !____is_cr0_pg(regs); > > On a serious note, can we add a WARN_ON_ONCE(role.base.direct)? Not so much that > the WARN will be helpful, but to document the subtle dependency? If the relevant > code goes away in the end, ignore this requrest. Ok, that can be done. Either that or !is_cr0_pg(). Paolo