From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753611AbdC1P3e (ORCPT ); Tue, 28 Mar 2017 11:29:34 -0400 Received: from mail-bn3nam01on0041.outbound.protection.outlook.com ([104.47.33.41]:37310 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751288AbdC1P3a (ORCPT ); Tue, 28 Mar 2017 11:29:30 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH 1/2] crypto: ccp - Reduce stack frame size with KASAN To: Arnd Bergmann , "Hook, Gary" References: <20170328095814.3734615-1-arnd@arndb.de> CC: "Lendacky, Thomas" , Herbert Xu , "David S. Miller" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Gary R Hook Message-ID: <17bcfec8-1095-a49e-184f-4b43bad29c98@amd.com> Date: Tue, 28 Mar 2017 10:28:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR13CA0006.namprd13.prod.outlook.com (10.169.208.16) To CY1PR12MB0474.namprd12.prod.outlook.com (10.163.91.28) X-MS-Office365-Filtering-Correlation-Id: c8160d8b-dd10-4ab7-445f-08d475ef2369 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423062)(201703031133068);SRVR:CY1PR12MB0474; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0474;3:YnYnPoaCi55FOcNzQaO+Hx7FVv2jbSRk+aJCEwRN3Kwav8CKOPIPUh2WoNNYbz8yqr6D9bSOcbYH6w3mbSXX9FMN6D7GwwepyRdhkc/e3MoXmFjy9gE53dneMfCs7UBIZXzrhGm2NhwMumDiDYvsNJV3kEEf0vRPj8o5PH+mCpc9GHJOX8guumpuQ5XJImOKF12rdhp8amReraDp2iHHpIXF7WIApTBEBF2RfCgZ9btwccZ/SrLma5zXnoR8Lo+5YYVpeMBotAgMQp/XaauSayPzDQpBaPU8/YC2O4DDFT03oW9HNmpQN0TpYc3fCaK6NrphhpA+RKdKH3k6CTevQ1UKCFufwzvo5JUYNA35VKM=;25:92MdCnXEOKJAYwGWTfGxhUdeGpTwa/I1n/9bFqNujTkJR6uhu6pOyJrLw52btxijH7SAeUU8sSipwcsPoaf9FwmWYsnnop96YTA9WaWdxf8u8ML9VkC0DHK7qJ82Fu3DAdrpXKLne5CajAg+m6PkOir8rN6qilYEhses415lCYpaTYXhO7D6L7q+bed3xHGnnz1u34MzfabSswhYNkXaPFHlJu4fY80rqt/5IsTtMV90loYg9xm5QODh2G/fFpCoglDB8pDZrNMJDDiDeSoJ6qWZS03SMiNgqJXibM/erzMHfeXhd1bD689nPJMvzKR3JY5zX6O0JZJ2YPX1raNBfyDbEV7BEsN7Hk4Fqf0xaiADiHAdyQkqJoJrVghz4Tb3YYgMBo0O7oyJRqwV9e60S9CyRV7pF5UIxHT5njAFcybaVwVY2yyEO/Jd+wfGyOUc9GUd4EF4RUSc9UgNwJSNng== X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0474;31:4n2LaA40L8QaRXRcYYQEABeQklT98FGGNW04fBkQ60LUsSS7qYZw1kmzUIbdXvPTPQ3TGrOhTkho8bKxKPPBj41TAeOjoOrHspgTK9wFRLE6kZ16g26Sl14+HncHD56/8HV97WGpk6U8IFojLZ05uIbYoZSXhAVA5FXGN0tCC90e8AEMOaste0F8S7G6rDRbTX4RAlb4s1CkxpaPN9zg7hqJqPW0JgWMXFFE5Z3wubTFSNnPmG5zRi3RGgPt0Mxe;20:H5yW/UkFhgIKUt2wNgShAXIQ0anRRvERVLN2b0Wp5kskyCFxe8yo6Kd8CPmMYzVWV2BYL11Y0M1yY8jMzTRMQgquStiNWdvpsdBJhZjRr71Fe6fYKhjQDCr6jBocvXOKN4bSSLExwVuFHItfGJkSOBrTA9IvrP1havLbEep6F3xrJey6kyWalMxJqWjiWyr/s2/CQJIfToV0yy+eQzICefeFxeHR3JNaf4MtRKpBgkhbrKLCyHi2gl1n1iyLsgB8+ZESevjdMNqwEgcGBBYSZIOOO8JdqckhtGNtSkxWVk2/7qF07LlhqPudOETZCy0igbtu5TABDNBQWZQoQiKvSdBZzqKXF819SfNkG8TzJxdasDokKRJxkJxhcBi7p+pg2eeiMAArBQ3ULci42sH3sT8XCpkLEo6AQhWsP0YI5MnKNRB3UmafAgdXf0YdYBrIHYui2rnF6zF3d1BzFOrEOueZrbARuIytFsr03SjQF0WLocIyTcVk5j35aairaH6v X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(148322886591682)(767451399110)(81227570615382); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040437)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(201703131423062)(201702281528062)(201703061421062)(201703061406062)(20161123562025)(20161123560025)(20161123558025)(20161123555025)(20161123564025)(6072148);SRVR:CY1PR12MB0474;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0474; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0474;4:VydhSMuGLwVZIShnPbFbrs75APXiRXf+tBxB0QSGLEdoWACNDkDhSXm5MT4avS8Lc7a0l+C0McT43gpzP+YCUZOshZFK8UsOQUfePrSDcFcDgCKb03jgi7e+j7eolkX/FVkL7q42bplFiHd2Yz57J1pdrJ7DCP0Qn7YAJ8Zl+ThU2Kt8eOHCJkyCMcDwQwUzcHnqZjVKiOvgF8IznzjtCMdCSBPenQ1z4x2CQhYaVyC1bovlESE2Zmed15wSDnoceMsx0ABTpOV+ZS2IXHYjwNrWPHhFkSQe84L3kfHChBb3Gn0K3M34YQ9WuO6+vOdH3GDCioQUJxKBDqLdpeAznZuNas919xqjVIgqCg3blyxnw0qkR2glD7WFaXLliK1VNKxsoGFyB/VNiYn6TUrFxgXfC8dIR73ax/csPvcJ+OC/ZgJ9A+OI+/leDgVyDgr/HYidcqUCImyw3ITbxgPgW5wbZl0lhwfvmiLuu1V/hRdeqdsSJFltRsEcdOL7eKzQLMx6gyXAH6DKGnYb0AcsQn8dD39nZU/aEfAPjNRd3HK9aHo7N81xGl0A3b4iI++eF24h5DJW4rCo41q8wxascoxYGPZ3EW+yEmVZIIrnBQh0w3KjDXk379ybR0LRZF/u5YSVOlKCqzELra79FI52gF/knsZ1hT+wBIltBAMHZ/yClEfoFZemOHyl8VfIuEUOUCWBzj21lXkNl6c0GgdkY256IlmdzXTsSCeaN2gDSAMj4Gly4yh97hmBFo0GH7Pvr9qxXRTn9x7XkPUEuj9YsxRC230xIsylxsnNhDxqJJSB162GR571P9wgYnRuX89hhT6wjQ5GwAtTYlRy5r6VmdvFzyB9X2hgxfCprMbTS20HADWP8WqD65rOVhxPlrY/ X-Forefront-PRVS: 0260457E99 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(39850400002)(39860400002)(39450400003)(39400400002)(39410400002)(39840400002)(377454003)(24454002)(65806001)(33646002)(65956001)(230700001)(66066001)(229853002)(4001350100001)(6246003)(2906002)(47776003)(6116002)(54356999)(8676002)(31696002)(3846002)(4326008)(5660300001)(7736002)(38730400002)(83506001)(53546009)(305945005)(31686004)(90366009)(36756003)(2950100002)(50986999)(54906002)(50466002)(42186005)(53936002)(81166006)(189998001)(6486002)(25786009)(23676002)(6666003)(64126003)(77096006)(65826007)(6636002)(76176999);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0474;H:[10.236.19.127];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwNDc0OzIzOmJiWS9LblBrczR5TVcvTHdLeWNOc0VrWkdx?= =?utf-8?B?TkkxdVJCQUpQcVpqUHJsSUNPZmhkM2tNd0ovQTlRb09aczFXQ1FUT0pKeGJZ?= =?utf-8?B?dGlFNUpnNjFyMDJSYXVhNG9WQkVyREFxT1JxL0tEd29rSER5QjJlcXVZaHht?= =?utf-8?B?R3U3YUxZVWR4ZkhxTHdLVUtCQy9wa0xaM2NLMC9BbDc0dXMxVHBXTWw5SFR1?= =?utf-8?B?OWR6a05sdS9IRXRKTnB2YWEvMUJZU0RhQ0lnK3pPbEJQSEpSSERjeWpHTWZ4?= =?utf-8?B?ODdjQnNZMS9QK0gvUHRKU2sxMmNhSjdHcmpKT0daSkFqTDdvL0ZLVy84OXF5?= =?utf-8?B?aDBJc0dnN0RoamRKVU1ySUtNMjBMUi92cWxJS2hsUVJJWEtQY2krSy96alA4?= =?utf-8?B?blluODI5bUFSYnEyUy9FKyt3NUkzUU9KM1BkSzd0dWZXL3FiZFBWVkpoSGww?= =?utf-8?B?N21rTURrRWJvQmpwQTNyYkJueVR2b1oyLzBjbFJyWFhPYXBOOFpNbmpvMHk4?= =?utf-8?B?YVJmbE0zTUwwR3IwVDIxRUdZaldnVWpPZDFPclpkRTQ4WG9LSmhGbjhkaGNE?= =?utf-8?B?VkZWTXJUN0tsRUsxdmhUUFlmdngySDNsTVJaWGpCOXF6aHhSa0NGN21Wam1C?= =?utf-8?B?N29OUFFEMEl5anBMTGt3R3FKUFJyN1JKRzYvQ0dMbElPbWhMYUVYNEVFZWor?= =?utf-8?B?VTVwR2ZBWVFCSVlHdGNFRHBCYUlqSFltT1plVFp3UThkQVd3aE8yWTBQVkZF?= =?utf-8?B?eW1rcTMycHhucGt0bEpDWXZuY3hmM250SUlTdzVhV1dEOTFzQ3lVeE9hTlp1?= =?utf-8?B?a2lPQ3g2dUNFSkRBbFhaTmxGbjhhcGROVm9OQzVIOFp0NVV3MHlhbGd1L1lr?= =?utf-8?B?R1BnSWZucGs2a2lUOTlHRHJJN1A4d1RuNW93WGY2cGNvbmxMaVBaTGxZWXFN?= =?utf-8?B?bm03MnF1M3BCVnk0SWlkYUFxWGdhb2UySndsWjJlcFYrMzFmTXZGa0VVeVU3?= =?utf-8?B?NVV5UFFlZllsSXczbmNYUDJQdjczQThPb0ZxSEJ5UG1xMi9xd1hFc1ZmM0t5?= =?utf-8?B?aS9wM1QxWUtydHhXQ1RzNU9UOERTRkNNeWdlWVJJUDhDcHZrdWQrZ3VjYnhO?= =?utf-8?B?WHFtVnpUOGc2Uk5oL3h4V0x4bXRNcW00UmtpLysrN05mZldPL3RSdTRXZzd1?= =?utf-8?B?VnVkLzI3b0tkUlF1aCttUWo2a1dlYnh1ZzREUFhpcmdBOWdZeXBZS2V0Nkdr?= =?utf-8?B?V3V0WC9ZWm8veW5XMXhQWVo4eC9aTTRCeUkyblFWU3FxankwQldYazM3WHVV?= =?utf-8?B?cGM4TnpRQVFiZVJLcmNINVZIYU5GeFdScktseC9xTzhicE9PVXJrUWUrZE5O?= =?utf-8?B?WTl6Ynp3MTRuMEJGYk4rTUZoUzBrZURxemY2VHdHQTVVTlRzMElIK3RxNjBr?= =?utf-8?B?QUJOSXdzRkplVFRUdVNsZlJ0RDJZUjJ3Mk5PME9zZGRYY0pDVWJ1ZGw3bGFk?= =?utf-8?B?MklLU3FqaG5kUGZhR0pFNUE3blliY3lTWlRoMWtqR2w4cFRuYXQxY29TV1cw?= =?utf-8?B?ZEpBbjdreGtmdmEyam9iK3VwWWp0cTdIQ3NLVDFTcjAvelhxTnduVjVXN002?= =?utf-8?B?NFp2dHhLcTRMMlZ3S2o3M0pOVXRxUU1hR2ROWFQwR3NvN2JqcXBMOWdld3dP?= =?utf-8?B?QUdGMDltejI4Q0p5ZEVjTU5sNWRrZGhGMzFTaDdLN1Q3NkwzalZIakJJOHdK?= =?utf-8?Q?VyJihNtHTg0OpMxBtiOpcbSqQxodg6IdGEMx8=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0474;6:LSAuuhLumORbjN2Sqjx2GQ655rdunJb3yDmWXj6qQuxZ4aUw7mGIKiJVpI6TOIGkgXCNziI+a/8f700Xvz+sFdkcOiGRz04+ugcPsQc/yR1SownASSdRn5kLWxjO9oNlJ8ovHeFPujbn7g2Uf+kkTfpEglzi+jDn+a5L5pQvqlzrG1syd0gzU3nvi5LIF4YARF57e9PmdW7f/DH0Fi4zRPmhSkKzooszBOYaVUD1O9KOY3O7rZnrClUeAYuZgNzxesJiX+E6MaCulMKGNIvHh1R3uC2cpKvL4YuwJQGBMDStE+iOe6jmlhJZjCnDDP0Xy/QYbLVwJidGhoKCNHvFtQLT4T/IYxG/pr6+xVbviH1FsQ6OF3zUAaeJZS4BL/5pXDK5IVqHBXzqWRUUPofERt/qnbFX3XxUXc1OwcEHUlk=;5:wXkdBsufVhePrbrMQHMvHc3YH0jPEZHsa1hwubC4belVHkMD4TIDQR72FJQLv2240J7NtfkYiG/f+3YCwdqNPzna4TiEsNz1qRUuQTcBfzzmzJEcPme0ntPc/BDLIUtgpQojtSAId5qr4HSosntAVw==;24:eUrxcuXIvoVDZvENxA2PutOITK17EcbuTAW5/kUC7/ZFy6Mm4u+sjEOfTCKTdvj+8RaRqS5OyerkUuDQ7SwUdHmzOVNI4sDaJOPJLtqonh4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0474;7:iQWSZ3CL3LKFWk5lKfXl4b/gGfOnm/uvQr70mCafK6hDHMz7iZ6NzYWrZIP3vwCQ56qvdpEnQEorR968ZsJXMUeGrcwXYBOisyEWYyo2bR9I8aYWGFt05zNcrz5AedXXKed/WjZ58NDTqdnDdwagYQK8v7Z6Q8M2+v9xAkx/EhG8f7LDcgC4j/WyqUtPo3l4J5pTbF7gU1uAB95ecje3JdyStINB4Gg9dO4uLpR9ffkxafirjnoNvj7SuFh9i8b9Vdcy0MUwTrZ2HScNgj9cXPxnZWvnZGKptgAC//oly0MaTsCX8keqVflJci3z/VTkQ9tpdT8bqbPMpbbJJs+QOA==;20:JAwwdFy1HrlgzWHVcZw9Ql3s6eu8GZz5Yf4t2uhEVKEIO9rM/30IYmxkx6uSKsOvmX3eSvsP9/6Y/U0UO5rCRhx7s1RydZxmPK39cjTcx4Zi/1A2MqNmjjRF68OK0GAwJTB77SclFzpgmlVvCRNWREMQTSCGrD2jKDQdF1yBJsBG97k/nKRcMpKvX73zbOSNZLvBUDPXl7EG3nPJfwKXarlD3qCz3f2KcOrqqBAnIO4pciXRynBOtbGiRC9t2w96 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2017 15:28:51.0911 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0474 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/28/2017 10:10 AM, Arnd Bergmann wrote: > On Tue, Mar 28, 2017 at 4:15 PM, Gary R Hook wrote: >> On 03/28/2017 04:58 AM, Arnd Bergmann wrote:> The newly added AES GCM >> implementation uses one of the largest stack frames > >>> diff --git a/drivers/crypto/ccp/ccp-dev.h b/drivers/crypto/ccp/ccp-dev.h >>> index 3a45c2af2fbd..c5ea0796a891 100644 >>> --- a/drivers/crypto/ccp/ccp-dev.h >>> +++ b/drivers/crypto/ccp/ccp-dev.h >>> @@ -432,24 +432,24 @@ struct ccp_dma_info { >>> unsigned int offset; >>> unsigned int length; >>> enum dma_data_direction dir; >>> -}; >>> +} __packed __aligned(4); >> >> >> My gcc 4.8 doesn't understand __aligned(). Shouldn't we use >> #pragma(4) here? > > That is odd, the __aligned() macro gets defined for all compiler versions > in linux/compiler.h, and the aligned attribute should work for all supported > compilers (3.2 and higher), while #pragma pack() requires gcc-4.0 or > higher. > > We generally prefer attribute syntax in the kernel over pragmas, even > when they are functionally the same. Yes, it's extremely odd, and I understand this preference. Please ignore my submitted alternate and let me track this down.... -- This is my day job. Follow me at: IG/Twitter/Facebook: @grhookphoto IG/Twitter/Facebook: @grhphotographer