From: "Tobias Müller" <Tobias_Mueller@twam.info>
To: David Brownell <david-b@pacbell.net>
Cc: Andres Salomon <dilinger@collabora.co.uk>,
akpm@linux-foundation.org, Randy Dunlap <randy.dunlap@oracle.com>,
deepak@laptop.org, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, linux-geode@lists.infradead.org,
jordan@cosmicpenguin.net, cjb@laptop.org
Subject: Re: [PATCH 1/2] cs5535-gpio: add AMD CS5535/CS5536 GPIO driver support
Date: Sat, 15 Aug 2009 12:59:48 +0200 [thread overview]
Message-ID: <17be05570908150359t2cfafac3if43a2dc55a1a7195@mail.gmail.com> (raw)
In-Reply-To: <200907011532.34677.david-b@pacbell.net>
2009/7/2 David Brownell <david-b@pacbell.net>:
> Correct-but-annoying ... and maybe worth changing. The
> direction *displayed* may not reflect the actual hardware
> until after that GPIO signal is initialized. Boot firmware
> may well have set the direction; Linux shouldn't change it
> without explicit instructions to do so.
OK. If this is a know problem with all GPIO drivers, we can
skip these to two lines to set in pin a defined state.
> So it would be nice to remove the heuristic. The best
> way would be to add a new method to query gpio direction.
> Then that when it's available, instead of the heuristic.
This can be implemented when the GPIO interface supports it.
The problem with the mask still occurs. I changed to default
mask to 0x0F7FFFFF, so that all pins except the reserved
ones and the power-pin (which needs special handling) are
enabled. Shall we keep it this way (which I prefer) or delete
it entirely?
Sorry, for the late reply, holidays were nice. :)
Tobias
next prev parent reply other threads:[~2009-08-15 10:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 4:10 Andres Salomon
2009-06-11 14:46 ` Tobias Müller
2009-06-11 15:16 ` Andres Salomon
2009-06-11 18:52 ` Tobias Müller
2009-06-11 20:00 ` Andres Salomon
2009-06-11 20:11 ` Tobias Müller
2009-06-11 21:28 ` Andres Salomon
2009-06-11 21:35 ` Tobias Müller
2009-06-13 0:23 ` Andres Salomon
2009-06-20 10:20 ` Tobias Müller
2009-07-01 22:32 ` David Brownell
2009-08-15 10:59 ` Tobias Müller [this message]
2009-08-18 4:43 ` Andres Salomon
2009-08-18 8:32 ` Tobias Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17be05570908150359t2cfafac3if43a2dc55a1a7195@mail.gmail.com \
--to=tobias_mueller@twam.info \
--cc=akpm@linux-foundation.org \
--cc=cjb@laptop.org \
--cc=david-b@pacbell.net \
--cc=deepak@laptop.org \
--cc=dilinger@collabora.co.uk \
--cc=jordan@cosmicpenguin.net \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®