mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zhengzucheng <zhengzucheng@huawei.com>
To: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
	<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
	<jolsa@kernel.org>, <namhyung@kernel.org>, <tglx@linutronix.de>,
	<bp@alien8.de>, <dave.hansen@linux.intel.com>, <hpa@zytor.com>
Cc: <linux-perf-users@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] perf/x86/amd: Remove unused variable 'hwc'
Date: Mon, 9 May 2022 11:07:09 +0800	[thread overview]
Message-ID: <17be552a-ff87-0c9e-d963-fa00705e7a91@huawei.com> (raw)
In-Reply-To: <20220421111031.174698-1-zhengzucheng@huawei.com>

ping...

Any suggestions for this problem?

在 2022/4/21 19:10, Zucheng Zheng 写道:
> 'hwc' is never used in amd_pmu_enable_all(), so remove it.
>
> -------------------------------
>
> Signed-off-by: Zucheng Zheng <zhengzucheng@huawei.com>
> ---
>   arch/x86/events/amd/core.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
> index 8e1e818f8195..d7f9500b876d 100644
> --- a/arch/x86/events/amd/core.c
> +++ b/arch/x86/events/amd/core.c
> @@ -714,14 +714,11 @@ static void amd_pmu_enable_event(struct perf_event *event)
>   static void amd_pmu_enable_all(int added)
>   {
>   	struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
> -	struct hw_perf_event *hwc;
>   	int idx;
>   
>   	amd_brs_enable_all();
>   
>   	for (idx = 0; idx < x86_pmu.num_counters; idx++) {
> -		hwc = &cpuc->events[idx]->hw;
> -
>   		/* only activate events which are marked as active */
>   		if (!test_bit(idx, cpuc->active_mask))
>   			continue;

  reply	other threads:[~2022-05-09  3:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21 11:10 Zucheng Zheng
2022-05-09  3:07 ` zhengzucheng [this message]
2022-05-11 19:46 ` [tip: perf/core] " tip-bot2 for Zucheng Zheng
2022-05-12 14:33 ` tip-bot2 for Zucheng Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17be552a-ff87-0c9e-d963-fa00705e7a91@huawei.com \
    --to=zhengzucheng@huawei.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®