mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Akira Yokosawa <akiyks@gmail.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Linux Doc Mailing List <linux-doc@vger.kernel.org>,
	Jonathan Corbet <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org, Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [RFC 1/6] scripts/get_abi.py: make it backward-compatible with Python 3.6
Date: Thu, 30 Jan 2025 16:34:14 +0900	[thread overview]
Message-ID: <17bf0ec5-17bd-4a1b-b5c9-2584d01eecf7@gmail.com> (raw)
In-Reply-To: <6d74360f8cdabeb0bf628a6e870d10e134f396f0.1738166451.git.mchehab+huawei@kernel.org>

Mauro Carvalho Chehab wrote:
> Despite being introduced on Python 3.6, the original implementation
> was too limited: it doesn't accept anything but the argument.
> 
> Even on python 3.10.12, support was still limited, as more complex
> operations cause SyntaxError:
> 
> 	Exception occurred:
> 	  File ".../linux/Documentation/sphinx/kernel_abi.py", line 48, in <module>
> 	    from get_abi import AbiParser
> 	  File ".../linux/scripts/get_abi.py", line 525
> 	    msg += f"{part}\n{"-" * len(part)}\n\n"
>                        ^
> 	SyntaxError: f-string: expecting '}'
> 
> Replace f-strings by normal string concatenation when it doesn't
> work on Python 3.6.
> 
> Reported-by: Akira Yokosawa <akiyks@gmail.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Tested-by: Akira Yokosawa <akiyks@gmail.com>

Thanks.


  reply	other threads:[~2025-01-30  7:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29 16:09 [RFC 0/6] Raise the bar with regards to Python and Sphinx requirements Mauro Carvalho Chehab
2025-01-29 16:09 ` [RFC 1/6] scripts/get_abi.py: make it backward-compatible with Python 3.6 Mauro Carvalho Chehab
2025-01-30  7:34   ` Akira Yokosawa [this message]
2025-02-04 17:28   ` Jonathan Corbet
2025-02-05  2:37     ` Akira Yokosawa
2025-02-05  7:15       ` Mauro Carvalho Chehab
2025-02-05  9:40         ` Akira Yokosawa
2025-01-29 16:09 ` [RFC 2/6] docs: extensions: don't use utf-8 syntax for descriptions Mauro Carvalho Chehab
2025-02-04 17:24   ` Jonathan Corbet
2025-01-29 16:09 ` [RFC 3/6] docs: automarkup: drop legacy support Mauro Carvalho Chehab
2025-01-29 16:09 ` [RFC 4/6] scripts/kernel-doc: drop Sphinx version check Mauro Carvalho Chehab
2025-01-29 16:09 ` [RFC 5/6] docs: changes: update Sphinx minimal version to 3.4.3 Mauro Carvalho Chehab
2025-01-29 16:09 ` [RFC 6/6] doc: changes: update Python minimal version Mauro Carvalho Chehab
2025-01-30  9:33 ` [RFC 0/6] Raise the bar with regards to Python and Sphinx requirements Donald Hunter
2025-01-30 14:31   ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17bf0ec5-17bd-4a1b-b5c9-2584d01eecf7@gmail.com \
    --to=akiyks@gmail.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®