From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A3A83FD94C for ; Thu, 11 Jun 2026 16:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781193676; cv=none; b=eY4diGSoeeS/em68+hq931y0K3vA+gu148RPoi7tciy0ddbgyoS53AwNbhIApc+6p/ENhDkgzgg8tZd4nDBC6knZnu9ijbI0Z2IYtl5VarUX2hP0HhSn0JF1KvmV2fw+AHuWW3/eFc0mBdjT8TBDaquFyVQYSEn8Pz1b/+h+9TU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781193676; c=relaxed/simple; bh=2FchrGodbYv/9qY2WYL8NeNKXHxKW64euQNt/BW9MZo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r1497z3TR/3XWQYfgc84Z/aexUgIzOgO1K41xMl/diHysDmg0m+/t/ZTk82M1vjnwA5fHzuWgZuo+bGlzRmrfZjNif336xvgeWuy63RCJxXzsqv0vt2zC7ay0iVY4i1iGfftqsuouzXHzaEhDn6vbNK70wo+ba+wKQbHdPDILNg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=e17C5s12; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z8AtdzI4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="e17C5s12"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z8AtdzI4" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65BEreob942717 for ; Thu, 11 Jun 2026 16:01:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mpCQ9BJ8wTuI3Z6G1W3wDVgURRxmxkiof9xlWmEBr6I=; b=e17C5s12Z6qBA7eG IoZ/gx0NcwV/eosnyDeRMq9VGCfYcyN1Cpnm0tMFIarUYJmFrzI8xvCbZXUKUzdU rsuU9mH7WRtjSisvrTCt6E+bxVVe7HPqdRTRrVCXQHFVdytqiSAWh3SPq+75tUcl bzlJ79JHea4epdfw/T7oRLI4gjdyRFwF6Plu0V2dttgHFJ5unyjbUPGjohO6bnn6 U7tyqShWbQ5H8ayUyXEe9PLMw7ndTvWT6cZ4dBIWHd1pzQp3zukTVdi7ftDvrwuw Tq4A1X0cR6oqPBKKKM00O/MFCfbhq4q9Hlrfiw7qlM7dutr9hOGz+la9IGjVCPr0 by359g== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe6tmcud-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 16:01:14 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2c2d65d9792so40705ad.0 for ; Thu, 11 Jun 2026 09:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781193674; x=1781798474; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mpCQ9BJ8wTuI3Z6G1W3wDVgURRxmxkiof9xlWmEBr6I=; b=Z8AtdzI4gRVbuPErnmNASk2AISZgydptjDa51fFR7WImrUtNzI0QrJnNf5Rlh00GKu OUq3LbPNl/PYsy+pdO+JEA3y5RUd2h/u465HaP51rwy2qcOdcGHjyh80gfsFOLlxUOoR CXh0PTszS6u1LU8LtY189f89id0xRuEcC2R2/UcwyrS5MDda/zoFz7gTdKeSq8KqHXJh s4Kw4tzRL3UAJ4yjQcKJrB79b/Trgy1pqkH0oa5BDyT5FwWvhisrmNPkoesfAJX9Fwml IljWhpY1px7nN5dJh0Fmd39N/lH63r5RLYqcE4yBS3BZ/y6snp14qX/4e/+/MiFo5kNv uHeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781193674; x=1781798474; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mpCQ9BJ8wTuI3Z6G1W3wDVgURRxmxkiof9xlWmEBr6I=; b=SVCWdDqt3TOk5699DpbP2MnIKk0VMVfc/H0Ph9HipdcUmGieG1xePBsu61rGa4H1p/ 3th5Nse25MHlBu+FOQSTTC99Xib7USdMWNFNinKnEbn813YGDIAgMDFm8Pg32wS7ZrH8 Cmzo3XdmCwSrlVFVE+VsnYu6X0MKzs/zuX6Pv6KA29Nvdbbo8bb8CUg5HRgJfriH9E4W iDRMd1W29Y8TOCn+DpciF/JDtu/sfZh4b9bhrF8BGzL4x73UqTk7S3hNTzTcE/gpCS3X ph+gfR3kUhdN+7tKvXBizVsHAnyaT16XD6dIE/JGWfHIGvg89uCDkhYKrXWDF+rB8qWy Acxw== X-Forwarded-Encrypted: i=1; AFNElJ+xaEbTInY1kUyASC+aU82nVyuBvnXKFhARzjMPLHI/XMgR+evIXZXDDwKAPT+TtKFNKE8tgYNw4Qt1l9s=@vger.kernel.org X-Gm-Message-State: AOJu0YwyOXt82kHT4Zbk7CStpfhMtKwM73nGTn3RW1NeS7cRYLVq2wFS bJzorTd2mkwbrPjZAc1vmdbJo6j/XvAADnCkV3cpsqK5hnAS5U3JupifNrdUE7uqKUl5865CNsO 58uaWeoykOwX348PLxA3XnOG/BAUgmS8oWThLnrCkhAm0fFSrb+0dKTwwhkbHWiw0lzo= X-Gm-Gg: Acq92OFZCUP0u83Gi1uWyUkqvHfOVJO47w6xzb5Suko5mNw5oVuWL1r10bejnmhwquN j4YGGWveex8KNjfvrHwnNVoJkVPBR5rW4sIsvIt+K3slbnRABnz7iAL5xv2/5FF219ZpTMiGS9C qknKBj4byoGCKznyivbLOFkHj2rmyHc8ON4OSvCqBzeiF9a/eqjaProX7lFq6QEuMi68kkU5gWh srLUzZf/O/83LGcC+YJ2kKUVzJxNGAxTevDKsEwFThVc1VewOKYk2ouZlYJTPeXFeckJNer/auH 8aDHvc0MvN8Y2rA4YdNEe5y8Vpxwk00iHsXtcqG8jWKJaumbcV/Ctx1fqqy/I7pSBcq2kMVRYa+ 5zifoMjTlHM+p+158C7BfcwVgwrR168PEldmpLeOnLJLZg4NCbBVJ4LWmU5Wub9pAZY1L X-Received: by 2002:a17:902:eccf:b0:2bf:e5c:d90b with SMTP id d9443c01a7336-2c2f3541affmr37502555ad.32.1781193673447; Thu, 11 Jun 2026 09:01:13 -0700 (PDT) X-Received: by 2002:a17:902:eccf:b0:2bf:e5c:d90b with SMTP id d9443c01a7336-2c2f3541affmr37501885ad.32.1781193672779; Thu, 11 Jun 2026 09:01:12 -0700 (PDT) Received: from [192.168.0.116] ([124.123.151.85]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f8429fsm348802935ad.18.2026.06.11.09.01.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 09:01:11 -0700 (PDT) Message-ID: <17bfa853-d0a6-4f83-a164-a17fb02f67a6@oss.qualcomm.com> Date: Thu, 11 Jun 2026 21:31:06 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: shikra: Add BAM-DMUX support To: Stephan Gerhold Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, chris.lew@oss.qualcomm.com References: <20260611-qcom-shikra-dts-bam-dmux-v1-1-43d0b43d41ef@oss.qualcomm.com> Content-Language: en-US From: Vishnu Santhosh In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDE2MCBTYWx0ZWRfX3y6iGHeDWlF+ pf8i2IWc8ydVYTNVm58hD/HQowXtPJTx/XI4Fax2+kVZyh4JD84jK3W3W+JDeBn6tmqob+lXAYJ 8lECWoNuQbOweSVS3ztHsH6Erd7qNE34vGcpI/68g1mxkhoTxHD+1JfuhDOoI1VhQq63h5EbF6S ezmAw7x7L+HmpEmH+1vOCFBTDv1rRH5HESFXaYIXsWc0w+PmFbPoJJrE87/2Qaqpqgcon0gPwmp x5pWEGIy+T0PMVyrD5C/FElSFkMhGtJmw4rH6fLOybEIWTLPmDVdodMBydVVrdeGtWA/ISZP+3V cV1XgVAhLh66P5Ktf8buFCMnnVH04yS+2xOwLdtordD/dqA0RvEyCjFwbp9C9PKZja82zPWN6I1 f+19ZiHjNPC/MyCdrrP4It6VANYAVBkh1w/XBfMr/Dd59+mM+4oaU39Q+9WI1okDPINtteBvjOQ TWtwUtMFVlMO6/yZqFA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDE2MCBTYWx0ZWRfX1il5N0cazOP3 e5r4a+oFm71xrxvQsabJoTN9FdIHEeycJKjO1Oj+s/hJVq9WtltoUgVuQrrT112Wk9H4HZ+4nYd s2TgXBbVzU5QNBE1r2/KFc2e/fTMJ5M= X-Authority-Analysis: v=2.4 cv=AaiB2XXG c=1 sm=1 tr=0 ts=6a2adbca cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ziBI+Y3eO/H+UwYWWny9Hg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=O-mRS134qTPuZNobniAA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: 4by3VLjxq2ftDMmDkUns1b1N0OQONAwx X-Proofpoint-GUID: 4by3VLjxq2ftDMmDkUns1b1N0OQONAwx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_03,2026-06-11_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110160 On 11-06-2026 02:25 pm, Stephan Gerhold wrote: > On Thu, Jun 11, 2026 at 02:11:59PM +0530, Vishnu Santhosh wrote: >> + bam_dmux: bam-dmux { >> + compatible = "qcom,bam-dmux"; >> + >> + interrupts-extended = <&modem_smsm 1 IRQ_TYPE_EDGE_BOTH>, >> + <&modem_smsm 11 IRQ_TYPE_EDGE_BOTH>; >> + interrupt-names = "pc", >> + "pc-ack"; >> + >> + qcom,smem-states = <&apps_smsm 1>, >> + <&apps_smsm 11>; >> + qcom,smem-state-names = "pc", >> + "pc-ack"; >> + >> + dmas = <&bam_dmux_dma 4>, <&bam_dmux_dma 5>; >> + dma-names = "tx", "rx"; >> + }; > This should be a child node of the modem remoteproc. See msm8916.dtsi > for example. Thanks for the context! We actually referenced msm8916.dtsi during bring-up and initially placed bam-dmux as a remoteproc child. We then hit the issue that the driver was not probing at all. After some digging, we realized that qcom_q6v5_mss.c (used by msm8916) explicitly calls of_platform_device_create() for its qcom,bam-dmux child, but qcom_q6v5_pas.c which Shikra uses has no such logic, so the platform device was never created. There was a prior attempt to fix this generically by adding of_platform_populate() to qcom_q6v5.c (https://lore.kernel.org/all/20251223123227.1317244-3-gaurav.kohli@oss.qualcomm.com/), but it was blocked because GLINK/SMD edge child nodes would also get spurious platform devices registered for them. That series remains unresolved at v1. Since your driver already manages modem lifecycle independently via SMSM state bits without remoteproc dependency, we moved it to the root level where of_platform_populate() picks it up at boot, and everything worked. Would love to get your suggestion on whether this approach is welcomed, since it needs zero driver changes. Thanks, Vishnu