From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17E881A2388 for ; Wed, 5 Mar 2025 08:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741164476; cv=none; b=i/VZP53TA9V1TcPzQP1hbNT2ZjkUQ0TDXMgOt/4zpnoLZhQLgL9puysScRNwRKdqJOUc80ejvNEouICkxGTRn6hCJL3xS07sRfwKVvsa1b1zOAGt2sKbHWM9Xj+ImbCE7BqYBQDWLYspWGO59HhywXxLWhBT+TQWuPemCm4SFcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741164476; c=relaxed/simple; bh=JKybJjCoE0B/n2lncmdSGTssjYFaX+FTdZIDp/sCbx4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FbU4eSNUUDEhScjQvDflP0Sv83xX7T764Su0p76khICRvGhRyybri8CCamr5WfhoiEeQrVTgyN1w92sFC7c5h0CPyrYjwfVP/qt4JcpiUXuZyyOWe50Gbx6gwWGbWPZuMCp8Uof1k+JjtXxZfFjq5hDav4KgAmhr3WYa1qXc7jA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=gXCWjgNS; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="gXCWjgNS" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-390f5556579so2784158f8f.1 for ; Wed, 05 Mar 2025 00:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741164471; x=1741769271; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zvpBTp2BY7pS5ECRfbZtHxBeNysVHVR+CVs88T54ai8=; b=gXCWjgNSk6nkFKhEXYKdcHk39drO7yuz13WakTs4xv6ae1wGXdHuRHfCzdEb2uN1yv 5erIEhN+KLRbfJHlwe9neNjBuTnacbRNOf4eBmL9HGDiracE4fsfbyzRB7C0TPLlpyrE f75wd0aoHcJ5Sx0MUyGyuA7E4T4c2ajX42pGpLXbEnMFreTTLJXqcLPXjDTdu1i4V5qA OnxD+Ug1fRXcc8TGi1QpzffbUcj07vXtc7qiKO18UdZKAlF9zBcZfyM+q3/aHFWMGaxV drYHo59+7hhV96wnqwD4AQSm6KZI/33M+IS0xbHBUmUiBqepOu4qH+J3bfotGXHUFVsT rtog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741164471; x=1741769271; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zvpBTp2BY7pS5ECRfbZtHxBeNysVHVR+CVs88T54ai8=; b=cauzWMNNHmXr18U6maAQBCG6ux9QGgk3pdYTsi5VEt9d3L6AwxktS2ILjyykMxaZZt geMMzX2vO0Jra3o08jCol5umBMytG6Jka0Y37serw4y0MN234o3/k8ep9txAu0be+VYF Y0ZKWcXu03yWrDXOjYhJiD7RnqrMnXqYZxUhkqt1zoVPLxc3qFdZinAq6gDDT+5lYMdW 0WONfnwBTH6qZ9H8XhELZlF9cURD9qgngtOkVP4Yss3BKPHqsV+26hoU8EhE5ja02pX4 AtWcKNqorKp/iSOAs6FNOUExLKsyyjDMgt2IFiqEfepvdGDICXJoqY/cADgcK1y4R2Ei 4iGg== X-Gm-Message-State: AOJu0YzH+gtOXUd7UGuFVtM/hZrdA6VCLaAkF7SQCjiM7BklfO1UAEqn eUXdS2kKixYdInC6Lq+At5gONXpKXv+sbigi+WfErpxznn5TPTaooQKjG/XF+M4= X-Gm-Gg: ASbGnctsOq5qEkEO2Ppe3j5/k8JC9KqhjXU4TSioiyg0AOuriTFQmUsie4L5jmwz6NP pJe5Xm4R0KjyQWxlHtTzcQGVRNysGbDi6qzn4tzKgTx7uQZM4T3aSgtWcUh6VEspa6VTymU4MrR ykxKNIyxSOcVcHDY1QJ3QYCsi9blY8h6C4cRp3IapEA+jAbrvofTGnn3V1qRI/ZfpYztzLGz5lc JmTm5WFG7knV69Ums5ORCA7X2O+NEShUnurBjRIf9BlXJbrgKxoHzUdcWYdDhAdKbeJMKD9ZHRK qq3ctK7GfmJ5OFk8niiE4e4DTzyZY85dzV5QpgZZ7FGEjQpg X-Google-Smtp-Source: AGHT+IFqiG5KUBY477piOlIYHBpXnTArndch8RArWHQORojdj7IkUy39eZX+lXOVE16msF37clFMxQ== X-Received: by 2002:a05:6000:1a88:b0:390:fe05:da8e with SMTP id ffacd0b85a97d-3911f75796emr1473006f8f.28.1741164471313; Wed, 05 Mar 2025 00:47:51 -0800 (PST) Received: from [10.100.51.161] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bd430c2e9sm10640655e9.33.2025.03.05.00.47.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Mar 2025 00:47:50 -0800 (PST) Message-ID: <17c0cce7-03c7-488a-b61a-6c41d5bacfa1@suse.com> Date: Wed, 5 Mar 2025 09:47:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/8] module: Add module_for_each_mod() function To: Steven Rostedt , Luis Chamberlain Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Sami Tolvanen , Daniel Gomez , linux-modules@vger.kernel.org References: <20250304012516.282694507@goodmis.org> <20250304012548.433669427@goodmis.org> <20250304095714.47a171fa@gandalf.local.home> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20250304095714.47a171fa@gandalf.local.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/4/25 15:57, Steven Rostedt wrote: > > Luis, > > Can I get an Acked-by from you? > > This follows the changes you have in linux-next. Hi Steven, I'm not Luis, but we started rotating the modules maintenance every six months and I'm currently looking after the modules tree. I see Luis seemed ok with the change in the previous discussion and the patch looks reasonable to me. Acked-by: Petr Pavlu -- Thanks, Petr > > > > > On Mon, 03 Mar 2025 20:25:21 -0500 > Steven Rostedt wrote: > >> From: Steven Rostedt >> >> The tracing system needs a way to save all the currently loaded modules >> and their addresses into persistent memory so that it can evaluate the >> addresses on a reboot from a crash. When the persistent memory trace >> starts, it will load the module addresses and names into the persistent >> memory. To do so, it will call the module_for_each_mod() function and pass >> it a function and data structure to get called on each loaded module. Then >> it can record the memory. >> >> This only implements that function. >> >> Cc: Luis Chamberlain >> Cc: Petr Pavlu >> Cc: Sami Tolvanen >> Cc: Daniel Gomez >> Cc: linux-modules@vger.kernel.org >> Signed-off-by: Steven Rostedt (Google) >> --- >> Changes since v2: https://lore.kernel.org/20250215034404.902259250@goodmis.org >> >> - Use RCU guard instead of disabling preemption >> >> include/linux/module.h | 6 ++++++ >> kernel/module/main.c | 13 +++++++++++++ >> 2 files changed, 19 insertions(+) >> >> diff --git a/include/linux/module.h b/include/linux/module.h >> index 30e5b19bafa9..9a71dd2cb11f 100644 >> --- a/include/linux/module.h >> +++ b/include/linux/module.h >> @@ -782,6 +782,8 @@ static inline void *module_writable_address(struct module *mod, void *loc) >> return __module_writable_address(mod, loc); >> } >> >> +void module_for_each_mod(int(*func)(struct module *mod, void *data), void *data); >> + >> #else /* !CONFIG_MODULES... */ >> >> static inline struct module *__module_address(unsigned long addr) >> @@ -894,6 +896,10 @@ static inline void *module_writable_address(struct module *mod, void *loc) >> { >> return loc; >> } >> + >> +static inline void module_for_each_mod(int(*func)(struct module *mod, void *data), void *data) >> +{ >> +} >> #endif /* CONFIG_MODULES */ >> >> #ifdef CONFIG_SYSFS >> diff --git a/kernel/module/main.c b/kernel/module/main.c >> index 1fb9ad289a6f..927a2e0ffd5f 100644 >> --- a/kernel/module/main.c >> +++ b/kernel/module/main.c >> @@ -3809,6 +3809,19 @@ bool is_module_text_address(unsigned long addr) >> return ret; >> } >> >> +void module_for_each_mod(int(*func)(struct module *mod, void *data), void *data) >> +{ >> + struct module *mod; >> + >> + guard(rcu)(); >> + list_for_each_entry_rcu(mod, &modules, list) { >> + if (mod->state == MODULE_STATE_UNFORMED) >> + continue; >> + if (func(mod, data)) >> + break; >> + } >> +} >> + >> /** >> * __module_text_address() - get the module whose code contains an address. >> * @addr: the address. >