From: Florian Fainelli <f.fainelli@gmail.com>
To: Gustav Ekelund <gustav.ekelund@axis.com>,
marek.behun@nic.cz, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: kernel@axis.com, Gustav Ekelund <gustaek@axis.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: dsa: mv88e6xxx: Reset mv88e6393x force WD event bit
Date: Fri, 31 Mar 2023 05:49:57 -0700 [thread overview]
Message-ID: <17c85ba2-10dd-1507-5b90-0233651fc57b@gmail.com> (raw)
In-Reply-To: <20230331084014.1144597-1-gustav.ekelund@axis.com>
On 3/31/2023 1:40 AM, Gustav Ekelund wrote:
> From: Gustav Ekelund <gustaek@axis.com>
>
> The force watchdog event bit is not cleared during SW reset in the
> mv88e6393x switch. This is a different behavior compared to mv886390 which
> clears the force WD event bit as advertised. This causes a force WD event
> to be handled over and over again as the SW reset following the event never
> clears the force WD event bit.
>
> Explicitly clear the watchdog event register to 0 in irq_action when
> handling an event to prevent the switch from sending continuous interrupts.
> Marvell aren't aware of any other stuck bits apart from the force WD
> bit.
>
> Signed-off-by: Gustav Ekelund <gustaek@axis.com>
Would that deserve:
Fixes: de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x
family")
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2023-03-31 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 8:40 Gustav Ekelund
2023-03-31 12:27 ` Andrew Lunn
2023-03-31 12:49 ` Florian Fainelli [this message]
2023-04-02 12:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17c85ba2-10dd-1507-5b90-0233651fc57b@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustaek@axis.com \
--cc=gustav.ekelund@axis.com \
--cc=kernel@axis.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®