From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C66FC07E96 for ; Sun, 4 Jul 2021 13:19:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 698C8613E7 for ; Sun, 4 Jul 2021 13:19:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229636AbhGDNWJ (ORCPT ); Sun, 4 Jul 2021 09:22:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbhGDNWJ (ORCPT ); Sun, 4 Jul 2021 09:22:09 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C479AC061762 for ; Sun, 4 Jul 2021 06:19:33 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id a13so18599321wrf.10 for ; Sun, 04 Jul 2021 06:19:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8We6/ZMfhcjqBC4XSGNcgGBDGD6SExEiR8jKFgdhbUw=; b=Qxw0Pc7fYziCwJPcdZ8j0TvQg9oA4GBJbI6dplAC9w4Bly8wf6glvM2Dt9nkZOPwMT 1Y9ARFKIFPyhLrD88gm6RmANRyX1IMYgEr+jM3Y7nmdgcu4e2MSwrdVe2RSUAfhLcozj KvqkbUmPscDFT03aYk1FUGe8VRw19qNFGUEky2cFTZrfEwvxMd0VTJpPvBzl8W6X/BnS nPGgegQJfuq72ONRRIXzOkp4vh9P5nQVTiXWPJVrnbrJpLvIUCH6T/CFrzr11bLquuex C6t5uENdpWcjhF1Bc/py50gA7qzsuIZicRTkQwsvtIp+IDNFCk32FtCg/jqnFkOvQFia oVng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8We6/ZMfhcjqBC4XSGNcgGBDGD6SExEiR8jKFgdhbUw=; b=daUAsyFdKuov/0qWaDpGGoJkVfSgyjHAt7kgVJnbHVN1ToPb/RG9I6TEPhQ7sdRNdL RSPkOQ+L+aHacwmvjrDnjQoJi0vHa9SXuelMJX6T7VQ/PqiOS3c6ARwvKlYkudfCP5Jd WHSJik956jCsn4VsIXWzcnuyVnXhrbZlMPP9pPeTmW/+kpADWSnLAazze+tN7wH56q8h Il3K91QEwEIeIzhOsN7lNnbJlquAK4MSKBxt1O24kJJSyECXbODg05GppiKS1xaDrwOT xBeBaetSiBgwzT7592/GWD7ehIuXmyfwmKWaPoAlMlNH8vcIDXLEicW66ep99R9EqVeK zB6A== X-Gm-Message-State: AOAM531LdlFZ8/o3AwDl/7imkASoWXsJobWvPP4np3R/pgCHj/bNpz5H MdxPJgjABW9AKLrQIikTH8NvQg== X-Google-Smtp-Source: ABdhPJx5NB8Igzeeg9QU/2kLr5LhLLm4DFq49ZDCTQYCcudMtZIEHeUzF+sUYjHe4ukFKuzFhbcwpQ== X-Received: by 2002:a5d:5606:: with SMTP id l6mr10342019wrv.98.1625404772070; Sun, 04 Jul 2021 06:19:32 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:9c5f:457b:1c8a:d1f6? ([2a01:e34:ed2f:f020:9c5f:457b:1c8a:d1f6]) by smtp.googlemail.com with ESMTPSA id s7sm9771423wrp.97.2021.07.04.06.19.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Jul 2021 06:19:31 -0700 (PDT) Subject: Re: [GIT PULL] thermal for v5.14-rc1 To: Dmitry Osipenko Cc: Zhang Rui , Linux PM mailing list , Linux Kernel Mailing List , Chunyan Zhang , Srinivas Pandruvada , Rajeshwari Ravindra Kamble , Yang Yingliang , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Krzysztof Kozlowski , Ezequiel Garcia , Bjorn Andersson , Andy Shevchenko , Yangtao Li , Finley Xiao , Linus Torvalds References: <7a9ac752-2c1a-b05f-c5bd-9049c0bdd54e@linaro.org> <67ce84e6-f1a5-7796-805d-6482f24b1490@gmail.com> From: Daniel Lezcano Message-ID: <17c8ce98-dc54-d439-95c8-318edb91932c@linaro.org> Date: Sun, 4 Jul 2021 15:19:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/2021 14:04, Dmitry Osipenko wrote: > 04.07.2021 12:51, Daniel Lezcano пишет: >> On 03/07/2021 21:56, Dmitry Osipenko wrote: >>> 03.07.2021 22:34, Linus Torvalds пишет: >>>> On Sat, Jul 3, 2021 at 9:17 AM Daniel Lezcano wrote: >>>>> >>>>> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git >>>>> tags/thermal-v5.14-rc1 >>>> >>>> This does not build for me. And I suspect it never built in linux-next either. >>>> >>>> I get >>>> >>>> ERROR: modpost: "tegra_fuse_readl" >>>> [drivers/thermal/tegra/tegra30-tsensor.ko] undefined! >>>> ERROR: modpost: "tegra_fuse_readl" >>>> [drivers/thermal/tegra/tegra-soctherm.ko] undefined! >>>> make[1]: *** [scripts/Makefile.modpost:150: modules-only.symvers] Error 1 >>>> make[1]: *** Deleting file 'modules-only.symvers' >>>> make: *** [Makefile:1762: modules] Error 2 >>>> >>>> and I think it's due to that commit 1f9c5936b10c >>>> ("thermal/drivers/tegra: Correct compile-testing of drivers") which >>>> quite sensibly tries to extend build coverage for the tegra thermal >>>> drivers, but that build coverage doesn't actually *work* outside the >>>> tegra world. >>>> >>>> That commit says "All Tegra thermal drivers support compile-testing", >>>> but clearly they stumble at the last hurdle. >>>> >>>> I made the decision to just unpull this, not because I couldn't fix >>>> it, but because if it was this untested, I don't want to worry about >>>> all the *other* code in there too. >>> >>> It was tested in linux-next for about two weeks and it was a known >>> problem already [1], sorry again. The compile-testing depends on the >>> patch [2] that should come with the ARM32 PR. The linux-next was okay >>> because [2] got first into -next and I forgot about it. It will be fine >>> to defer these Tegra patches till the next release if this is the >>> easiest solution. >> >> My bad, I did a wrong decision assuming the ARM32 branch would be >> already there when pulling the thermal branch. >> >> I'll remove the patches. >> >> Sorry for the inconvenience. > > Daniel, please let me know if I will need to resend the thermal patches > for 5.15. I'll drop: "thermal/drivers/tegra: Add driver for Tegra30 thermal sensor" "thermal/drivers/tegra: Correct compile-testing of drivers" but keep the bindings. It won't be necessary to resend them. Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog