From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09D5C43B6CB for ; Tue, 18 Aug 2026 08:57:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787043452; cv=none; b=MsmD2qMEvHW0U/1W7o89VKpWsukSPBa190J2r6kiGXp6lwyFUJZVIM7yk+xl/oD3IkKSqf3WpfMGBa8Lzcp9ib4EACX1Nn8GTjHWfGCinbe5yJk+8yfYRAPGfrFoO5/MU8CvKEwVaAQ3E8DK2moiPU0PIRxTUBCPnjuwa1uj6Mk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787043452; c=relaxed/simple; bh=v69QcsW2mOGfUzf1hWEyuWqfUsnkP86q/3Zcf5zRAjk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HANQs9WxyuUPMa1YoY7/tUd/WZk7aOnd850jg7uMRGJryFeInxrR6U2T6ciGoBw4qIlWs+6LRyQmzsPZywXGGHNv2jxca5rqsGiUoG8uL+9zGcF+MY5R/qfC8EPQY30Ts2t8RlPvIBo1Nf8HlRmlQKOBGJiD0AfnW3Jw29gFjiQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h1YXZb/a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Rr8DXtYu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h1YXZb/a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Rr8DXtYu" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67I8BLj2310043 for ; Tue, 18 Aug 2026 08:57:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LWoV3r+YPiscKAy3H5JzA7RjIekZzVMMLL5OXDd1iD0=; b=h1YXZb/apjm+o+yj D6/wwFQ+XyMLCBzqrCPZ89IVFPd0h+hrIPReUhWaX1Y9ILspzdYjczNngWvafd4A jHJ8MQl0iaTXzw4mqPw+LQfgjdr4EaawzIRYNaiEPGf59azu2DG+PIEzWs2xbadP jFiWIxXRm4EsKbaySytz1alkgyPbnS/u79oYPeDDcRnK+fhnHoFeI0nIT2BUXSgB 8t2sC2j+YV7BoKTCwq6YUoAPoO2+HrrDlGTcu1EnEr1d8WNyrXDty1rLmmrNjjb6 LscySl1vtsb1GVd0BzojtT+Ai/eZQfWIRi3UnEZel0Ovrg3wSRQOszTZqdRY8PWn b2TvRQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4fba9bx7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 08:57:29 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-93102454272so3353785a.1 for ; Tue, 18 Aug 2026 01:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787043449; x=1787648249; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LWoV3r+YPiscKAy3H5JzA7RjIekZzVMMLL5OXDd1iD0=; b=Rr8DXtYubw8KGhDyHXleT2bKC6PMethFt4mZyezLWuQ2jkM7Pmrl051N3UKlNweT+p sCLutcZVPxkzGBuQSIAWSLkGlgr1h9bg81m2B+eeXsdlu+QHf1glnr7rnsVpV20TTwPu TFYdg6VT44IqmA2phGQ3Dboz/QGaq3SdSNSKDaerCCITXtJmfNRY1oqAq/KMd37tSiex eJ2IHqVXNjOvFMewHCgrplbBbJXXmzJiVlH2kRPs0cp+lAstYUiHqNPxEWi2fCh/7k1V 1otB0Mq8rHLocgludIjIGywT2LPSYsGhSkvBr5eaaDxO18Tqa794YzUt7/SkpBOBxQLE vtEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787043449; x=1787648249; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LWoV3r+YPiscKAy3H5JzA7RjIekZzVMMLL5OXDd1iD0=; b=XRrQ3lrJdK0PEEBS9A2LdWC/WW92gdVybuIm5LWM2JtiSuB0zMlccoFLkNm/aQZm1L ffxNSQmgP4XMovKuRjL4DdMYJaDuBKMIYLVJCs/Ymu28xZvZoo4dSNf1NSD0RdG8wWXt VQ25/TGt+Yu6ezdFKBRAJcXosn3KV2TNZC6dUBdT17xiCZRWqqrIOl8mPOH9k19Grycy 6402V4aW6uov/TCw6UbMyFFRLsroPxNJtuSil9BSFvIFS570BFN+ygdm1uh3rjMXyivz pV9LVFoKhAZ3o9LFxlFzjuaP5dwtIm9qbWrk+iBn5OC742HPR2JXNHtkzIpYv3i6+5y9 TclQ== X-Forwarded-Encrypted: i=1; AHgh+Rq3oDn+FbW2QRm/sbU7ZxXLvPgGBWUgTYR/DwNuYVY/eVVzLwun8N977uVm9+l3P/WK3qHNhtEuC9jgMkI=@vger.kernel.org X-Gm-Message-State: AOJu0YyACXb3fPz326O9S+31ZRbdYSaRrSskhabIo0vBGJ3raA0n0IJO djoVmuI/Va3r5duegAino6Se88tCWLjcBBnW7eZjyVI/ZGjclg40B85K87/ATrr6yNUwan+3fdw x05Y/eLyaoao1TQojxgbg8S2umV0s4sxwkiTkrws1r506vJkjrH9kzuaRH+KZ7YVfZvg= X-Gm-Gg: AR+sD12I4pqlAU1ZUU/hm2StF8FyE3uQW/yBGDnCClMFXnRY2siT2Z6gcXWgcVIhwuQ 16dmhGtfTqGvbes4puF1Du8aKYVHo6nYj86T9Rn1GduQhf89wGLXvROolrz2yiTdaubtNrl0fve 1/FOxLMyvl4D14Y64jkpSLtNkErH2WFq/WzhhXCXDnBqTrOb1UdYzCUM03tYY1uhwrqPyKjltUq 6UUQfSD+PgSIyjMTS0IMMBkrmdgrwTtXbkqaCZzMBoBn6bV1nfL7cPFzLQCeY/WtE5BInNmZ8lt aSb+SSS4dFXe7BTiAGGbjDbDWY1P91W3yPnuinrmVYCvRo7W/4sc1f1u+2B+k7BdUwwPlpaxGmg mIlEOb4t88ntlb82atPlP1ukc X-Received: by 2002:a05:620a:45a8:b0:92b:7420:bd58 with SMTP id af79cd13be357-936d1ed8aa2mr2213170985a.0.1787043448937; Tue, 18 Aug 2026 01:57:28 -0700 (PDT) X-Received: by 2002:a05:620a:45a8:b0:92b:7420:bd58 with SMTP id af79cd13be357-936d1ed8aa2mr2213169285a.0.1787043448574; Tue, 18 Aug 2026 01:57:28 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2185bc9a35sm117355966b.63.2026.08.18.01.57.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 01:57:27 -0700 (PDT) Message-ID: <17cbf5f8-c23f-4b97-b971-6b6f4f3226c7@oss.qualcomm.com> Date: Tue, 18 Aug 2026 10:57:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/10] phy: qcom-ipq806x-usb: fix the SS PHY TEST_POWERDOWN bit To: Dmitry Baryshkov , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Vinod Koul , Neil Armstrong , Christian Marangi , Andy Gross , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <20260810-msm8974-usb3-v1-0-1a47e1185524@oss.qualcomm.com> <20260810-msm8974-usb3-v1-5-1a47e1185524@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260810-msm8974-usb3-v1-5-1a47e1185524@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDA2NSBTYWx0ZWRfXw+GnUhhYGs7K H8ynpH4o4uv8BAXZ2gHmDH0I5eBTPD00H8Xg/BAeB7SINVii9F3vmazW2aEtp+2a6yfHFso+KGl DdfNpYJyevMR25vS0f7p31otGt41NGM= X-Authority-Analysis: v=2.4 cv=VsITxe2n c=1 sm=1 tr=0 ts=6a841e79 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=zhQxU6SgEyqCUrVtDRsA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: 9Pb08QZiLaTpuPNsJ2CSAfAzd0p2_WbB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDA2NSBTYWx0ZWRfX4lCwsoOzmCVy l7PXp/CweGKNYJogdUMxel3T/JCttS6k9sYhltMwLjUlQIZ7T4wCn34JAFA9pAJhTKa7k7dyDIe G16lTs0kySgfV84r053g+9GBUq81SDcUzhPD1CQVGkTzca1i5VEs3E4DYuv1nuOjy5RPeWd2b2k WrUwpi6He7d1GsvSYKxlHIpEFjohAGTF+PrFm3cWj5+8PATLoAOCAkuoEg8afz0glfxWPkpTde1 MYHk5yHIA8tFyWiN5ii3fK3ryNOW6o9sJZd1YaDip5RshVtV7Gh3z+vfQz3CggwVt+P2AqIz0qP +V2XJvC2jxjRTuAMx7bOvaVwjbSKpjUr9zBVES21GIGcbhQoqR6tsUY0dQUy0QVNW8iAuorA0FS 0O+HLWedUyzpSJtMWadZ2xBIcZMyeRiaezfdA30fXGS/u1eH/LyARLDXYGdicSrI3p3cte+XTI4 tKVhntpzGq9XQC3T9HA== X-Proofpoint-GUID: 9Pb08QZiLaTpuPNsJ2CSAfAzd0p2_WbB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-17_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 bulkscore=0 priorityscore=1501 phishscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180065 On 8/10/26 1:42 PM, Dmitry Baryshkov wrote: > The SS PHY exit sequence tries to put the PHY into retention via the > TEST_POWERDOWN bit of SS_PHY_CTRL, but defines that bit as BIT(27). In > the DWC3 QSCRATCH SS_PHY_CTRL register TEST_POWERDOWN is bit 26 (see > the downstream phy-msm-ssusb driver for the same IP generation), so the > sequence pokes an unrelated bit and the PHY is never powered down. > > Fixes: ef19b117b834 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver") > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad