From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B9ED2494D8 for ; Mon, 15 Jun 2026 10:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781518612; cv=none; b=IGtVixFM3S9ruKKr3zETgD6Q2f9gFGBbE/n/OLVNNnKg/+6m5wvvRssyPzNvnJXD+12Is/KYuPx1XUvyMa58LURhNDn6h8QIzehBgaXQ5mGVV/G1xypiZaJr9nRNRILGYk9r+cvdsItLgAp4ZBtgB3W4twzr9RUfCBWAvPFrN/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781518612; c=relaxed/simple; bh=J6jw2gD59Ld7q2bvU18HM97gQw5AXDZhUGG6q0uF7UM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Qu/FsPB7n05/lwsb4yGjPVicCfrya4HcLrC3VhZ6cGJ4+olaRkrVwZFzhllLMVDSv+4+jdhsNyhWE+7lgvWJTjiedCRycH3GhYg6G1jXYSv5gnWyCnFK9qPUjwHRDe8HNhtBaII7m5aRGyF8UN++DAt+8nm4SQzCOCyKitZFUmw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bfXF4QFS; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=fXUOq4Tv; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bfXF4QFS"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="fXUOq4Tv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781518610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ifgmHngHlOW81FXrm/XhNVyLDbeBXyD2thQTAQr71UQ=; b=bfXF4QFSlbQGo/UfoSSbGin2ZlbsC/czJ7Kv0eJzYvn0Bz/YVP91g6EhJVe8aDjfjMDPNB XBVD+6gx1FSZu/z0w5cgercZUvPzOCIf8R2cfbpDMHQAxgRfXA3JB4DMrsDeudZ4DmG1/E sD3z4HbAbkaCVcQgG61Aiffb7vlf87w= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-r6oOVZGUO8Sv8S5pDh8lQA-1; Mon, 15 Jun 2026 06:16:49 -0400 X-MC-Unique: r6oOVZGUO8Sv8S5pDh8lQA-1 X-Mimecast-MFC-AGG-ID: r6oOVZGUO8Sv8S5pDh8lQA_1781518608 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-490ae3bcf4cso15263085e9.3 for ; Mon, 15 Jun 2026 03:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781518608; x=1782123408; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ifgmHngHlOW81FXrm/XhNVyLDbeBXyD2thQTAQr71UQ=; b=fXUOq4TvmRgJjeXQr/pNyEBqWPx5sAV1PAYbYmqrfgjxTNJ9miDoi2J/Oq49tIBpHM SxVR6plWbiSA0VBJhif8kpP4pIgaTOEgv/l0wpMfbjFfL9y7P/rRx00J/ncUG1rXR3nJ nkFbq+WSh7Iu+f1WX6jP3d02Yi0r7qb8Jfs6bAMs8yPPPryYJhgQKq7bEp2VGu9ntqgK a0T+/UkA5ICz2hHJFK3fZsRLkyY5QWxLPe/E5UyidfV7W8/H8eNCfjFiTJ4mQYnhKpFE XckN7hGIFdi7ndhTJH4P7bpe89Or3x7sVSAL+tTRzRD/5QfqClmRNbdrDbDdZgDciyrV z/Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781518608; x=1782123408; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ifgmHngHlOW81FXrm/XhNVyLDbeBXyD2thQTAQr71UQ=; b=l+nI8BnSfyFhzf3JFlCLUh16uRVhazR/GHWiS2+w2Cw1kw+QUAV/RLfu3cQ1nz34oc 0rUIwyJXSarTrpPgYEx20ENJ0BCRTGRzr2qpSngqg84ox59RVLvfqYpre8xw0eARry6v 99pIrPptiughd7s8FRTQuAutFbLgaxE1+j74rIjfBFeUrDkfNV7p3VuvgUQRq+SPaztx 4tD6qJ1HsBVSbdWMiG962a2BfTu1iqAU6yb0sXS8Dx/F5oMyrTGfzDJXDJqAguOkyGyY WXSQVw7WvZvW5IfDg6/QictmluwOaCdRe0nJt2zOV2vhpJDT4OVSBvUpEu0E8zCBNURU RyzQ== X-Forwarded-Encrypted: i=1; AFNElJ8KIFEjUEV6/x1Wz+FUX7WQXpPjcxkOAi4CpS1fR8JLJ02QMJM0quWXiM4n8+6YOWrKOnCgOzoBM1V3OG0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2T8o2VieCUwbPCkoNe3BiHDbqe67C/kQarCuvvc44vOhzyryh sWp73YsM2j5YPj8EAJ4sb2ad8C8JIQsfnECFV+XgSC7ZBnsoBpwxsEj42s5msFoAhAInTY7Qv2n 2IdXwJf2edJ/6+ue9DK8mYrmX1dySctoAFQ4f3rVy+ldinKbKpoPh0CzkbhntrkwpJ8gVVuxo1Q == X-Gm-Gg: Acq92OE5jXdsWJ9kKWjW6CbANrZ+pnANWT2H7YGsWdaBm+vM6pYMEp+tPQDBjDHsM9h wSL1tfdmEb1w9QysmIBqKtVwTidXrWkBcxZ9yI5l0uws1ph06COCo4hWqNnAAWHd/Xm5gZpTxb+ lP86+bOSQ1PQsyn+HYu/SJrKhHsZoaoqFJQ1nrJzuKKvRvUfFtDT0WnuDCEQ2iKRr28G0QNcXWm pe6pe6C8reDVoit+9HRAW9gbiWU41MnjzMZWZub6DrH1TvNsgl4nk80xRCi4iTpd0kU7bEkVHrx 8SKvNhwZbe5LJFdvNfQaeLbOLNkrSjO8L6HlgC7Q6sD4Hn6euBVWB6KOtlDvLr9UcTxe5d3X6Qg Smig1B/qtECoQxzXt3Tfw895qGg== X-Received: by 2002:a05:600c:4ed0:b0:490:5e2a:f924 with SMTP id 5b1f17b1804b1-4922008485fmr124792435e9.7.1781518607651; Mon, 15 Jun 2026 03:16:47 -0700 (PDT) X-Received: by 2002:a05:600c:4ed0:b0:490:5e2a:f924 with SMTP id 5b1f17b1804b1-4922008485fmr124791905e9.7.1781518606960; Mon, 15 Jun 2026 03:16:46 -0700 (PDT) Received: from [192.168.1.167] ([185.168.96.228]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f2cf5d9sm29193483f8f.32.2026.06.15.03.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 03:16:45 -0700 (PDT) Message-ID: <17cc39477d7150de668a20ccb71044dc5708695e.camel@redhat.com> Subject: Re: [PATCH v3 5/9] rv/ha: make da_monitor_reset_hook and EVENT_NONE_LBL overridable From: Gabriele Monaco To: wen.yang@linux.dev Cc: Steven Rostedt , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 15 Jun 2026 12:16:43 +0200 In-Reply-To: <13a25b73c9fdebd26c2d4f922a83408dbcfc214d.1780847473.git.wen.yang@linux.dev> References: <13a25b73c9fdebd26c2d4f922a83408dbcfc214d.1780847473.git.wen.yang@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-06-08 at 00:13 +0800, wen.yang@linux.dev wrote: > From: Wen Yang >=20 > Wrap the two definitions with #ifndef guards so that HA-based > monitors > can substitute their own implementations before including this > header: >=20 > =C2=A0 /* in monitor.c, before #include */ > =C2=A0 #define da_monitor_reset_hook=C2=A0 my_monitor_reset_env > =C2=A0 #define EVENT_NONE_LBL=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 "idle" >=20 > No behaviour change for monitors that do not override either macro. >=20 > Signed-off-by: Wen Yang > --- > =C2=A0include/rv/ha_monitor.h | 5 +++++ > =C2=A01 file changed, 5 insertions(+) >=20 > diff --git a/include/rv/ha_monitor.h b/include/rv/ha_monitor.h > index e5860900a337..610da54c111f 100644 > --- a/include/rv/ha_monitor.h > +++ b/include/rv/ha_monitor.h > @@ -36,7 +36,10 @@ static bool ha_monitor_handle_constraint(struct > da_monitor *da_mon, > =C2=A0 da_id_type id); > =C2=A0#define da_monitor_event_hook ha_monitor_handle_constraint > =C2=A0#define da_monitor_init_hook ha_monitor_init_env > +/* Allow monitors to override da_monitor_reset_hook before including > this header. */ Just a nit: users can do that but shouldn't do it mindlessly, so let's add a line like: "Make sure you still call ha_monitor_reset_env() or reset timers otherwise." Other than that looks good Reviewed-by: Gabriele Monaco Thanks, Gabriele > +#ifndef da_monitor_reset_hook > =C2=A0#define da_monitor_reset_hook ha_monitor_reset_env > +#endif > =C2=A0#define da_monitor_sync_hook() synchronize_rcu() > =C2=A0 > =C2=A0#if !defined(HA_SKIP_AUTO_CLEANUP) && RV_MON_TYPE =3D=3D RV_MON_PER= _TASK > @@ -75,7 +78,9 @@ _Static_assert(offsetof(struct ha_monitor, da_mon) > =3D=3D 0, > =C2=A0#define ENV_INVALID_VALUE U64_MAX > =C2=A0/* Error with no event occurs only on timeouts */ > =C2=A0#define EVENT_NONE EVENT_MAX > +#ifndef EVENT_NONE_LBL > =C2=A0#define EVENT_NONE_LBL "none" > +#endif > =C2=A0#define ENV_BUFFER_SIZE 64 > =C2=A0 > =C2=A0#ifdef CONFIG_RV_REACTORS