From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752378AbeA0JyQ (ORCPT ); Sat, 27 Jan 2018 04:54:16 -0500 Received: from mout.web.de ([212.227.17.12]:54300 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbeA0JyN (ORCPT ); Sat, 27 Jan 2018 04:54:13 -0500 Subject: [PATCH 1/2] Input: nspire-keypad: Delete an error message for a failed memory allocation in nspire_keypad_probe() From: SF Markus Elfring To: linux-input@vger.kernel.org, Daniel Tang , Dmitry Torokhov Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <17d03396-2abe-4e09-1a86-14773b51073b@users.sourceforge.net> Date: Sat, 27 Jan 2018 10:54:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:4D2/FKCpXxTKt0lueya9eJX9se1DiQJZ+TQB+uQBUXomMSkCq/+ YGujuv4lVLnk7/NpLg3LXwP5DGKHNssOgxNczXtwCkWunptmjmLUKqv7uDphRymySt/XKiZ JuMXlglMOikYzbHrZzjvDHN3s7q3N6LA9W7OX+cCbzhHVsTpPxab4isDAPWTjEYiM3elIi0 mMVXCIXgxVf6p0W3WH/GQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:v2Oo/U0atUA=:a+qGQqr8v+5nmRubn6fF17 GGtLzn2QDwFtE3MGt3q8IetwZ3bpRdGplmrwLnSVaC5XcI/ywS9K6pVtpJ0T9fsdVeJvxptwq nX+vsLO+0ysieYxqH4V/8/A/i7in+2Jy3xI5XAmPmtUK6ib99mz3daPd595xAQ6936vOgy0TF vSSe6f4Ojy4ltpZPwn6Qq5Es70geLlWo+r2Rpi6gCO5ScDp2FqVLuKt1AxczJbvlhepOSaIn4 qoKqk+DXY0/Er2IYE8a7evItxsoIIVnnZsIH7yb5aMove02L8ET4xzcljHD3mbZF9KMfbINul qKDZZsQPb1m4fTwgHl2DvZQAM0XWhSaqK7w6llHyUj4+C2z6aRGxGySGGeG6blEowWLibJkLo ZQOT5HII2aSCNmyqxT/HkYcQLZ9KzTb0ouM1Bh8TUrLe58JivO1Ph9yIlNazbL6NLReGujOG9 sUKigHbRrVZHf+8xT6ZJ8vR23Xr+tW3x1EMiEDorXsc5bcXOhElYY41tXyZ95Z6vYrFE2vjr4 LGm0DaYHDnaIBlkbKoz/pTlQTd/NPQv1gMY2M1NpLernmqRSXjDpMyK1mbkRM+KSosGlQjz2X RvgcqoumXhulR3LNPCVerPefubIVqa95K6MSNQgd+iLFYmXeNmJwJR0LB8Rs/pzTquH/qCOOh uUiK0BTJKgrBFdlHTHo2O9TTnJfe1/hbp+6BSftMqeVZlx4feD51N17q4lu9WwlQ2iiFU1PZt nRh9KPKIQHkEAf7JjToH/JbfVC6qxQ4aKAUn/4sOiiQ2Yf28Flay6i8HnpB+zirDRWeUKbaDV CuNtV0UFYEvv84Ce9VnuaAbizixscHqsgSuw4tkrcNNPLmYKGM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 27 Jan 2018 10:33:37 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/nspire-keypad.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/input/keyboard/nspire-keypad.c b/drivers/input/keyboard/nspire-keypad.c index c7f26fa3034c..f13b50213f94 100644 --- a/drivers/input/keyboard/nspire-keypad.c +++ b/drivers/input/keyboard/nspire-keypad.c @@ -175,10 +175,8 @@ static int nspire_keypad_probe(struct platform_device *pdev) keypad = devm_kzalloc(&pdev->dev, sizeof(struct nspire_keypad), GFP_KERNEL); - if (!keypad) { - dev_err(&pdev->dev, "failed to allocate keypad memory\n"); + if (!keypad) return -ENOMEM; - } keypad->row_shift = get_count_order(KEYPAD_BITMASK_COLS); -- 2.16.1