From: "CK Hu (胡俊光)" <ck.hu@mediatek.com>
To: "oushixiong1025@163.com" <oushixiong1025@163.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>
Cc: "simona@ffwll.ch" <simona@ffwll.ch>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"airlied@gmail.com" <airlied@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"oushixiong@kylinos.cn" <oushixiong@kylinos.cn>
Subject: Re: [PATCH] drm/mediatek: Convert to use devm_platform_ioremap_resource
Date: Fri, 7 Feb 2025 02:26:41 +0000 [thread overview]
Message-ID: <17d991fd6b45b11f215d976bd702251ceb994bcf.camel@mediatek.com> (raw)
In-Reply-To: <20250128094118.1526-1-oushixiong1025@163.com>
Hi, Shixiong:
On Tue, 2025-01-28 at 17:41 +0800, oushixiong1025@163.com wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
>
>
> From: Shixiong Ou <oushixiong@kylinos.cn>
>
> Do not need to get resource, so convert to use
> devm_platform_ioremap_resource.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
> ---
> drivers/gpu/drm/mediatek/mtk_padding.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_padding.c b/drivers/gpu/drm/mediatek/mtk_padding.c
> index b4e3e5a3428b..7e302724e74a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_padding.c
> +++ b/drivers/gpu/drm/mediatek/mtk_padding.c
> @@ -95,7 +95,6 @@ static int mtk_padding_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct mtk_padding *priv;
> - struct resource *res;
> int ret;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> @@ -107,7 +106,7 @@ static int mtk_padding_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(priv->clk),
> "failed to get clk\n");
>
> - priv->reg = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> + priv->reg = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->reg))
> return dev_err_probe(dev, PTR_ERR(priv->reg),
> "failed to do ioremap\n");
> --
> 2.43.0
>
>
prev parent reply other threads:[~2025-02-07 2:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 9:41 oushixiong1025
2025-02-07 2:26 ` CK Hu (胡俊光) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17d991fd6b45b11f215d976bd702251ceb994bcf.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=oushixiong1025@163.com \
--cc=oushixiong@kylinos.cn \
--cc=p.zabel@pengutronix.de \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®