mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Li Ming <ming.li@zohomail.com>,
	dave@stgolabs.net, jic23@kernel.org, alison.schofield@intel.com,
	vishal.l.verma@intel.com, djbw@kernel.org, iweiny@kernel.org,
	icheng@nvidia.com
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] cxl/mbox: Return success for CXL_MBOX_CMD_RC_BACKGROUND
Date: Tue, 17 Nov 2026 09:31:17 -0700	[thread overview]
Message-ID: <17dbc525-b3b0-4285-8062-fecf70658e0d@intel.com> (raw)
In-Reply-To: <20261116070938.3675205-1-ming.li@zohomail.com>



On 11/16/26 12:09 AM, Li Ming wrote:
> In CXL subsystem, each mbox command hw return code is mapped to a
> corresponding errno value. Currently, CXL_MBOX_CMD_RC_BACKGROUND is
> mapped to -ENXIO.
> 
> However, per Table-8-208 in CXL r4.0 section 8.2.9.4.5.1, a BACKGROUND
> HW return code indicates that the command has been accepted by the
> device and continues execution asynchronously. It does not indicate a
> command failure.
> 
> Return 0 instead of -ENXIO for CXL_MBOX_CMD_RC_BACKGROUND so that
> callers do not treat a successfully started background operation as an
> error.
> 
> Signed-off-by: Li Ming <ming.li@zohomail.com>
> Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>

Applied to cxl/next:
d9b7b42f7bb8

> ---
> v3:
> - Drop fixes tag.
> - Collect review tag.
> v2:
> - Add a reference to the relevant spec section in the commit log.
> ---
>  drivers/cxl/cxlmem.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
> index c401e3a1af06..cc71d7a84cdc 100644
> --- a/drivers/cxl/cxlmem.h
> +++ b/drivers/cxl/cxlmem.h
> @@ -160,7 +160,7 @@ static inline struct cxl_ep *cxl_ep_load(struct cxl_port *port,
>   */
>  #define CMD_CMD_RC_TABLE							\
>  	C(SUCCESS, 0, NULL),							\
> -	C(BACKGROUND, -ENXIO, "background cmd started successfully"),           \
> +	C(BACKGROUND, 0, "background cmd started successfully"),		\
>  	C(INPUT, -ENXIO, "cmd input was invalid"),				\
>  	C(UNSUPPORTED, -ENXIO, "cmd is not supported"),				\
>  	C(INTERNAL, -ENXIO, "internal device error"),				\


      parent reply	other threads:[~2026-11-17 16:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  7:09 Li Ming
2026-11-16  7:09 ` [PATCH v3 2/2] cxl/mbox: Use mapped errno to determine command status Li Ming
2026-11-17  1:18   ` Jonathan Cameron
2026-11-17 16:31   ` Dave Jiang
2026-11-17  1:16 ` [PATCH v3 1/2] cxl/mbox: Return success for CXL_MBOX_CMD_RC_BACKGROUND Jonathan Cameron
2026-11-17 16:31 ` Dave Jiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17dbc525-b3b0-4285-8062-fecf70658e0d@intel.com \
    --to=dave.jiang@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=dave@stgolabs.net \
    --cc=djbw@kernel.org \
    --cc=icheng@nvidia.com \
    --cc=iweiny@kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®