From: Rohit Agarwal <quic_rohiagar@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
<andersson@kernel.org>, <lee@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<linus.walleij@linaro.org>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <sboyd@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 02/10] dt-bindings: power: Add rpm power domains for SDX75
Date: Wed, 5 Jul 2023 16:50:21 +0530 [thread overview]
Message-ID: <17dc53d0-2f30-1d54-ccbe-d829a681ad06@quicinc.com> (raw)
In-Reply-To: <553bd028-aaf3-b128-ae4c-7f938c23e889@linaro.org>
On 7/5/2023 4:13 PM, Konrad Dybcio wrote:
> On 5.07.2023 10:54, Rohit Agarwal wrote:
>> On 7/4/2023 11:47 AM, Rohit Agarwal wrote:
>>> On 7/3/2023 8:29 PM, Konrad Dybcio wrote:
>>>> On 3.07.2023 16:42, Rohit Agarwal wrote:
>>>>> Add RPM power domain bindings for the SDX75 SoC.
>>>>>
>>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>>> ---
>>>>> Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
>>>>> include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++
>>>>> 2 files changed, 9 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>>>> index afad313..58e1be8 100644
>>>>> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>>>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>>>> @@ -40,6 +40,7 @@ properties:
>>>>> - qcom,sdm845-rpmhpd
>>>>> - qcom,sdx55-rpmhpd
>>>>> - qcom,sdx65-rpmhpd
>>>>> + - qcom,sdx75-rpmhpd
>>>>> - qcom,sm6115-rpmpd
>>>>> - qcom,sm6125-rpmpd
>>>>> - qcom,sm6350-rpmhpd
>>>>> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
>>>>> index 1bf8e87..8092d0d 100644
>>>>> --- a/include/dt-bindings/power/qcom-rpmpd.h
>>>>> +++ b/include/dt-bindings/power/qcom-rpmpd.h
>>>>> @@ -57,6 +57,14 @@
>>>>> #define SDX65_CX_AO 4
>>>>> #define SDX65_MXC 5
>>>>> +/* SDX75 Power Domain Indexes */
>>>>> +#define SDX75_CX 0
>>>>> +#define SDX75_CX_AO 1
>>>>> +#define SDX75_MSS 2
>>>>> +#define SDX75_MX 3
>>>>> +#define SDX75_MX_AO 4
>>>>> +#define SDX75_MXC 5
>>>> Please instead introduce a set of defines without the SoC prefix
>>>> (i.e. CX, CX_AO, MX etc.). We've been putting this off for too long
>>>> and you're the first unlucky guy that submitted new RPMhPD support after
>>>> we've concluded it'd be the way to go! :D Sadly, we can't replace the
>>>> existing ones retroactively..
>>> Surely No issues. Will update it.
>> I have a doubt here. Cant we completely omit the #defines here and directly index this as 0,1,...
>> because if the intention of this #defines is to understand the name of the pd then we can get
>> it from the .name attribute in rpmhpd as well, right?
>>
>> The problems with a common set of #define would be, lets say if we define CX_AO as 1 and some platform
>> doesn't have CX_AO then wouldnt it leave a null entry in the driver entry of that platform?
> Yes.
>
> We already do this in the rpmh clock driver, as:
>
> 1. there are domains that all chips share (like CX etc.)
> 2. wasting a couple of bytes lets us massively save on convolution
Ok, got it. Looks cleaner.
Thanks,
Rohit.
>
> Konrad
>> Thanks,
>> Rohit.
>>
>>> Thanks,
>>> Rohit.
>>>> Konrad
>>>>> +
>>>>> /* SM6350 Power Domain Indexes */
>>>>> #define SM6350_CX 0
>>>>> #define SM6350_GFX 1
next prev parent reply other threads:[~2023-07-05 11:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 14:42 [PATCH 00/10] Add Power Domains and Regulators in SDX75 Rohit Agarwal
2023-07-03 14:42 ` [PATCH 01/10] dt-bindings: regulator: Add PMX75 compatibles Rohit Agarwal
2023-07-04 6:21 ` Krzysztof Kozlowski
2023-07-04 6:45 ` Rohit Agarwal
2023-07-03 14:42 ` [PATCH 02/10] dt-bindings: power: Add rpm power domains for SDX75 Rohit Agarwal
2023-07-03 14:59 ` Konrad Dybcio
2023-07-04 6:17 ` Rohit Agarwal
2023-07-05 8:54 ` Rohit Agarwal
2023-07-05 10:43 ` Konrad Dybcio
2023-07-05 11:20 ` Rohit Agarwal [this message]
2023-07-03 14:42 ` [PATCH 03/10] dt-bindings: mfd: Add compatible for pm7550ba Rohit Agarwal
2023-07-04 6:24 ` Krzysztof Kozlowski
2023-07-13 13:31 ` Lee Jones
2023-07-03 14:42 ` [PATCH 04/10] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support Rohit Agarwal
2023-07-04 6:24 ` Krzysztof Kozlowski
2023-07-04 6:48 ` Rohit Agarwal
2023-07-03 14:42 ` [PATCH 05/10] dt-bindings: mfd: Add compatible for pmx75 Rohit Agarwal
2023-07-04 6:24 ` Krzysztof Kozlowski
2023-07-13 13:31 ` Lee Jones
2023-07-03 14:42 ` [PATCH 06/10] dt-bindings: pinctrl: qcom-pmic-gpio: Add pmx75 support Rohit Agarwal
2023-07-04 6:25 ` Krzysztof Kozlowski
2023-07-03 14:42 ` [PATCH 07/10] soc: qcom: rpmhpd: Add SDX75 power domains Rohit Agarwal
2023-07-03 14:42 ` [PATCH 08/10] regulator: qcom-rpmh: Add support for SDX75 Rohit Agarwal
2023-07-03 14:42 ` [PATCH 09/10] pinctrl: qcom-pmic-gpio: Add support for pm7550ba Rohit Agarwal
2023-07-03 14:42 ` [PATCH 10/10] pinctrl: qcom-pmic-gpio: Add support for pmx75 Rohit Agarwal
2023-07-03 15:27 ` [PATCH 00/10] Add Power Domains and Regulators in SDX75 Bjorn Andersson
2023-07-04 6:16 ` Rohit Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17dc53d0-2f30-1d54-ccbe-d829a681ad06@quicinc.com \
--to=quic_rohiagar@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®