From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Simon Horman <horms@kernel.org>
Cc: Lino Sanfilippo <LinoSanfilippo@gmx.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Yang Ruibin <11162571@vivo.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: alacritech: Partially revert "net: alacritech: Switch to use dev_err_probe()"
Date: Mon, 2 Sep 2024 18:24:30 +0200 [thread overview]
Message-ID: <17dcf3ed-a686-4991-895e-5d684a011d62@linaro.org> (raw)
In-Reply-To: <20240830182844.GE1368797@kernel.org>
On 30/08/2024 20:28, Simon Horman wrote:
> On Fri, Aug 30, 2024 at 07:00:14PM +0200, Krzysztof Kozlowski wrote:
>> This reverts commit bf4d87f884fe8a4b6b61fe4d0e05f293d08df61c because it
>> introduced dev_err_probe() in non-probe path, which is not desired.
>> Calling it after successful probe, dev_err_probe() will set deferred
>> status on the device already probed. See also documentation of
>> dev_err_probe().
>
> I agree that using dev_err_probe() outside of a probe path is
> inappropriate. And I agree that your patch addresses that problem
> in the context of changes made by the cited commit.
>
> But, based on my reading of dev_err_probe(), I think the text above is
> slightly misleading. This is because deferred status is only set in the
> case where the err passed to dev_err_probe() is -EPROBE_DEFER. And I do
That's true and indeed request_firmware() will not return EPROBE_DEFER.
I'll update commit msg.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-09-02 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 17:00 Krzysztof Kozlowski
2024-08-30 18:28 ` Simon Horman
2024-08-30 20:34 ` Andrew Lunn
2024-08-30 21:32 ` Keller, Jacob E
2024-09-02 16:24 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17dcf3ed-a686-4991-895e-5d684a011d62@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=11162571@vivo.com \
--cc=LinoSanfilippo@gmx.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®