From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 252C01EE00A for ; Wed, 25 Mar 2026 13:50:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774446634; cv=none; b=KmkGhlA7CJA/BasHtNbIno8bG2CBKNXPWCKfGELtAc9T1zfkALnfSq2vjypNasA9bbrB/az3iCWk8Ahe9aR3jtyqoruINbwCA8NcK7hIGXevjYGa8+z0EW+JjGHtUz6tx1dIoxpZJBkBwSdAD3hpyp/jrfkeM4rOAEES6JGJ2OI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774446634; c=relaxed/simple; bh=HTaVQB/gVmY1BnuQ4skhOXswz3t1IT5DcnOYFy2XCNY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Hz4HJfq7ZE3P+MjHFcF/TTYlkYaVnrSuzmofnUjLRw0e5DLgKbR1usm4G77PKz3lqF11RgOcTsK7NII9ngmgvXED8L4+YwFsqafYwVZEIY/9KPm6lWYauCkQYLQwjLhQSisEVuAmp7MWJzsp4C/9Hx3JByX7+kI+TdvPqgXvW6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vt8VVJ2S; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vt8VVJ2S" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2c0c955a481so692755eec.1 for ; Wed, 25 Mar 2026 06:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774446632; x=1775051432; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=FmHLauN66hsGQq9eeDWWkMFkqMbTeB12/YKZ/mFq+70=; b=Vt8VVJ2SZnTRf2kRa5OPDCYCLob5vvmBU8kqtg/NLf2W8jx8v7x2UX/O4vTRxnOQxJ Vk+YVi4PoNli2BrqQhUWThwC66kXPWIrob2PiGUfEGQuQqxsd1z3h4qB1QBQzfYD1P8W G2z1G4WZ9bvNNP9c25I0Q6g9cq6C7EKw99D1ISm9nP6t+yrYRyK9A4qKpe76R6SzYt6x S6aIJNuSjzHfJGfkQQ/nhQ0A2T9T1PNhdfDdyVf2hk48QHctubaJaIC4mBlybK51yzQw Bfpw0sQK92o6vMz8ZkHjvkFlz5LI4OlpgU7AmSHbb2tC/nzmGkGSklt37TvEIvwZAp4C uJHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774446632; x=1775051432; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FmHLauN66hsGQq9eeDWWkMFkqMbTeB12/YKZ/mFq+70=; b=eSHopKGInE6PCr67OxBbKxtEJeWLNPMnp/gjg6BZAd2lfAp1q/4YKkTTJEUbSOOWop LERzBj4aM/Q04KjKfn3N083910WSZBdqwuRxbfjvMAvpa+dvT2jMDGpL1lW15b+/sY3Y /wiIUHODJ4nATkK72xp7XZ5hileDdr6t26nBfdA7MxK75xe6KZP1ojVeu8x29LZhh13O 2TKLHmw/XCLMKphfgG3RoiWFYlPADVvKz+sIydsWuz4anKz04SJO4XyhGwy42J+p08lx jaGATR+n5S19ZDqiFS5b1mxRtUNEW7XBOnf+Kizr19pgtZdjA/LP8QrGAXqQ/EieZiwK HGow== X-Forwarded-Encrypted: i=1; AJvYcCXgWchqrCnXno3vP3KBZK5ab9frIEt3gAJRpYaPGDJRBkBcRdhL/4X/Zg7uqk+8eCsvm5LQJsST86Z3RLU=@vger.kernel.org X-Gm-Message-State: AOJu0YwVwG4ui7VQBYuKNsk2K9nhkIx/xz4ilgXVykDVG2DNQcN7T+h/ w122bvlpQwS83drByRdDjRShlN4iYIBsBwplUARRIK6ocayBHhUpW69DX2QGkA== X-Gm-Gg: ATEYQzzvBesFQ3T2L/zRHus5MSNDa9TCAyCG20qJgJy1LtIPARLkyFYHjjqBtJPm8AF zNSnMEB8EDZCmObdi4MXKY5Sp6406M3pZVrSGxN0zJXhdkedE9jh6KYOby9gjMaTPSgfQWK7d1S obZQ1p6ePCt99ZIXzm5G/n9x5QOV5WuriyPrsJWroWSw73vUZHcJrKeyXzOTfcouUNPHTnfnCHB 35CRrBIaczzxOf40dVSzRMbyaHU7zqbM82TKWE8d/pNwoo8+LWZBYZ2e3OFLpVer0qSgVQKsO1N g2c+oXxKUjmNUMqHCJmbqb4KXCJQ1y6N0DiQJl916Ivv5er5uRYmxscAP8UYS9HWj2IrjzOcMQM B3OALxtB6wjvayi/FbJy/iFBOlITcV4n0aofxLrxufP+p11mFMfHveyuY3UuJW3f4J0CaCwB+Fv av7YRbgfXI/YvpbjxwZ/OwYShF36040s0BlICi X-Received: by 2002:a05:7301:4305:b0:2c1:6cfd:73f3 with SMTP id 5a478bee46e88-2c16cfd7cc4mr42953eec.27.1774446631921; Wed, 25 Mar 2026 06:50:31 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b29d28csm22524692eec.19.2026.03.25.06.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 06:50:31 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 25 Mar 2026 06:50:30 -0700 From: Guenter Roeck To: "Pradhan, Sanman" Cc: "linux-hwmon@vger.kernel.org" , "Michael.Hennerich@analog.com" , "linux-kernel@vger.kernel.org" , Sanman Pradhan Subject: Re: [PATCH v2] hwmon: (adm1177) fix sysfs ABI violation and current unit conversion Message-ID: <17dd13aa-ad37-4c6f-bbf1-322202037031@roeck-us.net> References: <20260325051246.28262-1-sanman.pradhan@hpe.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260325051246.28262-1-sanman.pradhan@hpe.com> On Wed, Mar 25, 2026 at 05:13:06AM +0000, Pradhan, Sanman wrote: > From: Sanman Pradhan > > The adm1177 driver exposes the current alert threshold through > hwmon_curr_max_alarm. This violates the hwmon sysfs ABI, where > *_alarm attributes are read-only status flags and writable thresholds > must use currN_max. > > The driver also stores the threshold internally in microamps, while > currN_max is defined in milliamps. Convert the threshold accordingly > on both the read and write paths. > > Widen the cached threshold and related calculations to 64 bits so > that small shunt resistor values do not cause truncation or overflow. > Also use 64-bit arithmetic for the mA/uA conversions, clamp writes > to the range the hardware can represent, and propagate failures from > adm1177_write_alert_thr() instead of silently ignoring them. > > Update the hwmon documentation to reflect the attribute rename and > the correct units returned by the driver. > > Fixes: 09b08ac9e8d5 ("hwmon: (adm1177) Add ADM1177 Hot Swap Controller and Digital Power Monitor driver") > Signed-off-by: Sanman Pradhan > Acked-by: Nuno Sá Applied. Thanks, Guenter