From: Markus Elfring <Markus.Elfring@web.de>
To: Yanze Zhang <zhang.yanze@zte.com.cn>,
linux-rdma@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
Julian Braha <julianbraha@gmail.com>,
Junxian Huang <huangjunxian6@hisilicon.com>,
Leon Romanovsky <leon@kernel.org>,
Zhu Yanjun <yanjun.zhu@linux.dev>
Cc: lkp@intel.com, LKML <linux-kernel@vger.kernel.org>,
Chengfei Han <han.chengfei@zte.com.cn>,
Junyang Han <han.junyang@zte.com.cn>,
Ming Ran <ran.ming@zte.com.cn>, Quan Wei <wei.quan@zte.com.cn>
Subject: Re: [PATCH v6? 3/7] RDMA/zrdma: Add internal headers and hardware register definitions
Date: Sat, 24 Oct 2026 10:43:58 +0200 [thread overview]
Message-ID: <17e2204c-b16a-43f4-bf13-9e897d611736@web.de> (raw)
In-Reply-To: <20261024071539.2182864-4-zhang.yanze@zte.com.cn>
Please specify version identifications in a consistent way.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3#n711
https://lore.kernel.org/linux-rdma/20261024071539.2182864-1-zhang.yanze@zte.com.cn/
…
> +++ b/drivers/infiniband/hw/zrdma/zrdma_main.h
> @@ -0,0 +1,216 @@
…
> +static inline void zxdh_free_rsrc(struct zxdh_pci_f *rf,
> + unsigned long *rsrc_array, u32 rsrc_num)
> +{
> + unsigned long flags;
> +
> + spin_lock_irqsave(&rf->rsrc_lock, flags);
> + __clear_bit(rsrc_num, rsrc_array);
> + spin_unlock_irqrestore(&rf->rsrc_lock, flags);
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&rf->rsrc_lock);”?
https://elixir.bootlin.com/linux/v7.3/source/include/linux/spinlock.h#L642-L645
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.3#n977
Regards,
Markus
next prev parent reply other threads:[~2026-10-24 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 7:15 [PATCH rdma v6 0/7] Add ZTE DingHai Ethernet Protocol Driver for RDMA Yanze Zhang
2026-10-24 7:15 ` [PATCH 1/7] RDMA/zrdma: Add build infrastructure and module skeleton Yanze Zhang
2026-10-24 7:15 ` [PATCH 2/7] RDMA/zrdma: Add core data structures and ABI definitions Yanze Zhang
2026-10-24 18:33 ` kernel test robot
2026-10-24 7:15 ` [PATCH 3/7] RDMA/zrdma: Add internal headers and hardware register definitions Yanze Zhang
2026-10-24 8:43 ` Markus Elfring [this message]
2026-10-24 7:15 ` [PATCH 4/7] RDMA/zrdma: Add hardware resource initialization and verbs skeleton Yanze Zhang
2026-10-24 7:15 ` [PATCH 5/7] RDMA/zrdma: Add device probe and remove logic Yanze Zhang
2026-10-24 7:15 ` [PATCH 6/7] RDMA/zrdma: Implement context, PD, and mmap operations Yanze Zhang
2026-10-24 7:15 ` [PATCH 7/7] RDMA/zrdma: Implement device and port query operations Yanze Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17e2204c-b16a-43f4-bf13-9e897d611736@web.de \
--to=markus.elfring@web.de \
--cc=han.chengfei@zte.com.cn \
--cc=han.junyang@zte.com.cn \
--cc=huangjunxian6@hisilicon.com \
--cc=jgg@ziepe.ca \
--cc=julianbraha@gmail.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ran.ming@zte.com.cn \
--cc=wei.quan@zte.com.cn \
--cc=yanjun.zhu@linux.dev \
--cc=zhang.yanze@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®