From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C38DF1509AB for ; Sun, 16 Nov 2025 14:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763303432; cv=none; b=ICRBEUURmwDcrHoyUxKJR4CJewqn23GVHwWqODmlYbNgEokby0Sb8LCkqMASl/00g7vNICdnusGFIiM/eN0XVz8rR4cK7b4LH/araKT8R6Uox24irkmZtF4AGoIx0hMHJnNWgVmBQ1fBuY5PvH66PvAIJhSrE3AZHDfg91RdYJo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763303432; c=relaxed/simple; bh=cKfwNVXUaXw3bJO+IzX0argy2DWs0KoFFvj0/LYhR1w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fEwI+tVwUo0x18CudsSLthRcMho1uHrl5mItEF5SzMpx8iudcxjuSAc5QuAhpIDLagVKp7A4tfM/PrK6mE0xNDLWtIbaG8mZINzdfw8K6xExuFKoTe+FKMWL4vUw6+TEqPZRzyLooIrg3CoOELIn68xDMKuPkNbZz7dCpBtgUVE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LbNGIqJN; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LbNGIqJN" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-42b39d51dcfso1832229f8f.2 for ; Sun, 16 Nov 2025 06:30:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763303429; x=1763908229; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ICly7sZCAzATlOBf/FaB2qKaAu95N0j13h8tQwyhW4A=; b=LbNGIqJN1fUSQv3hrhvdT5K6dvjS2eea0mF+9v+Npsn8CfGfdufTskxXV47uJ3s5oS JzfZNFPv/GCZ+82ZgwdOR2FxzAai9YUlnmsZ9FYya1jxHL14K0+xJEyfe6XiKwX6z8tw YnG13a5yNKadpXZ8gVPx2M8z6SNDRAYgKaFsriTCzaXjybmy2LDEEBQR+u+InaZzCUVB fslTYj2pj12rfLx8iO7VUow8NxaHL4uVqP03NIbntwGly8k7PtlApahdj/uc16eYSPZA mcVJ6EZX80uWOq8QHFYKOYuMtUrcMGW2RqgukNl3EjCmxEX8LZvpK5PqlZXQ0bcc4krm LbNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763303429; x=1763908229; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ICly7sZCAzATlOBf/FaB2qKaAu95N0j13h8tQwyhW4A=; b=Zq9oIwS74WxTWSxcIWqz92c7Qm5H7SM1qgpg3NzS7YqOKw2sF/4Q5rHNdvxOBcppbb YsDGsC8fgr3ieWgAmbAz50Qc+jQip6rdpimqwWmJuxUfOsGM6NoMAPcePSzvZyCjNyNu f0515hvT4Ba7AE4NMBfaHDXmiQ+lmC79dFWCzyioRLxU596q1Ec6trQNWZTZjk+N3bvO bTBbJPjV3zTiRO3HFPyXvbcjYaFDHSJJQYpt6uLCDElaRJ8CiG/KRoTw2bQhI0MuDTy4 RV33cc/Dep+AtiukiUHQgw1qHAu51HXI1wH96l0Q2iexGk9zQ2cd+tgB0Y7cWxYAcnZh 9OGQ== X-Forwarded-Encrypted: i=1; AJvYcCVEY7ZA68+6oP4EvSTz9ajVkoAqb35WztjsRx/NKA2AO+eY34GsPnekQVlrJ1EB/LHFOZn6Utxq9PT3U8o=@vger.kernel.org X-Gm-Message-State: AOJu0YwmQ44TCYlO62hzCP29AdLfHSUyjtx543wbMj/TYdoZISWyP0Yd 6DD/0poizxGV93QxDWe8gxrtJdf0WjxMpIpKjRrsbqnzot/JSb6ercR5fj++7o1Djjw= X-Gm-Gg: ASbGncvgf6huKxcYxgFdiWVKjL6iOnPEAPYXoMEb/g0xL6JrfvDGBLX5drIDW4XNpQz v2BxDwhhOncrqbWiXFwtSkladA1yM9sYDH+X0buWMDs0u+SLztT0+clpaac3mrg6AHsfMOZIyj8 SnxMAk8lzFxCFZO1QDu+uV+CWPYzTxRneOqhN35lErKI8I2QLNFtyipoxAlI8PNEPGfx0n3nkuC 7ZZ7mGqyc4spePb+xVllxkYBHPHTriBY7gMcpOtzMaNtk47Gg7zbRu4/pzEw69cwqP0t3e6mgo5 ez6e7z6C5Yhd5e0sGbvxLip+XaPVumKf4dERFAdettT6RWBoKXgBTmT0cIY1wYVF5sDqHB2o4El 7LzxNk0N5oiLEfNr12c81repbREhi8ljRR5LCI6sai3KU6iWq21vXWWX9r1eQS0dcW9pS5z1Wug ASe3JaZ/hRDQ0eorbhwCFMndJoLNnhdxPvBcMRyHHmbQ== X-Google-Smtp-Source: AGHT+IEfYLpYpa20g5wtNTk5jZFkM5xmSMDzaYixuhuIpmallSrBBPr8uUgJe9xMGpqXeRcYfT73jQ== X-Received: by 2002:a05:6000:3108:b0:42b:3ee9:4775 with SMTP id ffacd0b85a97d-42b593394a9mr9581497f8f.11.1763303428862; Sun, 16 Nov 2025 06:30:28 -0800 (PST) Received: from [192.168.0.27] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e85cc0sm21886040f8f.17.2025.11.16.06.30.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Nov 2025 06:30:28 -0800 (PST) Message-ID: <17e7ebc9-3b88-4334-b87d-1bce6d5bb120@linaro.org> Date: Sun, 16 Nov 2025 14:30:27 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/3] Add CAMSS support for SM6350 To: Luca Weiss , Bryan O'Donoghue , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <3ph8XeidoxkUIsK7qiOH29pde94sdwa3ReWKVVrPabgS5enIAmwVAC5plyFnBMJGKQBnxFB6df6j69OMFIeavw==@protonmail.internalid> <20251114-sm6350-camss-v2-0-d1ff67da33b6@fairphone.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14/11/2025 15:59, Luca Weiss wrote: > On Fri Nov 14, 2025 at 4:51 PM CET, Bryan O'Donoghue wrote: >> On 14/11/2025 11:15, Luca Weiss wrote: >>> Add bindings, driver and dts to support the Camera Subsystem on the >>> SM6350 SoC. >>> >>> These patches were tested on a Fairphone 4 smartphone with WIP sensor >>> drivers (Sony IMX576 and IMX582), the camera pipeline works properly as >>> far as I can tell. >>> >>> Though when stopping the camera stream, the following clock warning >>> appears in dmesg. But it does not interfere with any functionality, >>> starting and stopping the stream works and debugcc is showing 426.4 MHz >>> while the clock is on, and 'off' while it's off. >>> >>> Any suggestion how to fix this, is appreciated. >>> >>> [ 5738.590980] ------------[ cut here ]------------ >>> [ 5738.591009] gcc_camera_axi_clk status stuck at 'on' >>> [ 5738.591049] WARNING: CPU: 0 PID: 6918 at drivers/clk/qcom/clk-branch.c:87 clk_branch_toggle+0x170/0x190 >> >> Do you have a full and complete kernel tree we could look at here ? > > Sure, this branch has everything in: > > https://github.com/sm6350-mainline/linux/tree/sm6350-6.17.y/ > > For further refence, at least two other people have tested this branch > in postmarketOS, nothing particularly exciting to report from there, > apart from that the sdm-skin-thermal thermal zone (thermistor right next > to SoC) is currently configured with 55 degC as critical trip, which is > quickly achieved when starting a video recording, but that's not really > an issue with camss, but will need some tweaking regardless. > > https://gitlab.postmarketos.org/postmarketOS/pmaports/-/merge_requests/7281 diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c index a4d6dff9d0f7f..229629ef82809 100644 --- a/drivers/clk/qcom/gcc-sm6350.c +++ b/drivers/clk/qcom/gcc-sm6350.c @@ -908,9 +908,7 @@ static struct clk_branch gcc_camera_ahb_clk = { static struct clk_branch gcc_camera_axi_clk = { .halt_reg = 0x17018, - .halt_check = BRANCH_HALT, - .hwcg_reg = 0x17018, - .hwcg_bit = 1, + .halt_check = BRANCH_VOTED, .clkr = { .enable_reg = 0x17018, .enable_mask = BIT(0), ? --- bod