From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8402D63113 for ; Thu, 7 Mar 2024 07:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709798123; cv=none; b=EOkccRbqNprpgxDiBBS0scYZI69bOpM8PYF+bxElREjqKZe4yh2QjVdBJ1NWVpjyIol8IJclwt6e4/HtWrlbVr4V6P6aWbMShVyMCrf9MugMYCPBmVjq0DNbBsacgtavYNVsT9RWcpVYg+uUfAkBqaAHMpUmFPeT6vPcjTWbCUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709798123; c=relaxed/simple; bh=Aa66jG2WGimBH4GX5jmV/YXE8uZyBO6e9RgV/X53laE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NHHNwuC8JSq/GMMCyjQV4E4bs6B+Grbdm5ONyQwvA0KmK4fK/SvCuIdRGChM22MkD+wjF1OCGd2y3PrNCLc8Y4dHJXC6t7SrpbzrsL6orqmSwc0X0kkKSwV8zF8o/9L7qk/kOOtdZXOnPI5c3ohk28LWdWbhpYuYLzx889bSm/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vUInqjBw; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vUInqjBw" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a44d084bfe1so77796466b.1 for ; Wed, 06 Mar 2024 23:55:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709798120; x=1710402920; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Bn0DWqG7g9N74WkvhFXOQ0ffZSSFhFrSnC9Q4XDpoto=; b=vUInqjBwkR9a9RVfmg7a2IODcxTrbnVbXOEfzFN0264q073mNb80bbBgjHP8Do/nVc wp7Wx1qxIdhGNQMSSWKZ7NFGHf8mDLbKzo6aMaz9W+9nyd5QFzFTheD49vjzk/KtTMIt ZtieHxPNI2w0mAk4Kp8MTnSsml3ZhdD9LSYPrQrmSexAspUPt3YlBX8wnkUgAqx5m0/P jjhRNQQfDn6U6fmNJqG+voG7IJpRCOLruKXL20NGZKQMkjxnaiyBc04Kn7OXEJcTzQJL CXpr0BuuE1EKA7Nw36gGiapCd6RwREdTJVqIk7U2+elGEv/pTDqGI4hB18Oz+dxgHHa0 7gxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709798120; x=1710402920; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Bn0DWqG7g9N74WkvhFXOQ0ffZSSFhFrSnC9Q4XDpoto=; b=RERKcd6pNtFLFTyT+pBau8KjTylRzsof+0RQtfGHNs5HETwMPx1ET3zMVzSR4qFaPO Z0WbQncG6QyG88ZRi1CMHpcLhfSH/OyJke64C2RgFhTGVWyapDaEqjUkW5N4OrJGi2gm cM/Hcg/OHDhqUZHgAy8zo+l/raWiIPb2Svv0C+3xT8YE+TCGKkf8z94G4n0HkRgs3E7B p6bOG7Y8VXbdAQDGlBVAW9gyQDIxoGRqRCZS0wtNaSdZgYeNeBPsigCGtC55GAc2IycA MejiHdFD3XXDfY1i0IsprvqAGzXvALfZCCfwa9mC0aX6PTB7rU0q4OBIQG3VIHF0AVmk DyMg== X-Forwarded-Encrypted: i=1; AJvYcCUwfJA51MGD+KkRyycADXPMf3f9t19Awof2Kpn5npWsj/Eyd98rUozQv7cl0HZZqZq/Echw6E3uMWuzEmHos7VGu0k/zFMDAdTUmLV6 X-Gm-Message-State: AOJu0Yx8z16UX/jJaVYC1qJpt9d7uffvwEbyBCYakaBGPi0Q72V3Bst9 BCEvkZsBO9WGNO9A32Xjc632dL29fzuLBFG9ZpWXAxLEpdLR5lsG3Xml9iAc2gU= X-Google-Smtp-Source: AGHT+IHWh6qHbiDAcCnz7U/s5fQPQnTrwoA3CIOujNr0ES6F4oppiRIthyVdwep26V/Yz6L0NmQdfQ== X-Received: by 2002:a17:906:a456:b0:a3f:5144:ada2 with SMTP id cb22-20020a170906a45600b00a3f5144ada2mr11682129ejb.2.1709798119161; Wed, 06 Mar 2024 23:55:19 -0800 (PST) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id lb7-20020a170906adc700b00a4479997b97sm7037985ejb.66.2024.03.06.23.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 23:55:18 -0800 (PST) Date: Thu, 7 Mar 2024 10:55:15 +0300 From: Dan Carpenter To: Changhuang Liang Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , Laurent Pinchart , Jack Zhu , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-staging@lists.linux.dev" Subject: Re: =?utf-8?B?5Zue5aSNOiBbUEFUQw==?= =?utf-8?Q?H?= v1 5/7] staging: media: starfive: Add ISP raw video device Message-ID: <17e9c68f-0019-4b76-908b-6763fb24eb22@moroto.mountain> References: <20240306093334.9321-1-changhuang.liang@starfivetech.com> <20240306093334.9321-6-changhuang.liang@starfivetech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 07, 2024 at 02:13:50AM +0000, Changhuang Liang wrote: > Hi, Dan > > [...] > > > > > > +err_rm_links0: > > > + media_entity_remove_links(&isp_dev->subdev.entity); > > > > I don't think this line is correct. I think we only need to remove > > &cap_yuv->video.vdev.entity. > > > > The instance I refer to needs to clear both the source entity and the sink entity. See > https://elixir.bootlin.com/linux/v6.8-rc7/source/drivers/media/platform/verisilicon/hantro_drv.c#L855 > Oh yeah. It's the same in v4l2_m2m_register_media_controller(). regards, dan carpenter