mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Joseph Lo <josephl@nvidia.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/6] clocksource/drivers/tegra: Restore timer rate on Tegra210
Date: Wed, 12 Jun 2019 09:30:02 +0100	[thread overview]
Message-ID: <17eac2c4-41fa-a616-83e9-fa18a9e1483d@nvidia.com> (raw)
In-Reply-To: <20190610164400.11830-2-digetx@gmail.com>


On 10/06/2019 17:43, Dmitry Osipenko wrote:
> The clocksource rate is initialized only for the first per-CPU clocksource
> and then that rate shall be replicated for the rest of clocksource's
> because they are initialized manually in the code.
> 
> Fixes: 3be2a85a0b61 ("Support per-CPU timers on all Tegra's")
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  drivers/clocksource/timer-tegra.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clocksource/timer-tegra.c b/drivers/clocksource/timer-tegra.c
> index 9406855781ff..830c66e2d927 100644
> --- a/drivers/clocksource/timer-tegra.c
> +++ b/drivers/clocksource/timer-tegra.c
> @@ -277,6 +277,8 @@ static int __init tegra_init_timer(struct device_node *np, bool tegra20,
>  		 */
>  		if (tegra20)
>  			cpu_to->of_clk.rate = 1000000;
> +		else
> +			cpu_to->of_clk.rate = timer_of_rate(to);
>  
>  		cpu_to = per_cpu_ptr(&tegra_to, cpu);
>  		cpu_to->of_base.base = timer_reg_base + base;

Thanks. This fixes a boot regression we are seeing on -next with
Tegra210 (introduced by the commit referenced above). So ...

Acked-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic

  reply	other threads:[~2019-06-12  8:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10 16:43 [PATCH v2 0/6] Few more cleanups for tegra-timer Dmitry Osipenko
2019-06-10 16:43 ` [PATCH v2 1/6] clocksource/drivers/tegra: Restore timer rate on Tegra210 Dmitry Osipenko
2019-06-12  8:30   ` Jon Hunter [this message]
2019-06-12 16:02     ` Dmitry Osipenko
2019-06-10 16:43 ` [PATCH v2 2/6] clocksource/drivers/tegra: Remove duplicated use of per_cpu_ptr Dmitry Osipenko
2019-06-14 15:48   ` Jon Hunter
2019-06-10 16:43 ` [PATCH v2 3/6] clocksource/drivers/tegra: Set and use timer's period Dmitry Osipenko
2019-06-14 15:48   ` Jon Hunter
2019-06-14 16:45     ` Dmitry Osipenko
2019-06-17 10:51       ` Jon Hunter
2019-06-17 14:04         ` Dmitry Osipenko
2019-06-18  8:40           ` Jon Hunter
2019-06-18  9:41             ` Dmitry Osipenko
2019-06-10 16:43 ` [PATCH v2 4/6] clocksource/drivers/tegra: Drop unneeded typecasting in one place Dmitry Osipenko
2019-06-14 15:48   ` Jon Hunter
2019-06-10 16:43 ` [PATCH v2 5/6] clocksource/drivers/tegra: Add verbose definition for 1MHz constant Dmitry Osipenko
2019-06-14 15:48   ` Jon Hunter
2019-06-10 16:44 ` [PATCH v2 6/6] clocksource/drivers/tegra: Restore base address before cleanup Dmitry Osipenko
2019-06-14 15:48   ` Jon Hunter
2019-06-14 16:51     ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17eac2c4-41fa-a616-83e9-fa18a9e1483d@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=digetx@gmail.com \
    --cc=josephl@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome