From: Dmitry Osipenko <digetx@gmail.com>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Joseph Lo <josephl@nvidia.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] ARM: dts: tegra30: Add External Memory Controller node
Date: Fri, 12 Apr 2019 13:11:31 +0300 [thread overview]
Message-ID: <17f2a6b4-8017-0581-d7a2-6ff1cd914df1@gmail.com> (raw)
In-Reply-To: <20190412080606.GH12975@pdeschrijver-desktop.Nvidia.com>
12.04.2019 11:06, Peter De Schrijver пишет:
> On Fri, Apr 12, 2019 at 02:02:21AM +0300, Dmitry Osipenko wrote:
>> Add Add External Memory Controller node to the device-tree.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
> ..
>> diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c
>> index 38ebdb076ccd..defdb38bde54 100644
>> --- a/drivers/memory/tegra/tegra30-emc.c
>> +++ b/drivers/memory/tegra/tegra30-emc.c
>> @@ -980,7 +980,8 @@ static long emc_round_rate(unsigned long rate,
>> }
>>
>> if (!timing) {
>> - dev_err(emc->dev, "no timing for rate %lu\n", rate);
>> + dev_err(emc->dev, "no timing for rate %lu min %lu max %lu\n",
>> + rate, min_rate, max_rate);
>> return -EINVAL;
>> }
>
> This doesn't seem to belong to this patch?
Yes, I accidentally edited a wrong patch on rebase. Fixed it up for v2 already, thank you.
prev parent reply other threads:[~2019-04-12 10:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 23:02 [PATCH v1 0/3] memory: Introduce NVIDIA Tegra30 EMC driver Dmitry Osipenko
2019-04-11 23:02 ` [PATCH v1 1/3] dt-bindings: memory: Add binding for NVIDIA Tegra30 External Memory Controller Dmitry Osipenko
2019-04-11 23:02 ` [PATCH v1 2/3] memory: tegra: Introduce Tegra30 EMC driver Dmitry Osipenko
2019-04-12 14:01 ` Dmitry Osipenko
2019-04-11 23:02 ` [PATCH v1 3/3] ARM: dts: tegra30: Add External Memory Controller node Dmitry Osipenko
2019-04-12 8:01 ` Peter De Schrijver
2019-04-12 10:09 ` Dmitry Osipenko
2019-04-12 8:06 ` Peter De Schrijver
2019-04-12 10:11 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17f2a6b4-8017-0581-d7a2-6ff1cd914df1@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pdeschrijver@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®