From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755614AbdJLKvg (ORCPT ); Thu, 12 Oct 2017 06:51:36 -0400 Received: from mout.web.de ([212.227.15.14]:65251 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbdJLKva (ORCPT ); Thu, 12 Oct 2017 06:51:30 -0400 Subject: [PATCH 10/10] staging/irda/net: Use seq_puts() in four functions From: SF Markus Elfring To: devel@driverdev.osuosl.org, netdev@vger.kernel.org, Al Viro , Corentin Labbe , David Howells , "David S. Miller" , Georgiana Chelu , Greg Kroah-Hartman , Johannes Berg , Julia Lawall , Samuel Ortiz , Srishti Sharma , Stephen Hemminger , Yuan Linyu Cc: LKML , kernel-janitors@vger.kernel.org References: <8152401b-d68d-c4fe-2619-82a09e0c52ec@users.sourceforge.net> Message-ID: <17f62072-0f1d-c32c-c568-02a0690235b7@users.sourceforge.net> Date: Thu, 12 Oct 2017 12:50:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <8152401b-d68d-c4fe-2619-82a09e0c52ec@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:z4gFC/P4wqYUge7msssCzyLBzuEg9Tpe08vCg9H9XJ5v09aTtg5 PH6N0YOR3X3m2W7YitvRmDexWe0B7nENVhTOmTb1/P1ax++v+TDY3NzlRBvAUmLfdRSgNH0 2yI/KDToZf0oRH2NbQGTKxpFwX+gFf0B2jdnez8t6gMmhGXVkj2WxXZ/5YETW/widc0Zm7V wmUFUY3os5bhifL4w1SKg== X-UI-Out-Filterresults: notjunk:1;V01:K0:yZcrNeD/SNo=:7EXb1tftJY7+iMonf9jWAp SiIVuAkDjWz+RQdiapSnosjts6tksg0qCknnykvRc1H3i3XTma/+B7Ohee8bwvYYDVsAW2Um6 yGh2HV39AOlRm104oQ+9HdMAurvSq3PbAdjDpjqLphKs7JM25mneliC5L/0Y+thL11O03AU7m Pd8Qr+7dCXdsU69eyJQRXoXCBXKLH2OqH18ZS4nF0FkJT1VBCfAc/PPpm6Q+3AXQggegIiLUh 1TfwJGpvqSXpunozx1xSA/Gm7LFhiSLzr+rcUQaq7p4ElpdOdmhQEhlMda5O+lbAqkY+zIesH K46U6eX8zDJfzbBfAfdWMOnPu9MR0Xx3iXrkVXUrjlkUsnWG2ASQQDxHdfRU3QE8TlCVUpXHL FUlOZDBsXN2eLQ/Mj0G1lcHFqc+YUJMDCEOFK9FTgb6W3qhAp2w8cm+w3huSQ7swlJE5BEoP/ F8mfCpss+aTW/TiAVwlftPP82wmshSQvfM/uARrdGdWZ+MxZoDsK7WeINlETrgphqhhNtm1WK UJ8dflNkBPMj4j87iTRbs8MoBqwMNO4rE0SOK8/cwbtEO/GlF4rvnntKiEurtYfyhKN7nlWba krNhNSNAugHktaTDi6ITXeScZh2JEi7Oau4ydXX82F6LR1DuCl75pQL2LHHbIFqNq5N7DRmZl yxt6HpIPjRBpRWMLJXoQMCMGV8B5ONU3PJWrFPNuz6HFDVCeH6pxf11j5ITtB/nZFLXGOmECx pVsw7s9Y8X4lvhUuzKRVHF88TA0V1OrKMcNJAULb5edWw06bZv1ejB+kuQyZaoJhw/pG1wtko Xrr9BNCAKNd5mfhZHow0exw3zxmDm7f0gGP2caOj31OhEggYvQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 12 Oct 2017 11:08:36 +0200 Strings which did not contain a data format specification should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/irda/net/ircomm/ircomm_core.c | 8 ++++---- drivers/staging/irda/net/ircomm/ircomm_tty.c | 2 +- drivers/staging/irda/net/irlan/irlan_common.c | 3 +-- drivers/staging/irda/net/irlmp.c | 2 +- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/staging/irda/net/ircomm/ircomm_core.c b/drivers/staging/irda/net/ircomm/ircomm_core.c index 6c02fbf380bd..9bb2ff306470 100644 --- a/drivers/staging/irda/net/ircomm/ircomm_core.c +++ b/drivers/staging/irda/net/ircomm/ircomm_core.c @@ -530,13 +530,13 @@ static int ircomm_seq_show(struct seq_file *seq, void *v) self->slsap_sel, self->dlsap_sel); if(self->service_type & IRCOMM_3_WIRE_RAW) - seq_printf(seq, " 3-wire-raw"); + seq_puts(seq, " 3-wire-raw"); if(self->service_type & IRCOMM_3_WIRE) - seq_printf(seq, " 3-wire"); + seq_puts(seq, " 3-wire"); if(self->service_type & IRCOMM_9_WIRE) - seq_printf(seq, " 9-wire"); + seq_puts(seq, " 9-wire"); if(self->service_type & IRCOMM_CENTRONICS) - seq_printf(seq, " Centronics"); + seq_puts(seq, " Centronics"); seq_putc(seq, '\n'); return 0; diff --git a/drivers/staging/irda/net/ircomm/ircomm_tty.c b/drivers/staging/irda/net/ircomm/ircomm_tty.c index d1beec413fa3..dc7097576917 100644 --- a/drivers/staging/irda/net/ircomm/ircomm_tty.c +++ b/drivers/staging/irda/net/ircomm/ircomm_tty.c @@ -1174,7 +1174,7 @@ static void ircomm_tty_line_info(struct ircomm_tty_cb *self, struct seq_file *m) seq_printf(m, "Port name: %s\n", self->settings.port_name); - seq_printf(m, "DTE status:"); + seq_puts(m, "DTE status:"); sep = ' '; if (self->settings.dte & IRCOMM_RTS) { seq_printf(m, "%cRTS", sep); diff --git a/drivers/staging/irda/net/irlan/irlan_common.c b/drivers/staging/irda/net/irlan/irlan_common.c index 481bbc2a4349..f4633d4dc390 100644 --- a/drivers/staging/irda/net/irlan/irlan_common.c +++ b/drivers/staging/irda/net/irlan/irlan_common.c @@ -1138,8 +1138,7 @@ static int irlan_seq_show(struct seq_file *seq, void *v) seq_printf(seq,"media: %s\n", irlan_media[self->media]); - seq_printf(seq,"local filter:\n"); - seq_printf(seq,"remote filter: "); + seq_puts(seq, "local filter:\nremote filter: "); irlan_print_filter(seq, self->client.filter_type); seq_printf(seq,"tx busy: %s\n", netif_queue_stopped(self->dev) ? "TRUE" : "FALSE"); diff --git a/drivers/staging/irda/net/irlmp.c b/drivers/staging/irda/net/irlmp.c index 6a09cf621bd4..60a3dd7d6f49 100644 --- a/drivers/staging/irda/net/irlmp.c +++ b/drivers/staging/irda/net/irlmp.c @@ -1937,7 +1937,7 @@ static int irlmp_seq_show(struct seq_file *seq, void *v) * the object spinlock, so we are safe. Jean II */ spin_lock(&lap->lsaps->hb_spinlock); - seq_printf(seq, "\n Connected LSAPs:\n"); + seq_puts(seq, "\n Connected LSAPs:\n"); for (self = (struct lsap_cb *) hashbin_get_first(lap->lsaps); self; self = (struct lsap_cb *)hashbin_get_next(lap->lsaps)) { -- 2.14.2