From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEFF52309B8 for ; Tue, 10 Dec 2024 09:30:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823012; cv=none; b=dD36AeShHOVSkjJbWEwxxu9xi1B/jgx0d/LWt7YuU7b3eImV1ERc1YBjFcUw3sWrzRAhmqtQpaM0D3lnirE+tK9jY6DUepHZin/wFeTVygbXpaciQSt0Z0X9GKarwd0BcEwJ1F2MF1k1G9CHqVIlE4TNtQ8d6a+bX53peZqn+oU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823012; c=relaxed/simple; bh=Kg0ml7q/uTeZdhBo8EQJ1qPIIiQTMTbHbt8bgvJnfCM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jQyr9OgoTIozYjNZU9uzs9h9HpHaKAiOnXQ3FVph6CTY3dZBEYHDPOiZq4iYm0RW/wzOFMX7t4YWrJWD1KVdb70jStfz0JBvE29ipXnzXlfrA5/7WF7JvJL7v2YunxfXQDlqTLA8Y9v0EzNT4BoYWXZtt/GM0OR9+hSNKUd+DMo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=RHBaj1n3; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=ZmXHaoQS; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ieaOn3JA; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=briS2PGg; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="RHBaj1n3"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ZmXHaoQS"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ieaOn3JA"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="briS2PGg" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DFD2621163; Tue, 10 Dec 2024 09:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1733823009; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MsRXhfg7m6WBy42Qcy0/Di6ALyOV53TIJv7tHMpkd+o=; b=RHBaj1n3iJk6VBUqBtSYrOzh5QF5K+hTHe28AX1+t0TFJtCfE0MRYXgUAmHOH5e+woxKru JzsSu29DoRXgacsOe06QkQV6KSIl8xhhMfxBy74zhH4cQIhL9LbMLPsQlV+lE8CCi8+7xW GyQH1o7J6VrUyFumvXMtsH2qxydH8x4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1733823009; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MsRXhfg7m6WBy42Qcy0/Di6ALyOV53TIJv7tHMpkd+o=; b=ZmXHaoQSlR2WGrFMUZJ0mKe3Ix7iM87ZqadLUOS/U947UdZ8uON+qKM9KeN0hPoJKadnMq plGLRFAFuyp8zLCw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ieaOn3JA; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=briS2PGg DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1733823008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MsRXhfg7m6WBy42Qcy0/Di6ALyOV53TIJv7tHMpkd+o=; b=ieaOn3JAfckjgBWHk/YdS8xDFP7P3ZOw5TM60W+egnXo7oWawl0p3czxp4lJj+PdvRc4kL pOqLj5uOMoYW/9gIGSmeVQj2uWPtmQU9efgwbrLbzBLT9p6NYCvlRevYVxTQs0QKkB1ZI+ G4/jZGVUTxHH0u6P1POi0DJU0dx2QPg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1733823008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MsRXhfg7m6WBy42Qcy0/Di6ALyOV53TIJv7tHMpkd+o=; b=briS2PGgTX1W3OQN5/1VFvzzJXBxq1O9IRvIGVcKTb3EKmqn+InnPApKJh+MqkR0ZqTULP bZIe4Cj1s2xFPADw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 87012138D2; Tue, 10 Dec 2024 09:30:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id AV8GHyAKWGe0MgAAD6G6ig (envelope-from ); Tue, 10 Dec 2024 09:30:08 +0000 Message-ID: <17f9367a-2958-40d7-b514-c4373647bf22@suse.de> Date: Tue, 10 Dec 2024 10:30:08 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [v2] drm: rework FB_CORE dependency To: Arnd Bergmann Cc: Arnd Bergmann , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Jocelyn Falempe , Javier Martinez Canillas , Geert Uytterhoeven , Jani Nikula , Harry Wentland , Masahiro Yamada , Jonathan Cavitt , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20241115162323.3555229-1-arnd@kernel.org> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20241115162323.3555229-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: DFD2621163 X-Spam-Level: X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TAGGED_RCPT(0.00)[renesas]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[15]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[arndb.de,linux.intel.com,kernel.org,gmail.com,ffwll.ch,redhat.com,glider.be,intel.com,amd.com,lists.freedesktop.org,vger.kernel.org]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid]; RCVD_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Score: -3.01 X-Spam-Flag: NO Hi Am 15.11.24 um 17:23 schrieb Arnd Bergmann: > From: Arnd Bergmann > > The 'select FB_CORE' statement moved from CONFIG_DRM to DRM_CLIENT_LIB, > but there are now configurations that have code calling into fb_core > as built-in even though the client_lib itself is a loadable module: > > x86_64-linux-ld: drivers/gpu/drm/drm_fbdev_shmem.o: in function `drm_fbdev_shmem_driver_fbdev_probe': > drm_fbdev_shmem.c:(.text+0x1fc): undefined reference to `fb_deferred_io_init' > x86_64-linux-ld: drivers/gpu/drm/drm_fbdev_shmem.o: in function `drm_fbdev_shmem_fb_destroy': > drm_fbdev_shmem.c:(.text+0x2e1): undefined reference to `fb_deferred_io_cleanup' > ... > x86_64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_set_suspend': > drm_fb_helper.c:(.text+0x2c6): undefined reference to `fb_set_suspend' > x86_64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_resume_worker': > drm_fb_helper.c:(.text+0x2e1): undefined reference to `fb_set_suspend' > > In addition to DRM_CLIENT_LIB, the 'select' needs to be at least in > two more parts, DRM_KMS_HELPER and DRM_GEM_SHMEM_HELPER, so add those > here. > > Fixes: dadd28d4142f ("drm/client: Add client-lib module") > Signed-off-by: Arnd Bergmann > --- > v2: keep the select in DRM_CLIENT_LIB, keep alphabetic sorting > --- > drivers/gpu/drm/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index a4a092ee70d9..410bd6d78408 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -98,6 +98,7 @@ config DRM_KUNIT_TEST > config DRM_KMS_HELPER > tristate > depends on DRM > + select FB_CORE if DRM_FBDEV_EMULATION This line gives me error: recursive dependency detected!         symbol BACKLIGHT_CLASS_DEVICE is selected by FB_BACKLIGHT         symbol FB_BACKLIGHT is selected by FB_SH_MOBILE_LCDC         symbol FB_SH_MOBILE_LCDC depends on FB_DEVICE         symbol FB_DEVICE depends on FB_CORE         symbol FB_CORE is selected by DRM_KMS_HELPER         symbol DRM_KMS_HELPER is selected by DRM_MIPI_DBI         symbol DRM_MIPI_DBI is selected by DRM_PANEL_ILITEK_ILI9341         symbol DRM_PANEL_ILITEK_ILI9341 depends on BACKLIGHT_CLASS_DEVICE I'm leaving it out for now. Best regards Thomas > help > CRTC helpers for KMS drivers. > > @@ -371,6 +372,7 @@ config DRM_GEM_DMA_HELPER > config DRM_GEM_SHMEM_HELPER > tristate > depends on DRM && MMU > + select FB_CORE if DRM_FBDEV_EMULATION > select FB_SYSMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION > help > Choose this if you need the GEM shmem helper functions -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)