From: Krzysztof Kozlowski <krzk@kernel.org>
To: zhangsenchuan <zhangsenchuan@eswincomputing.com>
Cc: gregkh@linuxfoundation.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Thinh.Nguyen@synopsys.com, p.zabel@pengutronix.de,
ningyu@eswincomputing.com, linmin@eswincomputing.com,
yangwei1@eswincomputing.com, pinkesh.vaghela@einfochips.com
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: Add Eswin EIC7700 USB controller
Date: Thu, 31 Jul 2025 08:11:29 +0200 [thread overview]
Message-ID: <17f9763b-7ae5-4429-ab16-058eddf9c79c@kernel.org> (raw)
In-Reply-To: <1f9a715d.3bb7.1985ef71b54.Coremail.zhangsenchuan@eswincomputing.com>
On 31/07/2025 07:31, zhangsenchuan wrote:
>>
>>> + #address-cells = <2>;
>>> + #size-cells = <2>;
>>> +
>>> + usb@50480000 {
>>> + compatible = "snps,dwc3";
>>> + reg = <0x0 0x50480000 0x0 0x10000>;
>>
>> Nothing improved and you did not respond to the feedback.
>
> I'm very sorry that I haven't given you any feedback here. I'm not quite clear about what you mean by feedback.
> In v1 patch, you mentioned "Fold the child node into the parent"，could you please tell me what's the exact
> meaning of this comment?
It means you should not have separate child for dwc3, but only one node
in total.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-31 6:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 7:39 [PATCH v2 0/2] Add driver support for Eswin eic7700 SoC " zhangsenchuan
2025-07-30 7:40 ` [PATCH v2 1/2] dt-bindings: usb: Add Eswin EIC7700 " zhangsenchuan
2025-07-30 7:46 ` Krzysztof Kozlowski
2025-07-31 5:31 ` zhangsenchuan
2025-07-31 6:11 ` Krzysztof Kozlowski [this message]
2025-07-30 7:41 ` [PATCH v2 2/2] usb: dwc3: eic7700: Add EIC7700 USB driver zhangsenchuan
2025-08-06 0:17 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17f9763b-7ae5-4429-ab16-058eddf9c79c@kernel.org \
--to=krzk@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=pinkesh.vaghela@einfochips.com \
--cc=robh@kernel.org \
--cc=yangwei1@eswincomputing.com \
--cc=zhangsenchuan@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®