From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B2831BD01F for ; Fri, 20 Dec 2024 09:45:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734687913; cv=none; b=UrCTLAj+yBITjuNs5ULkxaKrvC6fbUSn1LV5N8hw/AwESSGT9dJ0vZg0ZfH0xQuTYTiSsHI9kkjdZxwZPl+w3u6vPyC6D4coARhw/re64vecqUbd1DdrkSiNl7A21PxmdiszZkMnxpYdzZYhT/InWXOroLszE4vHcvA7oKOgMxI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734687913; c=relaxed/simple; bh=rgbIsEXKrNUTh9N1VFln1ZCjKPm8rV2hssaSdAVAMN0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J/NrS3ABp1lT0WE7DlEuC629+WteeAn6xkfEfGKhL8TPtYnpL8q+9Yj9TqKsUD0dHUqDnFQGhictz/LTXREwCDSaed3VPkq05vChsxsVyvuejwGBoAesNnpzQjaQfu9oAHsWlt8rWm6QwOtonuFIuImmtyAvslkG/z1p3KaQg4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Yffz7OE5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Yffz7OE5" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BK8fdDi025822 for ; Fri, 20 Dec 2024 09:45:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9t8ArwAGrpS//NdxnvpTo28cKSL+hVeeidKueQ14eto=; b=Yffz7OE5C6rf+ELc w4FCEAy5QTkziXKW6QlLDxjRKfL+7d0QVKliwiyr7RIz3mAOB8bkiF+9P2Jw6xqP nyhUW1TyCd37ffTWNw7xRurr/z4p+6m5B/gyBxu8IqjIxaXHAHDXgLnh107Rdgf8 n8S0Whi8V0Y4ytEuQkje9ePv8+W0DeFsSc86if9CT/W1pXjCfoNUDCzTCyVYI3jH iyYOkTIy7fYNX3/aWBlg0wq9q6+r12LiTdg4tIeb5ZeyojLvaQF8u7BonK2U0/TW jIzrCi17SvkxjJkfvsT0yaR0uRX2OCHB/4yHZuTUBHnCxLn2M6FkiZencYotVrUQ 1pfFoQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43n59x85by-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 20 Dec 2024 09:45:10 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4679ef4565aso3101651cf.2 for ; Fri, 20 Dec 2024 01:45:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734687910; x=1735292710; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9t8ArwAGrpS//NdxnvpTo28cKSL+hVeeidKueQ14eto=; b=ZV7IbxJPIVCi991WenQTtZSpqixX4K2QAjgUt2eCm/60v+4QxdIt0/wrtdf6qxULBb y3w1XYCEqqAe9A1ogBFgDsLOjFpIqX1AD1xK0sMgJ8Y4XrNClRxy2tKLnJqDU8jRruli fTZXDY7mwtdQ93aALX+7OrdBkULq2/7n521gH1Xgy9VSm2QBkAfsVs550vO/PTvYPTwK E/vTjB13ddNmQqbWmesxeNIk3G8WCNXaEDNgdpkaDzUyIf9hgR/ALsiZxbTK0kauSW72 4toqE9tuisofAdubbwnMDyAst3SNfs4ozReAbVy/X2Ee9Fe9wDMMMh01lQaUqNQcxorK uHLg== X-Forwarded-Encrypted: i=1; AJvYcCUlon1jQuzMmC2gHSlSJPrwgOUTDTP36FEzC2kfaIiqipmu7UK1qU3GmpuCVZNu7f3yi6gpDFGhDI9ok6I=@vger.kernel.org X-Gm-Message-State: AOJu0YwNGXVT1/hKXB/ol7Ec6p50EB4fq4rcic3gKFTgL3cBtro64zH3 9syAN/LdSbO2QD60JMLKQn4nkZYuSDhlCLgaZnNNU3GKy3lOtoFfMCKRV/pBetaTNVm3e632l4c UukeOAqzEx+NGT9P8xEcO2Co40wyvDR2gHj0Z+fT/PsNBnLm1ln5GxqEjrDKIm4E= X-Gm-Gg: ASbGnctipeM7mKVcr6Sxp3BPRhd3R4f+x8FFRatZt5oUnMr8yA8lcMxKPBorelSeiNi PSqUzFbJe76uqnv4G6A0uMf+0vLSHv16uBzQUo+4Y9EQIcM9BVWJKeXfLsne3cHD81JGW4MHqBF g48PDldkQVJEhSA8CQhEh4sUuvPCedlZTaDEBzHRQDFdE+MH9VAWRQYAw62Qn9/n1FvU14hoFMJ efcnwW4GW4gFffM76l6yf+r4GO4XJ97X/bJ0W0Wyy4/vuj5ABIKbF/UYznbBfyv/pNx2441AD6y qSK0CMYNaxN+uU127kyEbal6+TVyOGJD4lY= X-Received: by 2002:a05:622a:5cc:b0:460:7929:3575 with SMTP id d75a77b69052e-46a4a9daba6mr14655341cf.16.1734687910164; Fri, 20 Dec 2024 01:45:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGf+tTYMFgzn7IzxK2YYOAOa+4TPDlGAcKmLrdpJ7UTEWxIiYZqZsZRaQjTIPUanMegHW11Qg== X-Received: by 2002:a05:622a:5cc:b0:460:7929:3575 with SMTP id d75a77b69052e-46a4a9daba6mr14655141cf.16.1734687909794; Fri, 20 Dec 2024 01:45:09 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0efe41a6sm159635166b.102.2024.12.20.01.45.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 01:45:09 -0800 (PST) Message-ID: <17ff74d9-2336-446e-95bf-be8d70d20a07@oss.qualcomm.com> Date: Fri, 20 Dec 2024 10:45:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: ipq5424: add spi0 node To: Manikanta Mylavarapu , Konrad Dybcio , andersson@kernel.org, linus.walleij@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, konradybcio@kernel.org, quic_srichara@quicinc.com, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_varada@quicinc.com References: <20241217091308.3253897-1-quic_mmanikan@quicinc.com> <20241217091308.3253897-4-quic_mmanikan@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: a4i6DmyamXq3aS6idI80_OCoS46j7RCg X-Proofpoint-GUID: a4i6DmyamXq3aS6idI80_OCoS46j7RCg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 suspectscore=0 bulkscore=0 mlxscore=0 adultscore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 spamscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412200080 On 20.12.2024 8:25 AM, Manikanta Mylavarapu wrote: > > > On 12/20/2024 2:06 AM, Konrad Dybcio wrote: >> On 17.12.2024 10:13 AM, Manikanta Mylavarapu wrote: >>> Add SPI0 node for IPQ5424 SoC. >>> >>> Signed-off-by: Manikanta Mylavarapu >>> --- >>> Changes in V2: >>> - No change >>> >>> arch/arm64/boot/dts/qcom/ipq5424.dtsi | 11 +++++++++++ >>> 1 file changed, 11 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi >>> index 5e219f900412..b4d736cd8610 100644 >>> --- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi >>> @@ -201,6 +201,17 @@ uart1: serial@1a84000 { >>> clock-names = "se"; >>> interrupts = ; >>> }; >>> + >>> + spi0: spi@1a90000 { >>> + compatible = "qcom,geni-spi"; >>> + reg = <0 0x01a90000 0 0x4000>; >>> + clocks = <&gcc GCC_QUPV3_SPI0_CLK>; >> >> This register base suggests SPI4 for both the name and clock >> > > Hi Konrad, > > Thank you for reviewing the patch. > > The IPQ5424 doesn't have SPI4, and according to the Qualcomm IPQ5424 register catalog, > the register base maps to SPI0. I'm looking at that register catalog and what you added here is called SE4 > >> The existing UART1 similarly should be UART0 > > I didn't understand your comment. UART0 not yet posted. > In IPQ5424, UART1 is the main UART used for console > and UART0 is HS-UART used for some debugging purpose. Here it's my mistake, 0x01a84000 is SE1 indeed Konrad