From: Paul Mackerras <paulus@samba.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: David Woodhouse <dwmw2@infradead.org>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] $ARCH: Enable arbitary speed tty ioctls and split input/output speed
Date: Mon, 28 May 2007 14:47:40 +1000 [thread overview]
Message-ID: <18010.24300.599531.828815@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20070524160559.54c2c639@the-village.bc.nu>
Alan Cox writes:
> On Thu, 24 May 2007 09:45:37 -0400
> David Woodhouse <dwmw2@infradead.org> wrote:
>
> > On Thu, 2007-05-24 at 14:41 +0100, Alan Cox wrote:
> > > Most people copied the x86 behaviour which makes it easy to transplant.
> > > Some are just smoking something (see ioctls.h for sh-64 and weep), others
> > > have slightly odd behaviour for historical compatibility reasons (Sparc)
> >
> > Likewise, I assume the lack of IBSHIFT on PowerPC is because of AIX?
>
> I assume nobody ever got around to it. CIBAUD is in the PowerPC System V
> API supplement for example and is supported by other Power OS's.
The guys that did the original ppc linux port (mainly Gary Thomas and
Cort Dougan, I believe) tended to follow the alpha and x86 linux ports
rather than the System V ABI. There aren't any SysV-based OSes for
PowerPC still extant so it doesn't really matter.
And yes, nobody has got around to implementing CIBAUD/IBSHIFT.
> > Why bother introducing new IBSHIFT stuff when it can be declared
> > obsolete already -- if you want different input and output baud rates,
> > just set BOTHER and have different values c_ispeed and c_ospeed.
>
> BOTHER is for the output speed. BOTHER << IBSHIFT is for the input speed
> if it different to the default (and you need B0 << IBSHIFT to know if an
> input speed is being specifically set in the first place).
>
> CIBAUD and IBSHIFT come from standards documents so it appears to make
> sense at some level to support those standards. As everyone else in the
> Power world supports it I don't see why Linux should be different.
Sure, we can add them. I suggest IBSHIFT = 16 and CIBAUD = 0xff0000
(or 077600000 if we are going to continue the peculiar convention of
using octal for the C* constants).
Paul.
next prev parent reply other threads:[~2007-05-28 4:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 16:27 [PATCH] ARM/ARM26: " Alan Cox
2007-05-23 16:27 ` Russell King
2007-05-24 13:08 ` [PATCH] $ARCH: " David Woodhouse
2007-05-24 13:41 ` Alan Cox
2007-05-24 13:45 ` David Woodhouse
2007-05-24 15:05 ` Alan Cox
2007-05-24 15:18 ` David Woodhouse
2007-05-28 4:47 ` Paul Mackerras [this message]
2007-06-06 12:33 ` David Woodhouse
2007-06-08 11:18 ` [PATCH] PowerPC: " David Woodhouse
2007-06-06 12:30 ` [SERIAL] Don't optimise away baud rate changes when BOTHER is used David Woodhouse
2007-06-06 15:03 ` Alan Cox
2007-06-06 17:29 ` David Woodhouse
2007-06-07 15:38 ` Alan Cox
2007-06-07 15:50 ` David Woodhouse
2007-06-07 21:55 ` Alan Cox
2007-06-07 22:04 ` David Woodhouse
2007-06-07 22:15 ` David Woodhouse
2007-06-07 22:54 ` Alan Cox
2007-06-08 11:01 ` David Woodhouse
2007-06-08 11:48 ` Alan Cox
2007-06-08 11:48 ` David Woodhouse
2007-06-08 11:13 ` David Woodhouse
2007-06-08 11:14 ` [SERIAL] Don't optimise away baud rate changes when BOTHER is used (v2) David Woodhouse
2007-06-08 11:42 ` Alan Cox
2007-06-06 12:34 ` [PATCH] Minor cleanups in tty_ioctl.c David Woodhouse
2007-06-06 13:09 ` Jiri Slaby
2007-05-28 19:36 ` [PATCH] ARM/ARM26: Enable arbitary speed tty ioctls and split input/output speed Russell King
2007-05-28 21:56 ` Andrew Morton
2007-05-28 22:00 ` Russell King
2007-05-29 8:31 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18010.24300.599531.828815@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®