From: Jiri Slaby <jirislaby@kernel.org>
To: xie.ludan@zte.com.cn, davem@davemloft.net
Cc: edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next] net: atm: use sysfs_emit() instead of scnprintf().
Date: Mon, 17 Mar 2025 07:22:34 +0100 [thread overview]
Message-ID: <18022b24-1480-4062-9c18-193729efacef@kernel.org> (raw)
In-Reply-To: <20250315141249338P9_QqSBAnqEi-DZYDTtR5@zte.com.cn>
On 15. 03. 25, 7:12, xie.ludan@zte.com.cn wrote:
> @@ -37,7 +37,7 @@ static ssize_t atmaddress_show(struct device *cdev,
>
> spin_lock_irqsave(&adev->lock, flags);
>
> list_for_each_entry(aaddr, &adev->local, entry) {
>
> -count += scnprintf(buf + count, PAGE_SIZE - count,
>
> +count += sysfs_emit(buf + count,
This is wrong too [1].
[1]
https://lore.kernel.org/all/9c552d9a-2d46-4069-a9c4-35fab857bfc3@kernel.org/
regards,
--
js
suse labs
next prev parent reply other threads:[~2025-03-17 6:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-15 6:12 xie.ludan
2025-03-17 6:22 ` Jiri Slaby [this message]
2025-03-19 17:03 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18022b24-1480-4062-9c18-193729efacef@kernel.org \
--to=jirislaby@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xie.ludan@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®