From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Nikolaus Voss <nv@vosn.de>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Len Brown <lenb@kernel.org>, Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Xiongfeng Wang <xiongfeng.wang@linaro.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Ray Jui <ray.jui@broadcom.com>,
Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>,
Vikram Prakash <vikram.prakash@broadcom.com>,
Scott Branden <scott.branden@broadcom.com>,
Srinath Mannam <srinath.mannam@broadcom.com>,
Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
Subject: Re: [PATCH v2] ACPI: bus.c: Let acpi_device_get_match_data() return DT compatibility data
Date: Mon, 09 Jul 2018 11:20:16 +0200 [thread overview]
Message-ID: <18030756.yHdBu7e6UJ@aspire.rjw.lan> (raw)
In-Reply-To: <CAHp75Vd2u9o50h3VQQrJZfu6fYhxydG4gRD4U5u+LuxTUScSwQ@mail.gmail.com>
On Wednesday, July 4, 2018 4:40:34 PM CEST Andy Shevchenko wrote:
> On Tue, Jul 3, 2018 at 9:09 AM, Nikolaus Voss <nv@vosn.de> wrote:
> > When using ACPI with ACPI_DT_NAMESPACE_HID/ PRP0001 HID and referring to
> > of_device_id table "compatible" strings in DSD, a pointer to the
> > corresponding DT table entry should be returned instead of a null
> > pointer. An acpi_device_id match still takes precedence.
> >
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> with a caveat that this is only an improvement for a _temporary_
> PRP0001 users like I2C or SPI slave devices.
> Please, don't consider this change as a valid point to (ab)use PRP0001
> in a cases where devices are not "hotpluggable".
>
> > v2: improve readability (as suggested by Andy Shevchenko)
> >
> > Signed-off-by: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
Nikolaus, please resend the v2 with the Andy's tag to linux-acpi@gver.kernel.org
It won't be applied otherwise.
Thanks,
Rafael
next prev parent reply other threads:[~2018-07-09 9:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <950e8d0caf9f5f55df07eba8a11b2fa8cba9f9e1.1530708691.git.nikolaus.voss@loewensteinmedical.de>
2018-07-04 14:40 ` Andy Shevchenko
2018-07-09 9:20 ` Rafael J. Wysocki [this message]
2018-07-24 13:31 ` Nikolaus Voss
2018-07-24 13:30 ` Nikolaus Voss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18030756.yHdBu7e6UJ@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=nikolaus.voss@loewensteinmedical.de \
--cc=nv@vosn.de \
--cc=pmeerw@pmeerw.net \
--cc=ray.jui@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=srinath.mannam@broadcom.com \
--cc=sudeep.holla@arm.com \
--cc=vikram.prakash@broadcom.com \
--cc=vladimir.olovyannikov@broadcom.com \
--cc=xiongfeng.wang@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®