From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753359AbdCAVo2 convert rfc822-to-8bit (ORCPT ); Wed, 1 Mar 2017 16:44:28 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:58632 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbdCAVoY (ORCPT ); Wed, 1 Mar 2017 16:44:24 -0500 Date: Wed, 1 Mar 2017 20:41:16 +0100 (CET) From: Stefan Wahren To: Gerd Hoffmann , Eric Anholt , linux-rpi-kernel@lists.infradead.org Cc: will.deacon@arm.com, rjui@broadcom.com, lee@kernel.org, linux@armlinux.org.uk, robh+dt@kernel.org, ulf.hansson@linaro.org, linux-arm-kernel@lists.infradead.org, sbranden@broadcom.com, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, bcm-kernel-feedback-list@broadcom.com, linux-mmc@vger.kernel.org, swarren@wwwdotorg.org, mark.rutland@arm.com, f.fainelli@gmail.com, devicetree@vger.kernel.org Message-ID: <180442771.37741.1488397276709@email.1und1.de> In-Reply-To: <87varsequk.fsf@eliezer.anholt.net> References: <1487668026-7100-1-git-send-email-kraxel@redhat.com> <1487668026-7100-3-git-send-email-kraxel@redhat.com> <87tw7c27xk.fsf@eliezer.anholt.net> <68761051.37200.1488396112552@email.1und1.de> <87varsequk.fsf@eliezer.anholt.net> Subject: Re: [PATCH v3 2/7] mmc: bcm2835: Add new driver for the sdhost controller. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.1-Rev32 X-Originating-Client: open-xchange-appsuite X-Provags-ID: V03:K0:WOW/od+8nqWcawJLSJrMCCzcug/VOvUOAa5tzCxFFl1H9+m9k5i fIA9C07KX0WIchtrTHqPE/LG+SvR3pRMxZ8ImL109Tg4VFu23Is5sGqkMtQUl0UGmKvdorS YVwygfRHJW6dn/50Fq0gmQcYKCHF1kAJuMQoEg+3duf2rwraHP++K8y2yJlP7037gC1rJDQ kFFvUHLC7JCn4WktrhcWQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:WERrdWk2xH0=:l9aWWk1tuTn91zfNGlrx1o qU62JB4t+2N+5oVjC//PNYez5JtxMXPbcFGmZV3mgrRm87uYOPc+v/NsZU8xcm0x7ISdZ046i nB5Ge77y7Mpbyp3RxTnfJOJZRZrmNXa5g2mTCGrsmc8EqKPvG/Sol22Ta3JI+YNF9L5SG0o6P eLexARuJaoCd56dmwucT9k0z2WI0R2GyZ0xtA4SVoiqZoltxiCjzD8KVQ0io9ZWBvVFeaMej/ lWiXW4H3KEKx8NfkZ9YW89jb6pmLNjEsDfQdc9qva5hArS0f9S8cpYBLZ54EvTYdKOekyFNYk zkT863xflxzXMCRLAJExM2VGIvdDTSeQWQGrods3qdHgIPsuVwem2UNWrMn5inWXmMitDBdvR D8Xw2v3gOE3mul7CXduTTMUwUicqAM1QVLdVPL9xjRz7ebgJDGlSfbORud1LSGrKLjfEJCPl6 Nqs0fOCTmvBoJAn9URZN42Gwi5W3+A/teVpgekeiP6/aMqaKLtH8UPiL8LjCj5cnKwPa/yxcV zvVnKBury7p5cqFfmfQ/kBaxol53rJQK5TWRCKPAKBrHn8lBLBATHz6bLOYMLMLVMI7jSA9Y1 PER1+UM8NnOLNmuPf4cJqc4LY/9jxR8czHDxV2Y6w06uELXZZaSbtrrE9Rw1MEd+HJCRmbzGa heL8fYVKZ0wWfJdO7995hRfcGE2RSxi/R9X3gUr5UMBr+Z+oHWpJjzwXTgrCPeaKw9C6TCPwc 92g88vslszqXkWx3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Eric Anholt hat am 1. März 2017 um 20:31 geschrieben: > > > Stefan Wahren writes: > > >> Eric Anholt hat am 1. März 2017 um 19:00 geschrieben: > >> > >> > >> Gerd Hoffmann writes: > >> > >> > From: Eric Anholt > >> > > >> > The 2835 has two SD controllers: The Arasan sdhci controller (supported > >> > by the iproc driver) and a custom sdhost controller. This patch adds a > >> > driver for the latter. > >> > > >> > The sdhci controller supports both sdcard and sdio. The sdhost > >> > controller supports the sdcard only, but has better performance. Also > >> > note that the rpi3 has sdio wifi, so driving the sdcard with the sdhost > >> > controller allows to use the sdhci controller for wifi support. > >> > > >> > The configuration is done by devicetree via pin muxing. Both SD > >> > controller are available on the same pins (2 pin groups = pin 22 to 27 + > >> > pin 48 to 53). So it's possible to use both SD controllers at the same > >> > time with different pin groups. > >> > > >> > The code was originally written by Phil Elwell in the downstream > >> > Rasbperry Pi tree, and I did a major cleanup on it (+319, -707 lines > >> > out of the original 2055) for inclusion. > >> > > >> > Signed-off-by: Eric Anholt > >> > >> Ulf, what do you need done to this driver patch before it can go in? > >> The commit message seems like it could use some rewriting at this point > >> (Personally I would drop the detailed changelogs from Stefan and Gerd, > >> updating the last paragraph here to give them credit), but what's > >> important to me is getting the driver in so that distros don't have to > >> carry this patch for wifi support. > > > > I'm still working on 3 small patches for this driver: > > > > 1. trivial error in a register comment > > 2. ignore SDCMD_FAIL_FLAG during bcm2835_finish_command (downstream [1]) > > 3. remove unnecessary call to bcm2835_reset_internal > > > > I plan to submit them on Friday. > > > > [1] - https://github.com/raspberrypi/linux/commit/711cade866c9f865f9b283c9369e9486f27d1fec > > Should any of those changes block merging the current code, though? No, but the recursion about bcm2835_finish_command() and bcm2835_transfer_complete() is still there.