From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935429AbcIAQrm (ORCPT ); Thu, 1 Sep 2016 12:47:42 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:40683 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935363AbcIAQrh (ORCPT ); Thu, 1 Sep 2016 12:47:37 -0400 Subject: Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg To: Eric Dumazet References: <9d5c5525f369f1c4098bda989d73886d11036bae.1472155176.git-series.robert.foss@collabora.com> <1472748216.5019.46.camel@edumazet-glaptop3.roam.corp.google.com> Cc: freddy@asix.com.tw, Dean_Jenkins@mentor.com, Mark_Craske@mentor.com, davem@davemloft.net, ivecera@redhat.com, john.stultz@linaro.org, vpalatin@chromium.org, stephen@networkplumber.org, grundler@chromium.org, changchias@gmail.com, allan@asix.com.tw, andrew@lunn.ch, tremyfr@gmail.com, colin.king@canonical.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, vpalatin@google.com, Grant Grundler From: Robert Foss Message-ID: <18052c6d-2cb1-0927-7d33-92d4bd397aa4@collabora.com> Date: Thu, 1 Sep 2016 12:47:27 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472748216.5019.46.camel@edumazet-glaptop3.roam.corp.google.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-09-01 12:43 PM, Eric Dumazet wrote: > On Mon, 2016-08-29 at 09:32 -0400, robert.foss@collabora.com wrote: >> From: Robert Foss >> >> From: Grant Grundler >> >> The miii_nway_restart() causes a PHY link change activity and >> ax88772_link_reset will be called. link_reset will set >> AX_CMD_WRITE_MEDIUM_MODE register correctly. >> >> The asix_write_medium_mode in reset() fills in a default value to the register >> which may be different from the negotiation result. So do this first. >> >> Ignore the ret value since it's ignored in XXX_link_reset() functions. >> >> Signed-off-by: Grant Grundler >> Signed-off-by: Robert Foss >> Tested-by: Robert Foss >> --- > > This is _really_ confusing Robert. > > Why having two 'From:' clauses ? > > Who wrote the patch in the first place ? You or Grant ? I'm not quite sure how the first From line was added, it should not have been. Grant Grundler is most definitely the author. Would you like me to resubmit in v++ and make sure that it has been corrected? > > > > End result is : > > commit 535baf8588d04b177cb33700f81499f2b5203c2d > Author: Robert Foss > Date: Mon Aug 29 09:32:19 2016 -0400 > > net: asix: autoneg will set WRITE_MEDIUM reg > > From: Grant Grundler > > The miii_nway_restart() causes a PHY link change activity and > ax88772_link_reset will be called. link_reset will set > AX_CMD_WRITE_MEDIUM_MODE register correctly. > > The asix_write_medium_mode in reset() fills in a default value to the register > which may be different from the negotiation result. So do this first. > > Ignore the ret value since it's ignored in XXX_link_reset() functions. > > Signed-off-by: Grant Grundler > Signed-off-by: Robert Foss > Tested-by: Robert Foss > Signed-off-by: David S. Miller > > > > I guess Grant wrote the patch, but attribution is wrong. > >