From: Markus Elfring <Markus.Elfring@web.de>
To: Aditya Pakki <pakki001@umn.edu>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Kalle Valo <kvalo@codeaurora.org>, Kangjie Lu <kjlu@umn.edu>
Subject: Re: [PATCH] orinoco: avoid assertion in case of NULL pointer
Date: Mon, 16 Dec 2019 10:50:45 +0100 [thread overview]
Message-ID: <180574a2-ec2f-cbe0-3458-02b5228db51e@web.de> (raw)
In-Reply-To: <20191215195900.6109-1-pakki001@umn.edu>
> The patch replaces the BUG_ON call to error return.
Would a wording like “Replace the BUG_ON() call by a return of an error code
after a null pointer check” be nicer for this change description?
Will the tag “Fixes” become helpful here?
Regards,
Markus
next prev parent reply other threads:[~2019-12-16 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 19:58 Aditya Pakki
2019-12-16 9:50 ` Markus Elfring [this message]
2019-12-18 19:09 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=180574a2-ec2f-cbe0-3458-02b5228db51e@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=kjlu@umn.edu \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®